From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1044885AbdDWLLG (ORCPT ); Sun, 23 Apr 2017 07:11:06 -0400 Received: from mout.web.de ([212.227.15.4]:63758 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1044745AbdDWLLD (ORCPT ); Sun, 23 Apr 2017 07:11:03 -0400 Subject: Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() To: Tobias Jakobi , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Dan Williams , Javier Martinez Canillas , Krzysztof Kozlowski , Kukjin Kim , LKML , kernel-janitors@vger.kernel.org References: <930f0a6c-bc5c-3d01-6814-563780fc90ef@users.sourceforge.net> <9c10b823-f49b-8c73-2bf8-0fd2b0ba0231@users.sourceforge.net> <02134825-fec7-73d7-2eb6-b510eaaf3b08@users.sourceforge.net> <49f1c0b2-7463-2121-1aed-0998f6635c92@math.uni-bielefeld.de> From: SF Markus Elfring Message-ID: Date: Sun, 23 Apr 2017 13:10:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <49f1c0b2-7463-2121-1aed-0998f6635c92@math.uni-bielefeld.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:DO/0lwqNvr9kShDMSxu7aMI1KAds1fbhPC37cgPp01quth/bAzd sS2CzFEMvM50HCIimCIhh/nieph5K/+W61dWAVMLSI5JX++snKoJuefx8B+LaIppjVHLGKs HwjT6/EEoyjvWYuO1x9z0dSTaT6mwQ+9JZd46wO1/tyKUggrb+RUkZIpXuDwLoGlmMMdUMG xrImm9RtZVRpHWJVTfwGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:DlVKUC3Hn+w=:3Ib3uuB5MqPFHm9I/RC+Oj dpujQjztPaER2OBSwR0IRMufgkno10OuG0Orz0+YkmMG8Nh60XEh1kZcBWFz0JrecRP63pxiq whwaMRmXa7neGFpLFqTuNwhNhLkAp7Z1L87oxYhI6Wr4BC/PmrT5BDj2cxU7xLldKzBygQ0ll f9bK5YkEiwjZVMgybZkFYizA3YoO2aK2ZI+c/vQNUdFbNF5PXnpKwdsRO9X0Bm3v7l2HT1ytW AKzmVbnxXFUUOJsVoWNiZvj2MCTNrnOQKP3P5h6TDm1kdhSzecTPDRCITlszgp5XXzcuHyE1D wKDQlPwilzuPtkPQEAZmgDxt/OoHBzzNpizCLQOx1wPTr1jv5bs5k2qzWdjE7tPTmpLfIPZti GmaCIk7nDVmXz3DOG4bSzeuCIsvKEwFm+3WplW8afMy83vMsHl/xEiLNTO4xW3YYeczk3mx3Y ykaQOQPmFNbWDiwMYvCOtkspjF4ZG0XD7iZ9xBqAVNyB0CikkLjL35bTw4mlnd8HyFoxPW67y MW0aHhbUNMWPJrH+2bd4Q+pG2baF3onvmUWudq8S0N6XRDfpIw1UFspP2dMjqUr2iVvXxLqt+ U3Mn63Q/C2CoQ4ORQ5n4qlrZFlgbz1S51x01vXNY94r05ivmrcOpuTH77SxFzu4/Ofapiq4dC rTlV/GijFC9RK1pdd2hSCUmsA1sZEXAgKDfC7QvYZavHwIcXEO5XxFkVkAQ4uJvxkq50xHM4B aW4wmgyvZ1lv93sWyVfBcwN4jAA7a8Uq8jvd+tyo51pmAacT0p9mk8nygRUJYoBTSmnrAIVny bURca/s Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication information inappropriate (or incomplete) at the moment? > Another sentence explaining why this is bad/undesirable. Which details do you miss here? > In this case, the output of the checkpatch script would come in handy. Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other search pattern so far. * Do you find it worthwhile to add a prefix like “devm_” to the used regular expression? * Would like to improve any related scripts for the semantic patch language (Coccinelle software) a bit more? > With this, you avoid cramming every information into one long and > complicated sentence. Thanks for your feedback about other wording preferences. Regards, Markus