From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E013BC25B4E for ; Tue, 24 Jan 2023 08:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbjAXI0U (ORCPT ); Tue, 24 Jan 2023 03:26:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbjAXI0R (ORCPT ); Tue, 24 Jan 2023 03:26:17 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB939EF1 for ; Tue, 24 Jan 2023 00:26:14 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id y11so17341056edd.6 for ; Tue, 24 Jan 2023 00:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2e7HEaZzLpkgKJ+mpx17xzcEDMDD/CmZJqe3c3ax7l0=; b=zncYDCgpGkMatClGm2DMi0c0OdVcLDIdyt7Rb9+a8egPe9nKd5uiikyemO8vz+bfmB MRPOX3cmhv3RPVHso+TAS6TGx4StMby9I+rUgSgSdmNgKT5Bu7Plj2aTZuXe/G6qJDo2 PdzSVUP4Tb8Yy3YhDaqgb3xOfjH5NRGzuZ693taFd9cp1UHCKtOYffDhVD51TxOxVCam 0V3SJOEUEPz1BXoNVDwiW0nZr+5pLlbwVB4+UUjOn8DF+FdHa62vDoI2AyUOttcEU2r5 yo+jAqoE+tumTM8Hu0xcYUo2N7F4cDEzhbZcFCRszTe6mIm8ySrNBALs4B415aOnQZo1 D6Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2e7HEaZzLpkgKJ+mpx17xzcEDMDD/CmZJqe3c3ax7l0=; b=CQ/lxCk64LD5gyds8JkNhQ5lpDA9mLGhBnhLzZJYv9AoKsvkAQ5LY5nozthH5PEs83 l7kDECfb2zuNIdsBfVbJIDUzmGUHVM6v5ISMXDnqkNDiPmmrE1OIn3T2EMfq0ubSSrIb Lhblu752GPpGbvLNcBo+aI/zK2CDi4EuyPZagqW0LdRsumf7DrXsJrONyhUhIvF48qMu 0J1XZ5wOWYUrmGgPfCi8V33oai0nmHn19S2ZtYyaZfATUB1zVRJbdLONE68qaLDln6Kw RycrsoLF3hQeCOUuomEXF35SSP/0RU0JGx335FQpXcYx7Jov3aFbN34DVe3/oU34eoyQ A+yA== X-Gm-Message-State: AFqh2krJkk6HRR15W8FHCGYu3EaKsvRdQzi4kvnrx2GA96uU1uq5V9ls YExmzbxl6gVjg/xB3vSi45FmcA== X-Google-Smtp-Source: AMrXdXvTlmdYJDkk7HNWHOpnCfo2eeTcCcUwQ4fhimZfI+UQoykA0RByBJDf74eFAZPIC7GmmB9kGw== X-Received: by 2002:aa7:c9ca:0:b0:49e:28c1:936c with SMTP id i10-20020aa7c9ca000000b0049e28c1936cmr26949737edt.26.1674548773533; Tue, 24 Jan 2023 00:26:13 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id b23-20020a17090636d700b0086dd8f20a6asm561330ejc.77.2023.01.24.00.26.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 00:26:12 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 10:26:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] drm/msm/mdp5: Add check for kzalloc Content-Language: en-GB To: Jiasheng Jiang , robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, quic_jesszhan@quicinc.com, ville.syrjala@linux.intel.com, yang.lee@linux.alibaba.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221206074819.18134-1-jiasheng@iscas.ac.cn> From: Dmitry Baryshkov In-Reply-To: <20221206074819.18134-1-jiasheng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2022 09:48, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check the return value > in order to avoid the NULL pointer dereference. > > Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for reset.") > Signed-off-by: Jiasheng Jiang > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry