From: Neil Armstrong <neil.armstrong@linaro.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Inki Dae <inki.dae@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"
Date: Fri, 26 May 2023 10:21:08 +0200 [thread overview]
Message-ID: <b8a3e7f0-d227-117f-443b-0f6b193e792b@linaro.org> (raw)
In-Reply-To: <20230526-oppressor-cabbie-fd5332dbc2cc@wendy>
On 26/05/2023 10:02, Conor Dooley wrote:
> On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote:
>> This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied
>> without review due to a bad tool manipulation.
>
> Is it a dt-binding maintainer review that you are missing on that
> patch?
Exact
>
> For this one:
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks, I'll apply this revert now and wait until the original
bindings patch gets properly reviewed.
Thanks,
Neil
>
> Thanks,
> Conor.
>
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> index 360fea81f4b6..9f61ebdfefa8 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> @@ -70,9 +70,7 @@ properties:
>> samsung,burst-clock-frequency:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> description:
>> - DSIM high speed burst mode frequency when connected to devices
>> - that support burst mode. If absent, the driver will use the pixel
>> - clock from the attached device or bridge.
>> + DSIM high speed burst mode frequency.
>>
>> samsung,esc-clock-frequency:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> @@ -82,8 +80,7 @@ properties:
>> samsung,pll-clock-frequency:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> description:
>> - DSIM oscillator clock frequency. If absent, the driver will
>> - use the clock frequency of sclk_mipi.
>> + DSIM oscillator clock frequency.
>>
>> phys:
>> maxItems: 1
>> @@ -137,7 +134,9 @@ required:
>> - compatible
>> - interrupts
>> - reg
>> + - samsung,burst-clock-frequency
>> - samsung,esc-clock-frequency
>> + - samsung,pll-clock-frequency
>>
>> allOf:
>> - $ref: ../dsi-controller.yaml#
>>
>> ---
>> base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5
>> change-id: 20230526-revert-bad-binding-f77a3ca96419
>>
>> Best regards,
>> --
>> Neil Armstrong <neil.armstrong@linaro.org>
>>
next prev parent reply other threads:[~2023-05-26 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 7:27 Neil Armstrong
2023-05-26 8:02 ` Conor Dooley
2023-05-26 8:21 ` Neil Armstrong [this message]
2023-05-26 8:36 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a3e7f0-d227-117f-443b-0f6b193e792b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®