From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013045.outbound.protection.outlook.com [40.107.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D870F4A32 for ; Mon, 29 Jun 2026 04:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782706285; cv=fail; b=gesQSFtYR+NWJOaioF7UYZEWZNttXfZsIz2iLcP7+bDGhlcwY/Y5+vfDQEUKEVWMvDfWFN90eraBBF16dY+n/6qdqGxBsJppIEr73q5xAy5MP32OnT6Z72i1YRrfNJ6mHtnNFA1SXnbBWzZXb+nHY6d9H5wyFqMhhT9wQfxtWKQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782706285; c=relaxed/simple; bh=YOMjDzMX1torvfEqx5XysoG4K1VgxvC+0rOQwhh88N4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fUzGR1IZ0kZ82I6w4b49VBpz4Qgynb0e+Jkig8ghtc/GCiJNzg7JYqalzYwkMO60gxMoI0WMHWMnTV5u8YpdmXaIqyqfHo4potSd/EvBafeXAZR6n5AAaQsaQeDnpQi9oYHykOTPVucejO06VNKUC1BEDCI1hCVGMdvbfk2lp+Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=SRlfYo8d; arc=fail smtp.client-ip=40.107.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="SRlfYo8d" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ow8gQ6+d/P2NogRMq+f40+X7wiUGXhjNhlLnH4hnlgYvuPzHB5gVoz6DPzJHzFwm5XWPMrKhZQtd8u2PLrOAq4sXQYhvZ6rZKp8gSzCxF0mzS+gk4QCrNz9rdDw6UVToGXPdtkhjX3LVhmJKTV7xMrHZcCDua7KDlmpkPFyq8QBogFfBKv0J/xFZMObE1AEOgJrXUDW5XPUqrK4XxrDI5Fd0JnChOKDojKmtLf5cCv+8SL2c2DISsliE7V9BAYaY6Ed49TVP8xqOMRNcSq+axzHVy22s0K6oyg3ccR2FhrKt0XAnAYB2hja2673qEJq3kNI4VKJM84nsKabu2KpDNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+uXmAkiJ0rFFTC2zbPH9BJavAknB+X5k2z/s3BzpiXw=; b=a4rSj5SoHSFStkdHFXEdLxVuc1izx4JdPXafOr5RdHGq7lGIJo64JFbGNjZuMdo7+JUF62vlZg02BdC6h1QeG3BETWK2aJ1Zt24p0q/6osnHlr+WjK0TlkKSMBtYRDdYgddmudM3G5hIMdZFAsjxpHmyFyoyphfgQMqP1vHcxSA6cRZc6JEQCBv3W0ls9unbVjI7s0+AsUV0Cd7ApsWYkC6Wb6GJgTuWG7nDWUxt+3L7z9ytEj5sFUnzoCGvoMY7zg/WN+qUTWpWT4Y+KocBnIvK73Z2bF+11hSnYzM9zWNs4M6XoNdIVjS33U5TPdb9h3XuGBQQkNt0Lz/05WZbtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uXmAkiJ0rFFTC2zbPH9BJavAknB+X5k2z/s3BzpiXw=; b=SRlfYo8d1Oj8y6wF1eb4btafZ3WwubhGqQzcHIhlPv6+yEeEew2VveHANVvgsfS/Z3CO230mO2rwA/mSzA9pqOlXO9Ec3yTbgi7K1W0feYzKlz/ASO2kRlUU9NjYe2Teqv8RpN0Dvk1ceS2/NXWBUh/I+Ehaek570Z0Og/uha6k= Received: from BL1PR13CA0317.namprd13.prod.outlook.com (2603:10b6:208:2c1::22) by LV2PR12MB5728.namprd12.prod.outlook.com (2603:10b6:408:17c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Mon, 29 Jun 2026 04:11:20 +0000 Received: from BL6PEPF00022574.namprd02.prod.outlook.com (2603:10b6:208:2c1:cafe::37) by BL1PR13CA0317.outlook.office365.com (2603:10b6:208:2c1::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.8 via Frontend Transport; Mon, 29 Jun 2026 04:11:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF00022574.mail.protection.outlook.com (10.167.249.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Mon, 29 Jun 2026 04:11:20 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Sun, 28 Jun 2026 23:11:19 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Sun, 28 Jun 2026 23:11:19 -0500 Received: from [10.136.39.208] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Sun, 28 Jun 2026 23:11:16 -0500 Message-ID: Date: Mon, 29 Jun 2026 09:41:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] sched: set TIF_NEED_RESCHED before calling __trace_set_need_resched() To: Sechang Lim , Ingo Molnar , "Peter Zijlstra" , Juri Lelli , "Vincent Guittot" CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Gabriele Monaco , References: <20260627081657.499781-1-rhkrqnwk98@gmail.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260627081657.499781-1-rhkrqnwk98@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022574:EE_|LV2PR12MB5728:EE_ X-MS-Office365-Filtering-Correlation-Id: e6737cbe-2880-4ed9-dd15-08ded5947964 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|82310400026|36860700016|1800799024|22082099003|18002099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: nX/K9FtLPqJp9nEcv/x9MyaBu0hpUKyLO5uaqfDAUBZf4BBoqbZIGIjJ5g9WaUR5NbYjcQawrLcRC1Jw7sPiL8/zzgasJcnKSattKGQtt4VEKOZyCYCbMkJmzqF1tvtr3TjKAbjlpQJhkBRCpGZUKS96lmB81JTO0jozEqRJod7LhxbeGAwPItI3kW3QLiMncFzIr75zeBOFqfPY/iHUSWKEddKYXC1F7VKGzm8sWKNrm+UlrX1tAMP9775TpRNDs7bCxC+vlE57hE6oUOyEGGe6jb1xbs8ZskMmy6bVGM5pfR3YRNYg9bK/GFNTtQpsNh5hKHw3nWes/HcvuFQyVgitfaUm5TdJf4DebwqLFeUUo1xBp0our5Df4QJFAKdwr4w2VsQ/izbK7IUeVjT5Darcvh1VTzZWQrqCHyVOIf5xloPXNpGhCk4AV7WEssWddo7CZTOWvOLPbU4rzQAhhEMsQcRgRUPK9H7yY+YWxHh7Hrz/vmY9f/pV3gJJHvOrVGeKJHosNnesaWbckDai7d3x6iNRpXoDozgk0zYKR52O5hUr8Z/cjAnHx7gCelvvPSXNOKuv3oPCFiGb30qn6P3DrAE2VEr9ajhcMAJnRpt9rbtoSYD25M8lNZNQ3e6zCZjVz3v0AQybDefizLd7YGSMmfRqJO34rxAE/e6ph81TdlovGGhvtUz6QhZB2WxR X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(82310400026)(36860700016)(1800799024)(22082099003)(18002099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gEl4fKe06TYUUC3+OdGu6250Us64djYAthR2ZAnkOvssefkEYbDEYFyejdsl158J+uN98OpsaBCinbEn2ZbbabFeHEGbuoUkcykji03zllg6j1UYococccM9NaOI/jDwz0Jm40Fzx6b0xB6oL9yTJr0L2VXchq1WQGFYHDL2YPcZpAbOD1CAHmM5TBF1rtKKyZr3j3IUzw+d7WwCO2wbmpGmPyfwHaKwU3JXSjPRPZ0j+wfd1uUsSfeqF14qHYAlV+JNf37x7Fpyy+B90nqz5ZzILwj3czhpxh4jSRuHfodvt6wlWP1i48YkmdyUx7XBYjQ6UFmy9WVAggy//3q7CWWpggBajVpIK33H1bYeY9zHidASf7jRRTIhoDe4vJEgeAhVvhAU0IiBAeoIrNOMlb8YJm+uUapUdTWWJdz0CiYjXLAfmfeLEKLivQJLW6k3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 04:11:20.1370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6737cbe-2880-4ed9-dd15-08ded5947964 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022574.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5728 Hello Sechang, On 6/27/2026 1:46 PM, Sechang Lim wrote: > static inline void clear_tsk_need_resched(struct task_struct *tsk) > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index b8871449d3c6..b358fac315d0 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1172,6 +1172,7 @@ static void __resched_curr(struct rq *rq, int tif) > struct task_struct *curr = rq->curr; > struct thread_info *cti = task_thread_info(curr); > int cpu; > + bool need_ipi; nit. This declaration can go before "int cpu;" to preserve the reverse x-mas arrangement for the independent variables. > > lockdep_assert_rq_held(rq); > > @@ -1187,15 +1188,17 @@ static void __resched_curr(struct rq *rq, int tif) > > cpu = cpu_of(rq); > > - trace_sched_set_need_resched_tp(curr, cpu, tif); > if (cpu == smp_processor_id()) { > set_ti_thread_flag(cti, tif); > if (tif == TIF_NEED_RESCHED) > set_preempt_need_resched(); > + trace_sched_set_need_resched_tp(curr, cpu, tif); > return; > } > > - if (set_nr_and_not_polling(cti, tif)) { > + need_ipi = set_nr_and_not_polling(cti, tif); > + trace_sched_set_need_resched_tp(curr, cpu, tif); Unrelated to changes here: This tracepoint seems to be missing from wake_up_idle_cpu() which modifies the ti->flags without taking the rq_lock. A newly enqueued timer can race with the wakeup on idle CPU and you can see a wakeup + sched_switch without seeing a corresponding trace_sched_set_need_resched_tp() for the CPU. Gabriele, is that a concern for RV? > + if (need_ipi) { > if (tif == TIF_NEED_RESCHED) > smp_send_reschedule(cpu); > } else { > -- > 2.43.0 > -- Thanks and Regards, Prateek