From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4842737A48D for ; Tue, 7 Apr 2026 20:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775594398; cv=none; b=rnfK4MhfMi2T75opUMrXEasgQ0zJKCTYSb9BfeNnZD1By/O8/LuQUbdzgLZ5c2GtFQIpXjnBlpfBq+PWaWFr5Yt12jR3GPOglyqE6BYeJgMruSVjieMVNybqHs7VbSg+RQTPViz3n/hjYdGi+Tw9AJgibZqxvnM1c0KuM5ZaADU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775594398; c=relaxed/simple; bh=ZTYvc5QlApW8b7c7LQqpkgRmOrJ9zY7/hhMO3WZOYAs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lc2WDbC6o8L9dnomT0mB+MBIURz/JRUO4hjcC28psHGpGfS5AVzGpEjmHjnd5OsgyFgSa1H7ESvSakqeqcixOB9STBhoNAagDDjbqf4/t+4pG58opz+a+eiiBlxU9X6tVvWSdyJd4pvb6mwk8YmEC16l57rCFVhy1fdXwj1tm90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d8mP/N7E; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8mP/N7E" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c56aa62931so11241691eec.0 for ; Tue, 07 Apr 2026 13:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775594396; x=1776199196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rG8uT7iFeLc6nzTWdSG+khDtXnia07K9+OVRfIk9nH4=; b=d8mP/N7E7yloPigwy6yVohOPrmIy1wlFLL5CffszTIPD6ONZmBWKdwJkplVITZe7n1 eEVNzB58aqomZM/xrGu8Gy1xwqI3j+J8PmVmW4VLNBSv2OaXdA6TVPqLx7pWZcM3Z5I4 3iFeLlo9bBjwGe1GyB4ELRvHI7KY7AauXFdHEsCduaV1DTtnv/ocnPm6WkbkFPfQE+zJ j4LE8QagayWyy5d35iN5s1uMfRrh5rwc9rEZQAlMd5KV+4RJz0nJC5RaktCChY5/gjgH JBqatH6jJ4zeWT3j2kLbW+qhb3qD+9N0RzRyFmsAhoYfnfLdXJ6W5F4WjQlJ8SuaWjZ4 yY3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775594396; x=1776199196; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rG8uT7iFeLc6nzTWdSG+khDtXnia07K9+OVRfIk9nH4=; b=DIbTdNH/KMnVNns4uPr1zQIGzX65uF0rDx+OkCoaXNUqBkCsIeZ7NrSIGNkesqYdBU c1WKBcSCNZsEw4naDrjCj7uWjYoN8zE8sVm2mRBTyMDbS/kw92WQhOp20hqTcpok1GX6 YYNNQnh0wRzW7UccylPdvDVwX10kqBG51NELFnZ16JY9xSo1rhx92CaNG+Nv2N6jvxvw jRlGk+ThpEGz75+FgHtbsBBN7Z2tkNo6YiGj87c9tpMTRP1R1ySV/UmYS1xsx6Hxvzoe ltefoDawAi98av0RUOPqsUcfBOeGFuy5yUkw08JuRqf8M2railhja1+dqF6oIVSLeiKc CBXA== X-Forwarded-Encrypted: i=1; AJvYcCWA8kvov6A8wk49XPlayKTvxuve4bUylZUlAFYJd/7eHde+ipc/y0jRS4og8+eZyVyXvNfHmk09/k17Z18=@vger.kernel.org X-Gm-Message-State: AOJu0YwKiqxSJpKe5iHhN1MX/it2mAaX8yDm0izTUJZYRU8BB5NwyaAF 8k6PqjR+G/IyPpm5beJ9v1Q2vOGVwGL0+vDQclW9Yt6d9UCfGwej4uyz X-Gm-Gg: AeBDieuvpWE72uGaj6CKfeaovfJ0G0kYzR8mjRerI/yYICvdAVIJ77tr3dbqLWVa0lJ QleipRQkruYm7hKJu5Ec0Iav76AhIoFxVrQY7qXlScP2BylZ+HqlGBUJkBhhnrCSfnLjIVYlc4V THiiiKc8JcWIPGD231KOKKwuiRw7OBKZC0sjcydydBCXQcz76zq+m6eXzdE/KmrtPi9UNS7F4// m6ncd3UjZgyCxZz6hQfnCcPQ4ZLEbFm7LYxmubYWkUIEwT2mk31MCXqXkinjC2S8ixPDTPsPp0O I8JzWA9NCKIQHXHnKBz0uEp8R4NgCJtr69J9V8fryzvClTxrUs2F6poskt9Fs24vLswxc1dC2IK x488bc3UQrI36jOgIwSYNqsXEuuqEmci432+pjYFcZTq+n5E+ryDQ3Qd778FwCsZfbpVVTV6XLp hhAyQlWNzUrU0WFkoIxkwlkCZSZ2bJ9Px+TFE0xQRhaC/ZnBrpXgBJEj0rU7ptWmik4JYhzgmkT hOAWPD0tQTDOW80 X-Received: by 2002:a05:7300:748b:b0:2c7:2c0b:f33b with SMTP id 5a478bee46e88-2cbfba8e8eamr10121436eec.20.1775594396260; Tue, 07 Apr 2026 13:39:56 -0700 (PDT) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2cf1af62347sm10824910eec.22.2026.04.07.13.39.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 13:39:55 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 13:39:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] ARM: dts: qcom: msm8960: expressatt: Sort node references and includes To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-expressatt_fuel_guage-v3-0-9674cfc0b5a2@gmail.com> <20260401-expressatt_fuel_guage-v3-1-9674cfc0b5a2@gmail.com> <8e4ee378-113e-463d-8b21-eeef74b84120@kernel.org> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: <8e4ee378-113e-463d-8b21-eeef74b84120@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/7/26 12:59, Krzysztof Kozlowski wrote: > On 01/04/2026 22:32, Rudraksha Gupta via B4 Relay wrote: >> From: Rudraksha Gupta >> >> Reorganize the DTS file for consistency with other msm8960 board files. >> >> Assisted-by: Claude:claude-opus-4.6 >> Signed-off-by: Rudraksha Gupta >> --- >> .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 408 +++++++++++---------- >> 1 file changed, 207 insertions(+), 201 deletions(-) >> > Sorry, but no. We are not taking Claude as one determining coding style. > Are we going to do the work again the moment we come with proper tool? There is no tool currently to auto format DTS, and doesn't seem to be coming for a while: https://www.youtube.com/watch?v=cvoIbTL_ZQA Claude didn't determine the coding style. I did based on sony-huashan, which is already upstream: https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom/qcom-msm8960-sony-huashan.dts I just used Claude to do the manual work for me. In v2, I made sure the diff before and after the change was nill. v3 included additional changes requested by Konrad and some comments that I remembered during prior attempts mainlining patch series for this device. > > Same comment as usually - this is highly invasive change which should be > done with dts linter, not LLM, not manually. > > Best regards, > Krzysztof