From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FD229375E for ; Fri, 23 May 2025 17:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748021613; cv=none; b=hmJpwk4NahajfZzeWxUTzawYAukVoBo1Fn3cbYsrPokL5DsnU1T/3Hlp4XxXKPVE1/opBR/kU88GB11+ikXjfRokOIECgmquPh4dDeZbC2iIwq6QwYzgKYyt0303Gv/ToJgfiMi547edkntJ1JJzuWxby0OWIl0trKb8CBqTUcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748021613; c=relaxed/simple; bh=qt/HVkr9zL2lJNeN6p4tMwnsp0x3rx/30xKqdVxveFw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y6SfN+E3V39Pf1WuaCNKfr711WIRI2AXkxrLljl1Pz0o8mZBA3NnMMKXWQbaaTtTJSN/gMPdte7M9n5+P8r9CUksi4mERdHmkPo31XQpGQsdT2cY9ssUcFrUfGqB/UANBfN0ljjB2BaXhG0aFCrxrLBgQWeJnsrmdhFtXlGhA+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Wbth+dAX; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Wbth+dAX" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6f8b10b807fso1235206d6.1 for ; Fri, 23 May 2025 10:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1748021609; x=1748626409; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qt/HVkr9zL2lJNeN6p4tMwnsp0x3rx/30xKqdVxveFw=; b=Wbth+dAXzBz7lwOEsCJZTtABNMJFUPNXtpVH5pdm0cKiz4a/FumZ/GwF8dp+73P2ep dEWQGvXf06lLcEcjKDiWu9IQdXzxJmU8QXElXPvfTsfpYJNs9WGSdrPtVYIJ16a09bv2 McuNVBhP3VxVaV8M0BWgSJj0yPR0LS30RNn4aKcO8cEoQZiYf98CNJBMCknO+qJperM+ HNuw9WcAtuFpuz5smi4wF7BDWpyLR8ak2xlPit6jtXD84EJCHFEMBykw4QscnD/hIbN/ 9ePn2rEGOK19OLAIEm6ArBJPFPCkAvdD7QoEz0k9GIGo49Cor8QWNRwHv2/eOzaVYIhi /jig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748021609; x=1748626409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qt/HVkr9zL2lJNeN6p4tMwnsp0x3rx/30xKqdVxveFw=; b=jErN9f6fSc4npeWATzA2Dda9In5A7ONoyYBa+0G0GLiLTSTALO2Eim6MFwvDIk8VSJ 5S6tnLaieEjQUtsKQVywfdEMr1sGMS8KqXb+ZG/t+FiA/oZ2nkW5sZI0uNno6y6e++5Z pgsSlkWJAgxto/80PBPe+gvdbhZDQZOR5ShS83GV5byeKTZsnEFvM6D/Rltm5IeY4txF 80eO762J0cmAYz+uV/4g7xSY7/BAWpZfX8lmtLuMG39IX5162asTxWsmZ3W1dqiPnj7z eNRk390UAuy/njQdbhwrIpo+HGZdL9tdXp65eNOEYXjZkVqqbHmQGI+TWyjs/lM+0eia cgWA== X-Forwarded-Encrypted: i=1; AJvYcCV5ATx/EMe4x1ZtF41dxAeDGAKM2WUApC+U1wrAoGrn4GcSyTwyRoqJBuMrtTbPYcaIQi8qg8Kv71eMDeA=@vger.kernel.org X-Gm-Message-State: AOJu0YxfulrZPj3CafxOkTEg1t8qoJAatjwl683K8ZCiT7863AJs1orz DU70QQu/UuBPETGk/qFlPR9dnavdOQvNQFQh4Q1M0QHOt9UdZ2EVU2MuFyOZRb84iFw= X-Gm-Gg: ASbGncs0+M+NmB6h2G2sUSe0aenOcyb6KRCxlKsxGz2x1otY1hUEMdv3wfJsBCiRuOD OqJzS/0YINPyt7EKYSzatsIowcS1/0Fy/6ooBgcbPSf3X54kDfPVrwtnnXjqANE7Cj2sW3G5V5a IJNh11B+W5+VzuFPrWWOkJWa35Vu0xTPsRZiS+gd6hlg9/CDjgouzXB7R2abtKErM44lIcA7O1V dX8VOx1g4iv9wYpPEgxmab/Lw9Bi/mQgjxg9OE9wVvsj6C3TatcMoblUOpiUHZPv3m8PLT4fz3o FvH1lGG2FYlBD3H4zqVcgMKotAPe3xpKZzNeXFPoz4qaARuKhMQW4OghulmhztG2wvl7rnWux/z xeoOyNT2D1JbChahsMlo= X-Google-Smtp-Source: AGHT+IGfoUQU6tMr9zPYUJ6jdUAQDnehNSnxPg9FvM8hXpb+wki2yPOFQiObmL3C04ljtIMxkfbFrg== X-Received: by 2002:ad4:5dc4:0:b0:6d8:a1fe:7293 with SMTP id 6a1803df08f44-6fa9d2ec0dcmr4244776d6.42.1748021609392; Fri, 23 May 2025 10:33:29 -0700 (PDT) Received: from [192.168.40.12] (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b08afb37sm117198226d6.49.2025.05.23.10.33.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 10:33:28 -0700 (PDT) Message-ID: Date: Fri, 23 May 2025 13:33:26 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] pwm: axi-pwmgen: fix missing separate external clock To: David Lechner , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250522-pwm-axi-pwmgen-add-external-clock-v2-0-086ea9e6ecf0@baylibre.com> <20250522-pwm-axi-pwmgen-add-external-clock-v2-3-086ea9e6ecf0@baylibre.com> Content-Language: en-US From: Trevor Gamblin In-Reply-To: <20250522-pwm-axi-pwmgen-add-external-clock-v2-3-086ea9e6ecf0@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-05-22 10:49, David Lechner wrote: > Add proper support for external clock to the AXI PWM generator driver. > > In most cases, the HDL for this IP block is compiled with the default > ASYNC_CLK_EN=1. With this option, there is a separate external clock > that drives the PWM output separate from the peripheral clock. So the > driver should be enabling the "axi" clock to power the peripheral and > the "ext" clock to drive the PWM output. > > When ASYNC_CLK_EN=0, the "axi" clock is also used to drive the PWM > output and there is no "ext" clock. > > Previously, if there was a separate external clock, users had to specify > only the external clock and (incorrectly) omit the AXI clock in order > to get the correct operating frequency for the PWM output. > > The devicetree bindings are updated to fix this shortcoming and this > patch changes the driver to match the new bindings. To preserve > compatibility with any existing dtbs that specify only one clock, we > don't require the clock name on the first clock. > > Fixes: 41814fe5c782 ("pwm: Add driver for AXI PWM generator") > Signed-off-by: David Lechner Thanks for fixing this! Reviewed-by: Trevor Gamblin