From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C54D5E06C for ; Fri, 8 Mar 2024 22:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709935247; cv=none; b=oZG3LldeaHrQWXjvlHfRp8TVpLNKxGihZFW8WC1J6VNWKESmu6bjEvlAiQXuCeaVtRKGwb6NOzj638IX+87LdpYGPZEe2trXN7xTg7a7UawQpCp1JSjsqU0XIeDuUIuUgP59fLtZiId6lTMXPuSl0Z/Aui0fskfkaeSavkBnAeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709935247; c=relaxed/simple; bh=sLyCnNsNT2eyI3Bon3bnXfxLB5jOz7soycx0lB68P8Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hRxLfAhK2L/WK0KTnxBe3xfLzSJy0qncMjLgRdzN2/Jw3gc5tos1fIFD2NtalGsDfmtlPvcxQNITEVWX98czdiRq7RyVW4nYTGWs1k4RCZMDXWPi3eK5VK2oMqVWbKXm3E+qPs8nKgeTiZodMXgVHE+gygcGcd2OnQuGLHtIe7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bMTDWgCS; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bMTDWgCS" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5133d26632fso1733415e87.2 for ; Fri, 08 Mar 2024 14:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709935242; x=1710540042; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JZm++aDLJ0XwMXEzw9POFukHlDkOsStLmO8u8UA76+I=; b=bMTDWgCS/tUahzOARuIlMmma+bVp0bpylX13xaER6YdhDRe1sHVALmqiEhVhMhUy/D AP5Pbv7DOd6jH8UudMXiRoDeS1OOeWrr7cDUHF5aCzVvPScW5uTvyJYnKYnK9u1RhpmX Ub9bSXmAPrV9sD9G6b5XJt7hPBuTMyThjBVfEWdLgS6LBM/QvzzndNtub11XcD/zK0Ux aYn3UnreXw+OsX+jlSjV9pABMi+r23BtoB4Mgukfq8mgETAVrKvWfNqCdcGYUAVcZ/sU +hyd98g5Eg1lt4OemClN4P+k4efTM4RXMllwKU9mA6x7lvSjXoh0MnRyKoMO/CHHsvi8 9Lrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709935242; x=1710540042; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JZm++aDLJ0XwMXEzw9POFukHlDkOsStLmO8u8UA76+I=; b=N/Xc+aimUD3X9Ij07ICA4u2fZ8C5Iunv7FIp1mUAptMZ2MuUVMXHGH8juenrgdPScF nG9gzuKYArHnT6Oz38CkdSjOcO6S4Zgww3n7lhh0qx+p8WmVOnSAXF97pccsU5k1kSX7 UdilSG3i2H1kG4gglXnIFoxLIC/vPqqUTRb7E1JA1q22iQO5jxmZo2ZUUfGSCA5ZcK75 EYO0x141EWpUWvvSXRtm4amfDrit4zILoTQz38dY5DUAE9ya4jWYgpFr+tPaLaNYv6gE 0apxpWql7E55d12s1Kuo6/Wg1bWlagl8FDl8w2Irhti68Fu0/fG99DjohGeNsahM8mNT bvVg== X-Forwarded-Encrypted: i=1; AJvYcCWTzSfk+JowP20zJ8ycnWI0ik7qCKp9/DEmMKQQ/PaDver9kfKqj3jMyjnHryCEtgZXrM5wjedzep+UmmNNWSlNDAmHZ7xPN2P11Ehu X-Gm-Message-State: AOJu0Yz9Ndt+RB46P5K+67JQl1Lb8OrAyS7ykuX26j4cS/sAF2WLjevi 56QOmu5TGouDUdTh4FXYMNKs0XIdhkcLIM/2a2z+wQ8qDYES1iT7mk3KhWb0IMY= X-Google-Smtp-Source: AGHT+IH0IqAGaG90+vGY+Hz6Pw86eDpkRmsO6T1VXhM+s79uwJaLfO0ImbRNyJ29ya1n664plyKitg== X-Received: by 2002:a2e:b0f3:0:b0:2d3:7aaa:b340 with SMTP id h19-20020a2eb0f3000000b002d37aaab340mr284963ljl.26.1709935242277; Fri, 08 Mar 2024 14:00:42 -0800 (PST) Received: from [192.168.16.246] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id b26-20020a05651c033a00b002d0b231dce7sm70474ljp.77.2024.03.08.14.00.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 14:00:33 -0800 (PST) Message-ID: Date: Fri, 8 Mar 2024 23:00:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() To: Gabor Juhos , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8.03.2024 10:25, Gabor Juhos wrote: > Since the qcom_scm_probe() function returns with an error if > __scm->path contains an error pointer, it is not needed to > verify that again in the qcom_scm_bw_{en,dis}able() functions > so remove the superfluous IS_ERR() checks. > > Signed-off-by: Gabor Juhos > --- > Based on v6.8-rc7. > --- LGTM Reviewed-by: Konrad Dybcio Konrad