From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <virtualization@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] virtio: add missing MODULE_DESCRIPTION() macro
Date: Thu, 11 Jul 2024 11:43:18 -0700 [thread overview]
Message-ID: <b8b23dc1-7df6-489d-9638-db64a89c8a83@quicinc.com> (raw)
In-Reply-To: <ef8f00f2-210c-454e-a7f8-ab724a18bf96@quicinc.com>
On 6/23/24 10:36, Jeff Johnson wrote:
> On 6/2/2024 1:25 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/virtio/virtio_dma_buf.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/virtio_dma_buf.c
>> index 2521a75009c3..3034a2f605c8 100644
>> --- a/drivers/virtio/virtio_dma_buf.c
>> +++ b/drivers/virtio/virtio_dma_buf.c
>> @@ -85,5 +85,6 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
>> }
>> EXPORT_SYMBOL(virtio_dma_buf_get_uuid);
>>
>> +MODULE_DESCRIPTION("dma-bufs for virtio exported objects");
>> MODULE_LICENSE("GPL");
>> MODULE_IMPORT_NS(DMA_BUF);
>>
>> ---
>> base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
>> change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5
>>
>
> Following up to see if anything else is needed from me.
> Hoping to see this in linux-next :)
I still don't see this in linux-next so following up to see if anything
else is needed to get this merged. Adding Greg KH since he's signed off
on this file before and he's taken quite a few of my cleanups through
his trees.
I'm hoping to have all of these warnings fixed tree-wide in 6.11.
/jeff
next prev parent reply other threads:[~2024-07-11 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 20:25 Jeff Johnson
2024-06-23 17:36 ` Jeff Johnson
2024-07-11 18:43 ` Jeff Johnson [this message]
2024-07-11 19:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b23dc1-7df6-489d-9638-db64a89c8a83@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®