From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D9C6BB32; Tue, 30 Jan 2024 13:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706622831; cv=none; b=ApjgnNSD3PkQrQq5y4rR0erBWeWjo/xhAzIJiT4tbTZ4+xovmZY/0/5P65vXa4JtKeJnvwQQlDtV/GyNN2Z8bHnOCJYGc7bCnvnkFzZXOZEwPbvJb8DGUSrUk3ZgdR7vrVaxjTsz/CQCTIXZCEQO14OFQ9D4WKsRjmnerxe/Jcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706622831; c=relaxed/simple; bh=Rbw0bjfu1YktFDI3J38DN6TV3tsl1n6Ebrxsm9br8vc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DIIiysiDSG2SKcR1eb1bJqZ28HtBzfiriuAnW7cjwkH7us+FCNCBVER8NfBanZjsDE815aKigtTIl+gSrJC6HDTZ+eP0luOd83RRCt+nYDCRg0VFZ8Q4vYOGuciqa9csmw4UFLL+UYV1/9+rCl1MwF7t0f/gFrMJ1ivY6ud+98w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OFU7CFNo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OFU7CFNo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DFFFC433C7; Tue, 30 Jan 2024 13:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706622830; bh=Rbw0bjfu1YktFDI3J38DN6TV3tsl1n6Ebrxsm9br8vc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OFU7CFNorhBVGsTPusWn+2sB59iM24W5vkZAelhW2wpuZbetl9L3u54yCOub2dJNr 4tR1g6rPlZAcL3IbMmvOpicB5iUYFwNPTt3zuEXOuckwfjU4q92d9YbEJU4W/+vJg0 yT4sbK1J2OlRyJyPWINGU8yABBlFPqvJHesziCxX2i9Dg/pdNyYVISyPtXOocB6K8P HhTsWJKCHgBOBKZWmKHpUr9kdTuYLufJ3J0qIQW8kucynqyYgc1WrPtZCaLsT0O5J/ 4CEC8NxeW5fU0wNp3GsuuaZD0/Dw/oLlo0Ci4Zd0/7wqV8Rj5gGG+pYi5PVYUjug57 3OJbAaIpsws4Q== Message-ID: Date: Tue, 30 Jan 2024 22:53:45 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv5 1/1] block: introduce content activity based ioprio Content-Language: en-US To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Matthew Wilcox , Yu Zhao , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com References: <20240130084207.3760518-1-zhaoyang.huang@unisoc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/30/24 22:28, Zhaoyang Huang wrote: >> That information does not belong to the ioprio. And which scheduler acts on a >> number of pages anyway ? The scheduler sees requests and BIOs. It can determine >> the number of pages they have if that is an information it needs to make >> scheduling decisison. Using ioprio to pass that information down is a dirty hack. > No. IO scheduler acts on IOPRIO_CLASS which is transferred from the > page's activity by the current method. I will implement another > version of iterating pages before submit_bio and feed back to the list Then why are you modifying the ioprio user API to add the 7 bits of activity ? If the scheduler only needs the priority class, then only set that and do not touch the user facing API. -- Damien Le Moal Western Digital Research