From: Jie Luo <quic_luoj@quicinc.com>
To: Rosen Penev <rosenp@gmail.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: mdio-ipq4019: fix wrong NULL check
Date: Tue, 19 Nov 2024 18:54:10 +0800 [thread overview]
Message-ID: <b8beb23a-6e39-4534-b7a2-5b0627373fb6@quicinc.com> (raw)
In-Reply-To: <CAKxU2N_zcNB-0gBKPnPo3kjZ7mZpzbiB63JFGVZ5jd1U-LjxSA@mail.gmail.com>
On 11/19/2024 5:12 AM, Rosen Penev wrote:
> On Mon, Nov 18, 2024 at 3:27 AM Russell King (Oracle)
> <linux@armlinux.org.uk> wrote:
>>
>> On Mon, Nov 18, 2024 at 06:26:27PM +0800, Jie Luo wrote:
>>> On 11/18/2024 5:28 AM, Rosen Penev wrote:
>>>> devm_ioremap_resource returns a PTR_ERR when it fails, not NULL. OTOH
>>>> this is conditionally set to either a PTR_ERR or a valid pointer. Use
>>>> !IS_ERR_OR_NULL to check if we can use this.
>>>>
>>>> Fixes: 23a890d493 ("net: mdio: Add the reset function for IPQ MDIO driver")
>>>>
>>>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>>>> ---
>>>> drivers/net/mdio/mdio-ipq4019.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c
>>>> index dd3ed2d6430b..859302b0d38c 100644
>>>> --- a/drivers/net/mdio/mdio-ipq4019.c
>>>> +++ b/drivers/net/mdio/mdio-ipq4019.c
>>>> @@ -256,7 +256,7 @@ static int ipq_mdio_reset(struct mii_bus *bus)
>>>> /* To indicate CMN_PLL that ethernet_ldo has been ready if platform resource 1
>>>> * is specified in the device tree.
>>>> */
>>>> - if (priv->eth_ldo_rdy) {
>>>> + if (!IS_ERR_OR_NULL(priv->eth_ldo_rdy)) {
>>>> val = readl(priv->eth_ldo_rdy);
>>>> val |= BIT(0);
>>>> writel(val, priv->eth_ldo_rdy);
>>>
>>> Reviewed-by: Luo Jie <quic_luoj@quicinc.com>
>>
>> Looking at the setup of this:
>>
>> /* The platform resource is provided on the chipset IPQ5018 */
>> /* This resource is optional */
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> if (res)
>> priv->eth_ldo_rdy = devm_ioremap_resource(&pdev->dev, res);
>>
>> While this is optional, surely the optional part is whether resource 1
>> is provided or not. If the resource is provided, but we fail to ioremap
>> it, isn't that an error which should be propagated? In that situation,
>> isn't the firmware saying "we have a second resource" but failing to
>> map it should be an error?
Agree. The fail to ioremap resource 1 needs to be captured and
propagated if the resource 1 is provided by DTS.
>
> Another way to look at it is, if we convert this to
>
> devm_platform_get_and_ioremap_resource(pdev, 1, &res);
>
> it seems to only write to res if platform_get_resource succeeds and
> otherwise doesn't care. The only real way to check if found is
> !IS_ERR().
>
> Actually the more appropriate function here is
> devm_platform_ioremap_resource , which doesn't write to a struct
> resource.
>
The resource 1 is optional, so devm_platform_ioremap_resource can't
be used here, otherwise the error will be returned if the resource 1
is not provided.
>>
>> --
>> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
>> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-11-19 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 21:28 Rosen Penev
2024-11-18 10:26 ` Jie Luo
2024-11-18 11:27 ` Russell King (Oracle)
2024-11-18 21:12 ` Rosen Penev
2024-11-19 10:54 ` Jie Luo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8beb23a-6e39-4534-b7a2-5b0627373fb6@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®