mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Goddard Rosa" <andre.goddard@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	laijs@cn.fujitsu.com, davem@davemloft.net,
	akpm@linux-foundation.org, harvey.harrison@gmail.com,
	linux list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] vsprintf: factor out skip_space code in a separate  function
Date: Wed, 4 Nov 2009 12:25:05 -0200	[thread overview]
Message-ID: <b8bf37780911040625r3fe0d18dx4f74c7be54f5dc3@mail.gmail.com> (raw)
In-Reply-To: <20091102192706.GA30939@elte.hu>

Hi, Ingo!

On Mon, Nov 2, 2009 at 5:27 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * André Goddard Rosa <andre.goddard@gmail.com> wrote:
>
>> >From 584d9bfc7c1d41b76a05655b4562b98fcbef6ee4 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>
>> Date: Sun, 1 Nov 2009 14:09:06 -0200
>> Subject: [PATCH v2 7/7] vsprintf: factor out skip_space code in a
>> separate function
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>
> btw., for reviewability's sake, could you please fix your patch
> submission method to not include such garbled headers in the mail body?
>
> (Also, it would be nice to reply-thread the 7 patches on the 0/7 mail,
> as git-send-email does.)
>

I had some discussion about these headers on git mailing list (
http://marc.info/?t=125726599400002&r=1&w=2 ).

So, I'd like to know if it's preferred to remove all these headers
altogether or leave them by just removing the
commit # line and fixing the "From: " line.

What do you think?

p.s.: I'll probably use git-send-email in a second moment -- have to
fix my environment first
https://bugzilla.novell.com/show_bug.cgi?id=525780

Thanks,
André

  reply	other threads:[~2009-11-04 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 17:26 André Goddard Rosa
2009-11-02 19:27 ` Ingo Molnar
2009-11-04 14:25   ` André Goddard Rosa [this message]
2009-11-04 14:49     ` [PATCH v3 " André Goddard Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8bf37780911040625r3fe0d18dx4f74c7be54f5dc3@mail.gmail.com \
    --to=andre.goddard@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=harvey.harrison@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®