From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbdJ0Ode (ORCPT ); Fri, 27 Oct 2017 10:33:34 -0400 Received: from hermes.aosc.io ([199.195.250.187]:49887 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752239AbdJ0Odb (ORCPT ); Fri, 27 Oct 2017 10:33:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 27 Oct 2017 22:33:29 +0800 From: icenowy@aosc.io To: Maxime Ripard Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: add binding for A64 DE2 CCU with SRAM section In-Reply-To: <20171016120912.lxu7rikhffxsu5o4@flea.lan> References: <20171014122925.13220-1-icenowy@aosc.io> <20171016091136.b4rnckh2tfi26shx@flea.lan> <20171016120912.lxu7rikhffxsu5o4@flea.lan> Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2017-10-16 20:09，Maxime Ripard 写道： > On Mon, Oct 16, 2017 at 05:41:10PM +0800, icenowy@aosc.io wrote: >> 在 2017-10-16 17:11，Maxime Ripard 写道： >> > On Sat, Oct 14, 2017 at 08:29:24PM +0800, Icenowy Zheng wrote: >> > > A64's Display Engine 2.0 needs a section of SRAM (SRAM C) to be >> > > claimed. >> > >> > Why? >> >> Allwinner didn't document this, but if the SRAM is not claimed, the >> DE2 MMIO zone is totally not accessible. > > Not accessible how? It generates an abort when you access it? It > returns 0? > >> It seems that Allwinner uses the SRAM C in the DE2 internally. > > Then shouldn't it be tied to all the DE2 devices then? So mixers > too. Either way, this should be mentionned in your commit logs. How > you're fixing things is much less interesting than why you're doing > them. You can tell how you're doing them from your code already. Yes I checked and when the SRAM is not claimed any part in DE2 memory zone can't be accessed. Should I also add the code that claims the SRAM in the mixer code? Or just place the device tree property is enough? (As the mixers depend on the DE2 CCU) Or just ignore this? > > Maxime > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel