mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: stop enforcing INTERCONNECT_CLK dependency for everybody
Date: Thu, 21 May 2026 11:55:12 +0200	[thread overview]
Message-ID: <b8ca632c-310c-4647-b91d-0514feb50fa6@oss.qualcomm.com> (raw)
In-Reply-To: <20260517-qcom-clk-icc-v1-1-1dc6ea8bdcd0@oss.qualcomm.com>

On 5/17/26 8:51 PM, Dmitry Baryshkov wrote:
> Only several (typically IPQ) platforms use INTERCONNECT_CLK to turn
> clocks into the interconnect providers. Stop inferring this dependency
> on everybody and set it only when required. As a safety measure, make
> sure that the coresponding clock description fields are not available if
> corresponding Kconfig option isn't enabled.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

[...]

> @@ -395,6 +399,7 @@ config IPQ_GCC_5210
>  config IPQ_GCC_5332
>  	tristate "IPQ5332 Global Clock Controller"
>  	depends on ARM64 || COMPILE_TEST
> +	select QCOM_NEED_INTERCONNECT_CLK
>  	help
>  	  Support for the global clock controller on ipq5332 devices.
>  	  Say Y if you want to use peripheral devices such as UART, SPI,

There's a number of entries where there's spaces instead of tabs,
Krzysztof fixed that up for interconnect earlier today

[...]

> +#if IS_REACHABLE(CONFIG_INTERCONNECT_CLK)
>  	const struct qcom_icc_hws_data *icc_hws;
>  	size_t num_icc_hws;
> +#endif
>  	unsigned int icc_first_node_id;

this uint is also only present in drivers that use icc-clk

Konrad

      parent reply	other threads:[~2026-05-21  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 18:51 Dmitry Baryshkov
2026-05-18  9:22 ` Konrad Dybcio
2026-05-18 12:04   ` Dmitry Baryshkov
2026-05-21  9:53     ` Konrad Dybcio
2026-05-21  9:55 ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8ca632c-310c-4647-b91d-0514feb50fa6@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®