From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB48C433EF for ; Wed, 9 Feb 2022 19:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbiBITMt (ORCPT ); Wed, 9 Feb 2022 14:12:49 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:59566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231815AbiBITMm (ORCPT ); Wed, 9 Feb 2022 14:12:42 -0500 Received: from smtp.smtpout.orange.fr (smtp10.smtpout.orange.fr [80.12.242.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26BD4C0147E1 for ; Wed, 9 Feb 2022 11:12:31 -0800 (PST) Received: from [192.168.1.18] ([90.126.236.122]) by smtp.orange.fr with ESMTPA id HsMonZMVcbnFGHsMoncX1g; Wed, 09 Feb 2022 20:11:03 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Wed, 09 Feb 2022 20:11:03 +0100 X-ME-IP: 90.126.236.122 Message-ID: Date: Wed, 9 Feb 2022 20:11:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of do_div() Content-Language: en-US To: Qing Wang , Derek Chickles , Satanand Burla , Felix Manlunas , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1644395960-4232-1-git-send-email-wangqing@vivo.com> From: Christophe JAILLET In-Reply-To: <1644395960-4232-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/02/2022 à 09:39, Qing Wang a écrit : > From: Wang Qing > > do_div() does a 64-by-32 division. > When the divisor is u64, do_div() truncates it to 32 bits, this means it > can test non-zero and be truncated to zero for division. > > fix do_div.cocci warning: > do_div() does a 64-by-32 division, please consider using div64_u64 instead. > > Signed-off-by: Wang Qing > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index ba28aa4..8e07192 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -1539,7 +1539,7 @@ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) > * compute the delta in terms of coprocessor clocks. > */ > delta = (u64)ppb << 32; > - do_div(delta, oct->coproc_clock_rate); > + div64_u64(delta, oct->coproc_clock_rate); > > spin_lock_irqsave(&lio->ptp_lock, flags); > comp = lio_pci_readq(oct, CN6XXX_MIO_PTP_CLOCK_COMP); > @@ -1672,7 +1672,7 @@ static void liquidio_ptp_init(struct octeon_device *oct) > u64 clock_comp, cfg; > > clock_comp = (u64)NSEC_PER_SEC << 32; > - do_div(clock_comp, oct->coproc_clock_rate); > + div64_u64(clock_comp, oct->coproc_clock_rate); > lio_pci_writeq(oct, clock_comp, CN6XXX_MIO_PTP_CLOCK_COMP); > > /* Enable */ I think that all your recent patches about such conversions are broken. See [1] were it was already reported that do_div() and div64_u64() don't have the same calling convention. Looks that div64_u64() and div64_ul() works the same way. CJ [1]: https://lore.kernel.org/linux-kernel/20211117112559.jix3hmx7uwqmuryg@pengutronix.de/