From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BD4C433ED for ; Fri, 21 May 2021 05:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EC4061004 for ; Fri, 21 May 2021 05:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239354AbhEUFDc (ORCPT ); Fri, 21 May 2021 01:03:32 -0400 Received: from foss.arm.com ([217.140.110.172]:38036 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238873AbhEUFDb (ORCPT ); Fri, 21 May 2021 01:03:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58546101E; Thu, 20 May 2021 22:02:03 -0700 (PDT) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D73833F719; Thu, 20 May 2021 22:01:57 -0700 (PDT) Subject: Re: [PATCH] arm64: mm: hugetlb: add support for free vmemmap pages of HugeTLB To: David Hildenbrand , Muchun Song , will@kernel.org, akpm@linux-foundation.org, bodeddub@amazon.com, osalvador@suse.de, mike.kravetz@oracle.com, rientjes@google.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, zhengqi.arch@bytedance.com, Mark Rutland , Catalin Marinas , James Morse References: <20210518091826.36937-1-songmuchun@bytedance.com> <1b9d008a-7544-cc85-5c2f-532b984eb5b5@arm.com> <88114091-fbb2-340d-b69b-a572fa340265@redhat.com> <45c1a368-3d31-e92d-f120-4dca0eb2111d@redhat.com> From: Anshuman Khandual Message-ID: Date: Fri, 21 May 2021 10:32:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <45c1a368-3d31-e92d-f120-4dca0eb2111d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/21 5:29 PM, David Hildenbrand wrote: > On 20.05.21 13:54, Anshuman Khandual wrote: >> >> On 5/19/21 5:33 PM, David Hildenbrand wrote: >>> On 19.05.21 13:45, Anshuman Khandual wrote: >>>> >>>> >>>> On 5/18/21 2:48 PM, Muchun Song wrote: >>>>> The preparation of supporting freeing vmemmap associated with each >>>>> HugeTLB page is ready, so we can support this feature for arm64. >>>>> >>>>> Signed-off-by: Muchun Song >>>>> --- >>>>>    arch/arm64/mm/mmu.c | 5 +++++ >>>>>    fs/Kconfig          | 2 +- >>>>>    2 files changed, 6 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >>>>> index 5d37e461c41f..967b01ce468d 100644 >>>>> --- a/arch/arm64/mm/mmu.c >>>>> +++ b/arch/arm64/mm/mmu.c >>>>> @@ -23,6 +23,7 @@ >>>>>    #include >>>>>    #include >>>>>    #include >>>>> +#include >>>>>      #include >>>>>    #include >>>>> @@ -1134,6 +1135,10 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, >>>>>        pmd_t *pmdp; >>>>>          WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END)); >>>>> + >>>>> +    if (is_hugetlb_free_vmemmap_enabled() && !altmap) >>>>> +        return vmemmap_populate_basepages(start, end, node, altmap); >>>> >>>> Not considering the fact that this will force the kernel to have only >>>> base page size mapping for vmemmap (unless altmap is also requested) >>>> which might reduce the performance, it also enables vmemmap mapping to >>>> be teared down or build up at runtime which could potentially collide >>>> with other kernel page table walkers like ptdump or memory hotremove >>>> operation ! How those possible collisions are protected right now ? >>> >>> Hi Anshuman, >>> >>> Memory hotremove is not an issue IIRC. At the time memory is removed, all huge pages either have been migrated away or dissolved; the vmemmap is stable. >> >> But what happens when a hot remove section's vmemmap area (which is being >> teared down) is nearby another vmemmap area which is either created or >> being destroyed for HugeTLB alloc/free purpose. As you mentioned HugeTLB >> pages inside the hot remove section might be safe. But what about other >> HugeTLB areas whose vmemmap area shares page table entries with vmemmap >> entries for a section being hot removed ? Massive HugeTLB alloc/use/free >> test cycle using memory just adjacent to a memory hotplug area, which is >> always added and removed periodically, should be able to expose this problem. >> >> IIUC unlike vmalloc(), vmemap mapping areas in the kernel page table were >> always constant unless there are hotplug add or remove operations which >> are protected with a hotplug lock. Now with this change, we could have >> simultaneous walking and add or remove of the vmemap areas without any >> synchronization. Is not this problematic ? >> >> On arm64 memory hot remove operation empties free portions of the vmemmap >> table after clearing them. Hence all concurrent walkers (hugetlb_vmemmap, >> hot remove, ptdump etc) need to be synchronized against hot remove. >> >>  From arch/arm64/mm/mmu.c >> >> void vmemmap_free(unsigned long start, unsigned long end, >>                  struct vmem_altmap *altmap) >> { >> #ifdef CONFIG_MEMORY_HOTPLUG >>          WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END)); >> >>          unmap_hotplug_range(start, end, true, altmap); >>          free_empty_tables(start, end, VMEMMAP_START, VMEMMAP_END); >> #endif >> } > > You are right, however, AFAIR > > 1) We always populate base pages, meaning we only modify PTEs and not actually add/remove page tables when creating/destroying a hugetlb page. Page table walkers should be fine and not suddenly run into a use-after-free. > > 2) For pfn_to_page() users to never fault, we have to do an atomic exchange of PTES, meaning, someone traversing a page table looking for pte_none() entries (like free_empty_tables() in your example) should never get a false positive. > > Makes sense, or am I missing something? > >> >>> >>> vmemmap access (accessing the memmap via a virtual address) itself is not an issue. Manually walking (vmemmap) page tables might behave >> >> Right. >> >> differently, not sure if ptdump would require any synchronization. >> >> Dumping an wrong value is probably okay but crashing because a page table >> entry is being freed after ptdump acquired the pointer is bad. On arm64, >> ptdump() is protected against hotremove via [get|put]_online_mems(). > > Okay, and as the feature in question only exchanges PTEs, we should be fine. Adding Mark, Catalin and James here in case I might have missed something regarding possible vmemmap collision.