From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D2B32B98D for ; Tue, 30 Dec 2025 17:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114217; cv=none; b=Il2Iu0ktqSpSmK70fvoqG1x0fu1BaiYip661eg7PyaaUe/YHYurkDWhvHCANAoGbQ2JD/50Zg/EzpC/BJeptLdoHahiyo4A+Dlcwq7UtnySDztaHbOi5jeUbCvDWTTZmgc/LjYCoyb8CdmkcbpDpAaDx3WVxrE1O/bW3PAIxFek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767114217; c=relaxed/simple; bh=XjNNsHYwCLx9KePjsNp0eAMdbw6RKbK6jR4eT0nmMNg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=C4elmI3Shbkl4K82zeQK6RX4JxxV8jyAtqWAKUfXbBcFFKIlahgso7YHppMBmdJdR2lEmhssMcVWgFKLJkAk2jDosbAAHwAjxyr6lA3HjuXK0b0MlXAu8Ci+QjidWkQTUqUvuRKXL866fQBVSrl+DIaaA0lnQBqaA7eQAzzY8zU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PpTCP178; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PpTCP178" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-34c718c5481so9749504a91.3 for ; Tue, 30 Dec 2025 09:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767114215; x=1767719015; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=XjNNsHYwCLx9KePjsNp0eAMdbw6RKbK6jR4eT0nmMNg=; b=PpTCP178Z0pW9/S4V4EKSq9r1VRVm4GMtrHEWfAmTktP5L7P8rp4Ncel/STw6qAouP TacTqz7CGEIxA+Ud5dn41NjRYvKchyRKmVL2vPqdZsPbBEyFVHyCQW0PiVZFMCBbW4dr 3XbXocVu9kXkPoilCmhYSXizfcIcvaUbiUVNJdzlQapnELwME9dW850qLeFmNeN9AAKP a7A69h1slrDfsdkDzcmCeQ5C4kYZ/j79pBFVk7CFO5J7nXqmjLJuS+1ZZyIzbc+s2mRY ObtKeM2KXskyhabR8LfLlESRcKptffKZMVeoAvtkKD7iJeZ5f8zfIkffm9AKexUbVvd0 0nrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767114215; x=1767719015; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XjNNsHYwCLx9KePjsNp0eAMdbw6RKbK6jR4eT0nmMNg=; b=IanM+83NuSUmPNfqgr1VG/cpK0g2ehZKVMZj6jnWlIFwk9frob9PsUvRzcOFb9RZZD 8zUFWmL8LOzjxGxLtCqlhQAj3DRQb0TuZooz4KH3ZcdfZ1wIc3JJpWS/RtmkOVP6Blb2 ns5QdiAPPtAD1PbtdIZKMlC4Nw4kC0BxHirq7PfTwlUvk+1UX8jw3781m+MEhBk5H6Zu r/+jSCQXARJEFjuYCRxf0bG+AEkPtYByTSagngTArfYd283cIx0liQULH2a7h6ED9DSt U8mXzWFJ+27CM8BgglyPKKTuqO2R1GMKZGWQuy/0FcG6kKUZdF+vi9akN2X2khNepcNp Q05w== X-Forwarded-Encrypted: i=1; AJvYcCXOLe89OuksKenJ5DxuI6PSOisH7MGTKTW9NaGDUInLHZfrl2aDiX9hMS4kifZ18V5Qme4cLTVj2kXGTTA=@vger.kernel.org X-Gm-Message-State: AOJu0YyEz9gt+RI4GMzHQ24h52uDELuIY6bV22Llf/TfKPxP0QHM4Axl aVedXbNf+f1XSPVNZimFZBuIgzv7bJji4jBqD7QSu3MzwyZ4qO7GOIlL X-Gm-Gg: AY/fxX5iQKCOS73zL3qjoXQSA0OTSROlES4JEJWAtJDBah7Pj7jW+raYn0HGrSjA+WB YesVHxRu1xIYOKO3nKSmGJEO1bmgLtydjx7sCX6BqmRBOnUYt7t2lvRd1BpX7ES/Npa7kCqRrtx XC1vQkxBm9JFz69pwiher7J+8Le051IN5UebJ4FkSHcQ6dcN6+b9WRkWETwyEOMFFncuLzpgw8x Ol5nMiSX1SiZPK+Hf2ZTkKmvv03NzQJGXlv+lhiuhP6KsCjrItDT+Wg2xepC+EbqGd85YdY8iWk piWL+9sesxRxK+OmL2+gJKasYzgNGTsHLB1u0HE4P/MxAm+FDkH8TgbuI1nZgZo4NyfhOPXotYN Q4tKdZpjBUYwmQUZZM9NFhYqaJ+ihtYKRtZXRnTNVG5m9Sc0wnpP5dsNKtMpgjPM0hbR75Ekx0u znKwPQzITBHmdbqp12RclayjsigyhkpHeG3c34 X-Google-Smtp-Source: AGHT+IEC5XzplaqjCTY+TaeStSaLBHHYphufqtA44YhKMzI9S6fC5jwWAC09ftK4QNS8ABKedw6ZzA== X-Received: by 2002:a17:90b:4a52:b0:343:6611:f21 with SMTP id 98e67ed59e1d1-34e92137b5dmr27064350a91.1.1767114214821; Tue, 30 Dec 2025 09:03:34 -0800 (PST) Received: from [192.168.10.156] ([116.169.236.126]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70dbd618sm33566965a91.12.2025.12.30.09.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 09:03:33 -0800 (PST) Message-ID: Date: Wed, 31 Dec 2025 01:03:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Qing Wang Subject: Re: [PATCH] sched: Fix NULL mm dereference in sched_mm_cid_after_execve() To: xiyou.wangcong@gmail.com Cc: cwang@multikernel.io, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, peterz@infradead.org, tglx@linutronix.de References: <20251223215113.639686-1-xiyou.wangcong@gmail.com> In-Reply-To: <20251223215113.639686-1-xiyou.wangcong@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >  void sched_mm_cid_after_execve(struct task_struct *t) >  { > -    sched_mm_cid_fork(t); > +    if (t->mm) > +        sched_mm_cid_fork(t); >  } Hi, It's a correct solution, but I have a small suggestion that putting the 'mm' checking into sched_mm_cid_fork(), just like sched_mm_cid_exit(). Best regards, Qing Wang