mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stuart Menefy <stuart.menefy@st.com>,
	Russell King <linux@arm.linux.org.uk>,
	Michal Simek <michal.simek@xilinx.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: Enable arm_global_timer for Zynq brakes boot
Date: Tue, 30 Jul 2013 15:14:43 -0700	[thread overview]
Message-ID: <b8d1f8ab-e9b2-4f16-9935-4af249bd5375@CH1EHSMHS041.ehs.local> (raw)
In-Reply-To: <51F77D93.4030505@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]

On Tue, Jul 30, 2013 at 10:47:15AM +0200, Daniel Lezcano wrote:
> On 07/30/2013 02:03 AM, Sören Brinkmann wrote:
> > Hi Daniel,
> > 
> > On Mon, Jul 29, 2013 at 02:51:49PM +0200, Daniel Lezcano wrote:
> > (snip)
> >>
> >> the CPUIDLE_FLAG_TIMER_STOP flag tells the cpuidle framework the local
> >> timer will be stopped when entering to the idle state. In this case, the
> >> cpuidle framework will call clockevents_notify(ENTER) and switches to a
> >> broadcast timer and will call clockevents_notify(EXIT) when exiting the
> >> idle state, switching the local timer back in use.
> > 
> > I've been thinking about this, trying to understand how this makes my
> > boot attempts on Zynq hang. IIUC, the wrongly provided TIMER_STOP flag
> > would make the timer core switch to a broadcast device even though it
> > wouldn't be necessary. But shouldn't it still work? It sounds like we do
> > something useless, but nothing wrong in a sense that it should result in
> > breakage. I guess I'm missing something obvious. This timer system will
> > always remain a mystery to me.
> > 
> > Actually this more or less leads to the question: What is this
> > 'broadcast timer'. I guess that is some clockevent device which is
> > common to all cores? (that would be the cadence_ttc for Zynq). Is the
> > hang pointing to some issue with that driver?
> 
> If you look at the /proc/timer_list, which timer is used for broadcasting ?

In case of a vanilla kernel and with my patches for enabling the global
timer (I removed the wrongly set flag from the C2 state + adding the DT
fragment to use the GT), this is what I see (full output from timer_list
attached):
	Tick Device: mode:     1
	Broadcast device
	Clock Event Device: xttcps_clockevent

And the local timer seems to be the arm twd timer (also in both cases).

I don't think I can gather this information for the actual broken case,
but AFAIK, there shouldn't be any other timer be capable of this for
Zynq.

	Sören


[-- Attachment #2: timer_list --]
[-- Type: text/plain, Size: 4104 bytes --]

Timer List Version: v0.7
HRTIMER_MAX_CLOCK_BASES: 3
now at 76779317814 nsecs

cpu: 0
 clock 0:
  .base:       c14a0c90
  .index:      0
  .resolution: 1 nsecs
  .get_time:   ktime_get
  .offset:     0 nsecs
active timers:
 #0: <c14a2b50>, menu_hrtimer_notify, S:01, hrtimer_start, swapper/0/0
 # expires at 76779328789-76779328789 nsecs [in 10975 to 10975 nsecs]
 #1: <c14a0dd8>, tick_sched_timer, S:01, hrtimer_start, swapper/0/0
 # expires at 76800000000-76800000000 nsecs [in 20682186 to 20682186 nsecs]
 #2: <ed956e40>, timerfd_tmrproc, S:01, hrtimer_start, systemd/1
 # expires at 93249172026-93249172026 nsecs [in 16469854212 to 16469854212 nsecs]
 #3: <ed956c00>, timerfd_tmrproc, S:01, hrtimer_start, systemd/1
 # expires at 900000055806-900000055806 nsecs [in 823220737992 to 823220737992 nsecs]
 clock 1:
  .base:       c14a0cc8
  .index:      1
  .resolution: 1 nsecs
  .get_time:   ktime_get_real
  .offset:     975789465870609368 nsecs
active timers:
 clock 2:
  .base:       c14a0d00
  .index:      2
  .resolution: 1 nsecs
  .get_time:   ktime_get_boottime
  .offset:     0 nsecs
active timers:
  .expires_next   : 76779492678 nsecs
  .hres_active    : 1
  .nr_events      : 2449
  .nr_retries     : 66
  .nr_hangs       : 0
  .max_hang_time  : 0 nsecs
  .nohz_mode      : 2
  .last_tick      : 76780000000 nsecs
  .tick_stopped   : 1
  .idle_jiffies   : 4294944973
  .idle_calls     : 3114
  .idle_sleeps    : 981
  .idle_entrytime : 76779354678 nsecs
  .idle_waketime  : 76779336246 nsecs
  .idle_exittime  : 76769862116 nsecs
  .idle_sleeptime : 70735903990 nsecs
  .iowait_sleeptime: 18432 nsecs
  .last_jiffies   : 4294944973
  .next_jiffies   : 4294944976
  .idle_expires   : 76800000000 nsecs
jiffies: 4294944973

cpu: 1
 clock 0:
  .base:       c14a9c90
  .index:      0
  .resolution: 1 nsecs
  .get_time:   ktime_get
  .offset:     0 nsecs
active timers:
 #0: <c14a9dd8>, tick_sched_timer, S:01, hrtimer_start_range_ns, swapper/1/0
 # expires at 76780000000-76780000000 nsecs [in 682186 to 682186 nsecs]
 clock 1:
  .base:       c14a9cc8
  .index:      1
  .resolution: 1 nsecs
  .get_time:   ktime_get_real
  .offset:     975789465870609368 nsecs
active timers:
 clock 2:
  .base:       c14a9d00
  .index:      2
  .resolution: 1 nsecs
  .get_time:   ktime_get_boottime
  .offset:     0 nsecs
active timers:
  .expires_next   : 76780000000 nsecs
  .hres_active    : 1
  .nr_events      : 2257
  .nr_retries     : 61
  .nr_hangs       : 0
  .max_hang_time  : 0 nsecs
  .nohz_mode      : 2
  .last_tick      : 76700000000 nsecs
  .tick_stopped   : 0
  .idle_jiffies   : 4294944965
  .idle_calls     : 2998
  .idle_sleeps    : 444
  .idle_entrytime : 76771944950 nsecs
  .idle_waketime  : 76768498136 nsecs
  .idle_exittime  : 76768498136 nsecs
  .idle_sleeptime : 72124544054 nsecs
  .iowait_sleeptime: 4276262 nsecs
  .last_jiffies   : 4294944973
  .next_jiffies   : 4294944974
  .idle_expires   : 78880000000 nsecs
jiffies: 4294944973


Tick Device: mode:     1
Broadcast device
Clock Event Device: xttcps_clockevent
 max_delta_ns:   1207932479
 min_delta_ns:   18432
 mult:           233015
 shift:          32
 mode:           1
 next_event:     9223372036854775807 nsecs
 set_next_event: xttcps_set_next_event
 set_mode:       xttcps_set_mode
 event_handler:  tick_handle_oneshot_broadcast
 retries:        0
tick_broadcast_mask: 00000000
tick_broadcast_oneshot_mask: 00000000


Tick Device: mode:     1
Per CPU device: 0
Clock Event Device: local_timer
 max_delta_ns:   12884902005
 min_delta_ns:   1000
 mult:           715827876
 shift:          31
 mode:           3
 next_event:     76800000000 nsecs
 set_next_event: twd_set_next_event
 set_mode:       twd_set_mode
 event_handler:  hrtimer_interrupt
 retries:        0

Tick Device: mode:     1
Per CPU device: 1
Clock Event Device: local_timer
 max_delta_ns:   12884902005
 min_delta_ns:   1000
 mult:           715827876
 shift:          31
 mode:           3
 next_event:     76780000000 nsecs
 set_next_event: twd_set_next_event
 set_mode:       twd_set_mode
 event_handler:  hrtimer_interrupt
 retries:        0


  reply	other threads:[~2013-07-30 22:14 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130717210417.GP13667@xsjandreislx>
     [not found] ` <51E72DCA.9070500@codeaurora.org>
     [not found]   ` <f5b76049-7e5b-4dd0-9863-19cfd1d599b9@TX2EHSMHS006.ehs.local>
     [not found]     ` <51E7435B.3060605@codeaurora.org>
     [not found]       ` <ff4d40be-7177-4a55-ab2f-dff11fa18642@DB9EHSMHS009.ehs.local>
     [not found]         ` <51ED8DF2.60600@codeaurora.org>
     [not found]           ` <20130722201348.GI453@xsjandreislx>
2013-07-22 22:41             ` Sören Brinkmann
2013-07-29 12:51               ` Daniel Lezcano
2013-07-29 15:58                 ` Sören Brinkmann
2013-07-30  0:03                 ` Sören Brinkmann
2013-07-30  8:47                   ` Daniel Lezcano
2013-07-30 22:14                     ` Sören Brinkmann [this message]
2013-07-30 22:23                       ` Sören Brinkmann
2013-07-30 22:34                     ` Sören Brinkmann
2013-07-31  7:27                       ` Daniel Lezcano
2013-07-31 16:26                         ` Sören Brinkmann
2013-07-31  9:34                       ` Daniel Lezcano
2013-07-31 16:43                         ` Sören Brinkmann
2013-07-31 20:49                       ` Daniel Lezcano
2013-07-31 20:58                         ` Sören Brinkmann
2013-07-31 21:08                           ` Daniel Lezcano
2013-07-31 22:18                             ` Sören Brinkmann
2013-07-31 23:01                               ` Daniel Lezcano
2013-07-31 23:38                                 ` Sören Brinkmann
2013-08-01 17:29                                   ` Daniel Lezcano
2013-08-01 17:43                                     ` Sören Brinkmann
2013-08-01 17:48                                       ` Daniel Lezcano
2013-08-06  1:28                                         ` Sören Brinkmann
2013-08-06  8:46                                           ` Daniel Lezcano
2013-08-06  9:18                                             ` Michal Simek
2013-08-06 12:30                                               ` Daniel Lezcano
2013-08-06 12:41                                                 ` Michal Simek
2013-08-06 13:08                                                   ` Daniel Lezcano
2013-08-06 13:18                                                     ` Michal Simek
2013-08-06 16:09                                                       ` Daniel Lezcano
2013-08-06 16:13                                                         ` Sören Brinkmann
2013-08-06 16:25                                                         ` Sören Brinkmann
2013-08-06 16:18                                             ` Sören Brinkmann
2013-08-08 17:11                                         ` Sören Brinkmann
2013-08-08 17:16                                           ` Mark Rutland
2013-08-08 17:22                                             ` Stephen Boyd
2013-08-09 10:58                                               ` Mark Rutland
2013-08-08 17:22                                             ` Sören Brinkmann
2013-08-09 10:32                                           ` Srinivas KANDAGATLA
2013-08-09 14:19                                             ` Daniel Lezcano
2013-08-09 17:27                                               ` Stephen Boyd
2013-08-09 17:48                                                 ` Sören Brinkmann
2013-08-09 18:45                                                   ` Stephen Boyd
2013-08-12 10:53                                                 ` Daniel Lezcano
2013-08-12 16:23                                                   ` Stephen Boyd
2013-08-12 16:53                                                     ` Daniel Lezcano
2013-08-12 16:03                                                 ` Sören Brinkmann
2013-08-12 16:08                                                   ` Daniel Lezcano
2013-08-12 16:17                                                     ` Sören Brinkmann
2013-08-12 16:20                                                   ` Stephen Boyd
2013-08-12 16:24                                                     ` Sören Brinkmann
2013-08-12 16:40                                                       ` Stephen Boyd
2013-08-12 16:43                                                         ` Sören Brinkmann
2013-08-12 16:32                                                     ` Sören Brinkmann
2013-08-12 16:49                                                       ` Daniel Lezcano
2013-08-12 16:53                                                         ` Sören Brinkmann
2013-08-12 17:02                                                           ` Daniel Lezcano
2013-08-16 17:28                                                             ` Sören Brinkmann
2013-08-19 23:00                                                               ` Stephen Boyd
2013-08-19 23:30                                                                 ` Sören Brinkmann
2013-08-20  0:57                                                                   ` Stephen Boyd
2013-08-20 15:13                                                                     ` Daniel Lezcano
2013-08-22 17:06                                                                       ` [PATCH 1/2] tick: broadcast: Deny per-cpu clockevents from being broadcast sources Stephen Boyd
2013-08-22 17:06                                                                         ` [PATCH 2/2] clockevents: Prefer clockevents that don't suffer from FEAT_C3_STOP Stephen Boyd
2013-08-22 17:33                                                                           ` Santosh Shilimkar
2013-08-22 17:40                                                                             ` Stephen Boyd
2013-08-22 17:48                                                                               ` Santosh Shilimkar
2013-08-22 18:31                                                                                 ` Stephen Boyd
2013-08-22 21:06                                                                                   ` Santosh Shilimkar
2013-08-22 23:38                                                                         ` [PATCH 1/2] tick: broadcast: Deny per-cpu clockevents from being broadcast sources Sören Brinkmann
2013-09-05 16:53                                                                         ` Sören Brinkmann
2013-08-09 16:03                                             ` Enable arm_global_timer for Zynq brakes boot Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8d1f8ab-e9b2-4f16-9935-4af249bd5375@CH1EHSMHS041.ehs.local \
    --to=soren.brinkmann@xilinx.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=michal.simek@xilinx.com \
    --cc=sboyd@codeaurora.org \
    --cc=stuart.menefy@st.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®