From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C061ECAAD3 for ; Thu, 15 Sep 2022 02:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbiIOC2k (ORCPT ); Wed, 14 Sep 2022 22:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbiIOC2g (ORCPT ); Wed, 14 Sep 2022 22:28:36 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D4D40554; Wed, 14 Sep 2022 19:28:34 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VPqk5.y_1663208911; Received: from 30.221.129.91(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VPqk5.y_1663208911) by smtp.aliyun-inc.com; Thu, 15 Sep 2022 10:28:32 +0800 Message-ID: Date: Thu, 15 Sep 2022 10:28:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH V3 1/6] erofs: use kill_anon_super() to kill super in fscache mode Content-Language: en-US To: Jia Zhu , linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com, huyue2@coolpad.com References: <20220914105041.42970-1-zhujia.zj@bytedance.com> <20220914105041.42970-2-zhujia.zj@bytedance.com> From: JeffleXu In-Reply-To: <20220914105041.42970-2-zhujia.zj@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/22 6:50 PM, Jia Zhu wrote: > Use kill_anon_super() instead of generic_shutdown_super() since the > mount() in erofs fscache mode uses get_tree_nodev() and associated > anon bdev needs to be freed. > > Signed-off-by: Jingbo Xu Thanks. You're welcome to use "Suggested-by" in this case. The same with patch 2. > Signed-off-by: Jia Zhu > --- > fs/erofs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 3173debeaa5a..9716d355a63e 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -879,7 +879,7 @@ static void erofs_kill_sb(struct super_block *sb) > WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC); > > if (erofs_is_fscache_mode(sb)) > - generic_shutdown_super(sb); > + kill_anon_super(sb); > else > kill_block_super(sb); > Reviewed-by: Jingbo Xu -- Thanks, Jingbo