From: Robin Murphy <robin.murphy@arm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Petr Mladek <pmladek@suse.com>, Marco Elver <elver@google.com>,
Linux Embedded <linux-embedded@vger.kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Will Deacon <will@kernel.org>, Gary R Hook <gary.hook@amd.com>
Subject: Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages
Date: Thu, 1 Apr 2021 12:28:11 +0100 [thread overview]
Message-ID: <b8dba57b-860b-0bd4-2ca0-e8f2e26571bd@arm.com> (raw)
In-Reply-To: <CAMuHMdUvgRiYfsVOJdocB3peLhnDWe=Kn1MLW64sh8zpd2XoLA@mail.gmail.com>
On 2021-04-01 10:39, Geert Uytterhoeven wrote:
> Hi Steven,
>
> On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>> On Wed, 31 Mar 2021 11:31:03 +0200
>> Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>>
>>> This reduces kernel size by ca. 0.5 KiB.
>>
>> If you are worried about size, disable tracing and it will go away
>> entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in
>> size overhead.
>
> Fair enough for this particular case, as tracing can be disabled.
I think the same argument can be applied to patch #1 - it's hard to
imaging anyone debugging an IOMMU driver on a system where a few hundred
bytes makes the slightest bit of difference, and for people not
debugging IOMMU drivers it should be moot (per the message itself).
Robin.
next prev parent reply other threads:[~2021-04-01 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 9:31 [PATCH 0/3] " Geert Uytterhoeven
2021-03-31 9:31 ` [PATCH 1/3] iommu: " Geert Uytterhoeven
2021-03-31 9:31 ` [PATCH 2/3] tracing: " Geert Uytterhoeven
2021-03-31 13:40 ` Steven Rostedt
2021-04-01 9:14 ` Petr Mladek
2021-04-01 9:39 ` Geert Uytterhoeven
2021-04-01 11:28 ` Robin Murphy [this message]
2021-03-31 9:31 ` [PATCH 3/3] lib/vsprintf: " Geert Uytterhoeven
2021-05-17 6:21 ` Geert Uytterhoeven
2021-05-20 12:51 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dba57b-860b-0bd4-2ca0-e8f2e26571bd@arm.com \
--to=robin.murphy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elver@google.com \
--cc=gary.hook@amd.com \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome