From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965164AbbFCRNK (ORCPT ); Wed, 3 Jun 2015 13:13:10 -0400 Received: from mta01.ornl.gov ([128.219.177.14]:57074 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933303AbbFCRMx convert rfc822-to-8bit (ORCPT ); Wed, 3 Jun 2015 13:12:53 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,548,1427774400"; d="scan'208";a="104133754" From: "Simmons, James A." To: "'Joe Perches'" , James Simmons CC: "devel@driverdev.osuosl.org" , "HPDD-discuss@lists.01.org" , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c Thread-Topic: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c Thread-Index: AQHQnguZaQhyUg5qmk21knsoMUDg5Z2bBKhA Date: Wed, 3 Jun 2015 17:12:50 +0000 Message-ID: References: <1433341954-654-1-git-send-email-jsimmons@infradead.org> <1433341954-654-7-git-send-email-jsimmons@infradead.org> <1433342574.4861.126.camel@perches.com> In-Reply-To: <1433342574.4861.126.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: >> Handle all the style issues reported by checkpatch.pl. >> Remove general white spaces, spaces in function calls, >> etc. >[] >> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) >> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { >> toobig = 1; >> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); >> - CWARN("Too many interfaces: only enumerating first %d\n", >> - nalloc); >> + CWARN("Too many interfaces: only enumerating " >> + "first %d\n", nalloc); > >Please don't split single strings into multiple parts. > >For a patch like this it'd be nice to specify that both >"git diff -w" and scripts/objdiff shows no differences. > >Unless it does... Two patches have mistakes. Should I send a new series or do a in-reply instead.