From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE28C433FE for ; Fri, 29 Apr 2022 13:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359699AbiD2NEc (ORCPT ); Fri, 29 Apr 2022 09:04:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359695AbiD2NEa (ORCPT ); Fri, 29 Apr 2022 09:04:30 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36DC4793B2; Fri, 29 Apr 2022 06:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651237272; x=1682773272; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=k1CWm7qjA9y2fOTa8vpDb0S7DbYeiEIKA41/6A/74iI=; b=tN/dYHZu7KqCECPrNkMWlyJZ6GgtedZ4/VHJZho5F2Tr2yBPDsDZyMSq mdXp1mxKHz4poPAFMd34Yy/0iMU5sC33FkQX9zFQosqp92kdj5s+0xLij B44h/ZIgZxYgdzNiwM/j72JDqVFdCdwfvxNX6Ch3lBZk0gG0yRtpQvAtz k=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 29 Apr 2022 06:01:11 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2022 06:01:11 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 29 Apr 2022 06:01:11 -0700 Received: from [10.50.11.55] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 29 Apr 2022 06:01:05 -0700 Message-ID: Date: Fri, 29 Apr 2022 18:30:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial Content-Language: en-US To: Trilok Soni , Greg KH CC: , , , , , , , , , Bjorn Andersson References: <3fef68a94e4947d58a199709929d30e0e2bf2e44.1651139070.git.quic_saipraka@quicinc.com> From: Sai Prakash Ranjan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/2022 10:30 PM, Trilok Soni wrote: > On 4/28/2022 9:49 AM, Greg KH wrote: >> On Thu, Apr 28, 2022 at 09:31:43AM -0700, Trilok Soni wrote: >>> On 4/28/2022 3:50 AM, Greg KH wrote: >>>> On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >>>>> Disable MMIO tracing for geni serial driver as it is a high >>>>> frequency operation for serial driver with many register reads/ >>>>> writes and not very useful to log all MMIO traces and prevent >>>>> excessive logging. >>>>> >>>>> Cc: Bjorn Andersson >>>>> Signed-off-by: Sai Prakash Ranjan >>>>> --- >>>>>    drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >>>>>    1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >>>>> index 1543a6028856..5b48e6c2bf3c 100644 >>>>> --- a/drivers/tty/serial/qcom_geni_serial.c >>>>> +++ b/drivers/tty/serial/qcom_geni_serial.c >>>>> @@ -1,5 +1,11 @@ >>>>>    // SPDX-License-Identifier: GPL-2.0 >>>>> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >>>>> +/* >>>>> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >>>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>>>> + */ >>>> >>>> I strongly disagree that adding a single line here warrants a copyright >>>> update.  If your lawyers will sign off on this change, I am willing to >>>> reconsider. >>> >>> I am not a lawyer, we can skip adding QuIC copyright here since it is just >>> one line change, but at the same time we can't add 2022 year in the existing >>> copyright. >> >> That is correct, because you are not making a copyrightable change, >> otherwise the single line addition would be ok. >> >> Talk to your lawyers about this :) >> >>> If that is fine, we can skip the copyright year update entirely. >> >> Please do. >> > > Sai, please go ahead and remove QuIC copyright line here. > > Already done yesterday itself in the new version which is v13. Thanks, Sai