mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Matias Bjørling" <mb@lightnvm.io>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, javier@cnexlabs.com
Subject: Re: [PATCH 3/4] lightnvm: add 2.0 geometry identification
Date: Mon, 5 Feb 2018 10:04:45 -0800	[thread overview]
Message-ID: <b8ddae5a-064c-7468-d5e2-a5a20a93de19@infradead.org> (raw)
In-Reply-To: <20180205121505.27563-4-mb@lightnvm.io>

On 02/05/2018 04:15 AM, Matias Bjørling wrote:
> Implement the geometry data structures for 2.0 and enable a drive
> to be identified as one, including exposing the appropriate 2.0
> sysfs entries.
> 
> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
> ---
>  drivers/lightnvm/core.c      |   2 +-
>  drivers/nvme/host/lightnvm.c | 334 +++++++++++++++++++++++++++++++++++++------
>  include/linux/lightnvm.h     |  11 +-
>  3 files changed, 295 insertions(+), 52 deletions(-)
> 
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index c72863b36439..250e74dfa120 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -934,7 +934,7 @@ static int nvm_init(struct nvm_dev *dev)
>  	pr_debug("nvm: ver:%x nvm_vendor:%x\n",
>  			dev->identity.ver_id, dev->identity.vmnt);
>  
> -	if (dev->identity.ver_id != 1) {
> +	if (dev->identity.ver_id != 1 && dev->identity.ver_id != 2) {
>  		pr_err("nvm: device not supported by kernel.");
>  		goto err;
>  	}

Hi,
The pr_err() above could be a bit more informative to the user. E.g.,
		pr_err("nvm: device ver_id %d not supported by kernel.",
			dev->identity.ver_id);

BTW, isn't that line missing a '\n'?

-- 
~Randy

  reply	other threads:[~2018-02-05 18:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 12:15 [PATCH 0/4] lightnvm: base 2.0 implementation Matias Bjørling
2018-02-05 12:15 ` [PATCH 1/4] lightnvm: make 1.2 data structures explicit Matias Bjørling
2018-02-05 12:15 ` [PATCH 2/4] lightnvm: flatten nvm_id_group into nvm_id Matias Bjørling
2018-02-05 12:15 ` [PATCH 3/4] lightnvm: add 2.0 geometry identification Matias Bjørling
2018-02-05 18:04   ` Randy Dunlap [this message]
2018-02-06  9:43     ` Matias Bjørling
2018-02-08 13:35   ` Javier Gonzalez
2018-02-05 12:15 ` [PATCH 4/4] nvme: lightnvm: add late setup of block size and metadata Matias Bjørling
2018-03-23 11:00   ` Matias Bjørling
2018-03-28  8:28     ` Christoph Hellwig
2018-03-28 12:36       ` Matias Bjørling
2018-02-08  9:35 ` [PATCH 0/4] lightnvm: base 2.0 implementation Javier Gonzalez
2018-02-08  9:42   ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8ddae5a-064c-7468-d5e2-a5a20a93de19@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®