From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164375AbdEXWJM (ORCPT ); Wed, 24 May 2017 18:09:12 -0400 Received: from ale.deltatee.com ([207.54.116.67]:37391 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164326AbdEXWJL (ORCPT ); Wed, 24 May 2017 18:09:11 -0400 To: Al Viro References: <1495663252-22434-1-git-send-email-logang@deltatee.com> <20170524220510.GF390@ZenIV.linux.org.uk> Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, Stephen Bates , Jeff Dike , Richard Weinberger From: Logan Gunthorpe Message-ID: Date: Wed, 24 May 2017 16:09:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170524220510.GF390@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: richard@nod.at, jdike@addtoit.com, sbates@raithlin.com, user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] um: add dummy ioremap and iounmap functions X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/17 04:05 PM, Al Viro wrote: >> I have designs to use these functions in scatterlist.c where they'd >> almost certainly never be called on the um architecture but it does need >> to compile. > > Then make it fail there. Ok, will do. I'll send a v2 patch shortly. > Incidentally, s390 has ioremap() only when CONFIG_PCI is set. Hmm, ok, I'll take a peek. The kbuild robot never reported any build issues with that architecture. I did see exactly this on the tile architecture which I sent another patch for (that your feedback also applies to). Thanks for the quick review and feedback, Logan