From: Larisa Ileana Grigore <larisa.grigore@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
NXP S32 Linux Team <s32@nxp.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@sandisk.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
Ajay Neeli <ajay.neeli@amd.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Pedro Sousa <pedrom.sousa@synopsys.com>
Cc: linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, clizzi@redhat.com,
aruizrui@redhat.com, eballetb@redhat.com, echanude@redhat.com
Subject: Re: [PATCH v4 07/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller
Date: Mon, 21 Sep 2026 11:22:19 +0300 [thread overview]
Message-ID: <b8dfcfc2-df7e-4b0a-b3e0-c5c8f58752b1@oss.nxp.com> (raw)
In-Reply-To: <946fb909-8e21-4775-8328-c46e306f17c4@kernel.org>
On 9/18/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On 17/09/2026 11:15, Larisa Grigore wrote:
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: nxp,s32n79-ufshc
>> + - const: jedec,ufs-2.0
>
> Continuing discussion from v1, why replacing one fallback with another?
> So previously it was compatible with 3.0, but now it is not and it
> became compatible with 2.0?
>
> I cannot find any software user of any of these fallbacks, thus IMO it
> should be dropped, unless UFS folks have some arguments for keeping it?
>
Thank you! I will drop the JEDEC fallback compatible. Looking at the
existing UFS bindings, not all controllers provide such a fallback (for
example, Renesas UFS controllers), and I could not identify any software
user for it either.
>> +
>> + reg:
>> + items:
>> + - description: UFS Host Controller registers
>> + - description: System Control Module registers
>> +
>> + reg-names:
>> + items:
>> + - const: ufshc
>> + - const: scm
>> +
>> + clocks:
>> + maxItems: 1
>> + description: UFS core clock
>
> Drop description, redundant.
>
I will drop it.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - clocks
>> +
> Best regards,
> Krzysztof
Regards,
Larisa
next prev parent reply other threads:[~2026-09-21 8:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:15 [PATCH v4 00/11] Add S32N79RDB UFS support Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 01/11] scsi: ufs: dwc: Return a negative error if the link is down Larisa Grigore
2026-09-17 15:58 ` Frank Li
2026-09-21 8:18 ` Larisa Ileana Grigore
2026-09-17 9:15 ` [PATCH v4 02/11] ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 03/11] ufs: unipro: Add TX/RX FSM state attributes Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 04/11] ufs: host: Add common Hibern8 TX FSM polling helper Larisa Grigore
2026-09-17 16:03 ` Frank Li
2026-09-21 8:19 ` Larisa Ileana Grigore
2026-09-17 9:15 ` [PATCH v4 05/11] scsi: ufs: Move Versal2 M-PHY CREG access helpers into ufshcd-dwc Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 06/11] scsi: ufs: dwc: Export common clock divider and link status helpers Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 07/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller Larisa Grigore
2026-09-18 9:49 ` Krzysztof Kozlowski
2026-09-21 8:22 ` Larisa Ileana Grigore [this message]
2026-09-17 9:15 ` [PATCH v4 08/11] scsi: ufs: Add NXP S32N79 UFS host controller driver Larisa Grigore
2026-09-17 16:18 ` Frank Li
2026-09-21 8:33 ` Larisa Ileana Grigore
2026-09-17 9:15 ` [PATCH v4 09/11] arm64: dts: freescale: s32n79: Add UFS host controller Larisa Grigore
2026-09-17 9:15 ` [PATCH v4 10/11] arm64: dts: freescale: s32n79-rdb: Enable UFS Larisa Grigore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dfcfc2-df7e-4b0a-b3e0-c5c8f58752b1@oss.nxp.com \
--to=larisa.grigore@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ajay.neeli@amd.com \
--cc=alim.akhtar@samsung.com \
--cc=aruizrui@redhat.com \
--cc=avri.altman@sandisk.com \
--cc=bvanassche@acm.org \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkp@kernel.org \
--cc=pedrom.sousa@synopsys.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=sai.krishna.potthuri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®