From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Nicolas Saenz Julienne <nsaenzju@redhat.com>,
paulmck <paulmck@kernel.org>, maz <maz@kernel.org>,
frederic <frederic@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
rcu <rcu@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Anup Patel <Anup.Patel@wdc.com>
Subject: Re: Possible nohz-full/RCU issue in arm64 KVM
Date: Tue, 4 Jan 2022 18:07:32 +0100 [thread overview]
Message-ID: <b8e273bf-ae2c-cc5c-0d20-33f3dd12053c@redhat.com> (raw)
In-Reply-To: <YdR4N9QVYOzjowAb@FVFF77S0Q05N>
On 1/4/22 17:39, Mark Rutland wrote:
> My main issue here was just that it's really difficult to see how the
> entry/exit logic is balanced, and I reckon we can solve that by splitting
> guest_{enter,exit}_irqoff() into helper functions to handle the vtime
> accounting separately from the context tracking, so that arch code can do
> something like:
>
> guest_timing_enter_irqoff();
>
> guest_eqs_enter_irqoff();
> < actually run vCPU here >
> guest_eqs_exit_irqoff();
>
> < handle pending IRQs here >
>
> guest_timing_exit_irqoff();
>
> ... which I hope should work for RISC-V too.
>
> I've had a go, and I've pushed out a WIP to:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/kvm/rcu
Yes, you have a point and it makes sense for x86 too. You can send me a
topic branch once you get all the acks. Thanks!
Paolo
next prev parent reply other threads:[~2022-01-04 17:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 11:51 Nicolas Saenz Julienne
2021-12-17 13:21 ` Mark Rutland
2021-12-17 14:15 ` Nicolas Saenz Julienne
2021-12-17 14:38 ` Mark Rutland
2021-12-17 15:54 ` Paolo Bonzini
2021-12-17 16:07 ` Paul E. McKenney
2021-12-17 16:20 ` Nicolas Saenz Julienne
2021-12-17 16:43 ` Paul E. McKenney
2021-12-17 16:34 ` Paolo Bonzini
2021-12-17 16:45 ` Paul E. McKenney
2021-12-17 17:02 ` Paolo Bonzini
2021-12-17 17:12 ` Paul E. McKenney
2021-12-17 17:23 ` Paolo Bonzini
2021-12-17 17:47 ` Paul E. McKenney
2022-01-04 16:39 ` Mark Rutland
2022-01-04 17:07 ` Paolo Bonzini [this message]
2022-01-11 11:32 ` Nicolas Saenz Julienne
2022-01-11 12:23 ` Mark Rutland
2021-12-17 14:51 ` Paolo Bonzini
2021-12-20 14:28 ` Marc Zyngier
2021-12-20 16:10 ` Frederic Weisbecker
2022-01-04 13:24 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e273bf-ae2c-cc5c-0d20-33f3dd12053c@redhat.com \
--to=pbonzini@redhat.com \
--cc=Anup.Patel@wdc.com \
--cc=frederic@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nsaenzju@redhat.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®