From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF152A1BF; Sun, 29 Mar 2026 03:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774754454; cv=none; b=b4btHpJDe7ynJYWLG/TffWobaYZocwU+TJpWHDVkqbDo9fSjvXpXo9IxIaLKeKMwvV+ZlFcuxnpP4y5q1HuEwtfmifsXNbsQDny736ue0CRq9f8eCcfkifBwiFx5GHDDPOpAFG+WvuXHREz6UMzRNpDsynyWS7PyeO5eFd0DZVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774754454; c=relaxed/simple; bh=D0bGQLT7f3byQBg+qaH5vPMrR05TsJs3lS+DSoGJbOo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h5j417v41XpHa9zzIsQm7RpMsF2DutWbeHbUrhJqKLzXbSQ9XYBWsbNbJI/haJxYE4bZMtAVeLnyUejwriakWXUbsCGGNTd3/kn0aabMk3WxHZD4nzQAtXP9nWzYom9iQXkeUCG1YFZWw/YF972hFSTaLBn+qrAtDuX9tJ3nGVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=1Rwsmr+7; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1Rwsmr+7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=gUuZHrDWxaaWF4+/n4z56tn8qK+LyT2Zab514kfOXec=; b=1R wsmr+7CebtxmeC7zSCRBXBzSP8TtlMe1LeiLLkDCkbO6f1YWfIH9XlyyRJk9qfQmjPkiqnYrcJbYX fMvITKt05bjHr+c22rl8xd158RD+PJo097oMNQod4FzDa4iVhmf15I0Syp5CHamydP7ETNHRJKNb2 A4sxszRKx5ltQz4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w6ghV-00Dr5E-2n; Sun, 29 Mar 2026 05:20:33 +0200 Date: Sun, 29 Mar 2026 05:20:33 +0200 From: Andrew Lunn To: Anirudh Srinivasan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: aspeed: Enable networking for Asus Kommando IPMI Card Message-ID: References: <20260328-asus-kommando-networking-v1-1-66d308b88536@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Mar 28, 2026 at 07:14:04PM -0500, Anirudh Srinivasan wrote: > Hi Andrew > > On Sat, Mar 28, 2026 at 7:05 PM Andrew Lunn wrote: > > > > On Sat, Mar 28, 2026 at 06:39:59PM -0500, Anirudh Srinivasan wrote: > > > Adds the DT nodes needed for ethernet support for Asus Kommando, with > > > phy mode set to rgmii-id. > > > > > > When this DT was originally added, the phy mode was set to rgmii (which > > > was incorrect). It was suggested to remove networking support from the > > > DT till the Aspeed networking driver was patched so that the correct phy > > > mode could be used. > > > > > > The discussion in [1] mentions that u-boot was inserting clk delays that > > > weren't needed, which resulted in needing to set the phy mode in linux > > > to rgmii incorrectly. The solution suggested there was to patch u-boot to > > > no longer insert these clk delays and use rgmii-id as the phy mode for > > > any future DTs added to linux. > > > > > > This DT was tested with a u-boot DT modified to insert clk delays of 0 > > > (instead of patching u-boot itself). [2] adds a u-boot DT for this > > > device (without networking) and describes how to patch it to add > > > networking support. If this patched DT is used, then networking works > > > with rgmii-id phy mode in both u-boot and linux. > > > > I've been looking at > > > > https://elixir.bootlin.com/u-boot/v2026.04-rc5/source/drivers/clk/aspeed/clk_ast2600.c > > > > And i don't see where mac2-clk-delay is implemented. Could you point > > out the code? > > I'm testing against the u-boot version that openbmc uses for its > builds. I don't think upstream u-boot is used by openbmc. > > https://github.com/openbmc/u-boot/blob/v2019.04-aspeed-openbmc/drivers/clk/aspeed/clk_ast2600.c#L999 Please include in the commit message that you need to use a fork of u-boot. Andrew