From: "Guillaume LECERF" <glecerf@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9
Date: Fri, 6 Jul 2007 01:09:34 +0200 [thread overview]
Message-ID: <b8e9195f0707051609v36182409mc07f030cca790a7a@mail.gmail.com> (raw)
Hi all,
While reading the last libertas commits, I discovered that this commit
introduced a regression in the libertas wireless driver, inside cmd.c
:
commit 18c96c3497aa871608d57ca5e08de3558159a6c9
[PATCH] libertas: fix WPA associations by handling ENABLE_RSN correctly
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=18c96c3497aa871608d57ca5e08de3558159a6c9
The logic behind has been totally broken, and I think this patch is
worth reviewing.
Regards,
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -241,7 +241,7 @@
if (*enable)
penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
else
- penableRSN->enable = cpu_to_le16(cmd_enable_rsn);
+ penableRSN->enable = cpu_to_le16(cmd_disable_rsn);
}
lbs_deb_leave(LBS_DEB_CMD);
--
Guillaume LECERF
GeeXboX developer
next reply other threads:[~2007-07-05 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 23:09 Guillaume LECERF [this message]
2007-07-06 7:29 ` Satyam Sharma
2007-07-06 11:48 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e9195f0707051609v36182409mc07f030cca790a7a@mail.gmail.com \
--to=glecerf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®