From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6DB3B2FF8 for ; Mon, 30 Mar 2026 09:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862847; cv=none; b=ryJiy5MGEmx6zFcZ4yQiXKE47vkzbdh0BNCl918FK1F7UFWip5Cg6EsHEi1kWr+tC4KpyohHLI59BjGrBaZuxd82m1o1dlSGEdUlatZjE934IjK3gUKbE552qNkeou5R9jcmqdoEWXxGTcwQy8W/3cMTslkRXym+9gspNV3N6Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862847; c=relaxed/simple; bh=Qbngn77JdyweWLsDY3IBnaFTiTzaPsOZMt+WqQwrXao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XuBfBtV3sMbwKDhH0XJTgP9iYhv7w44Mq5p3Ua0gJ0LuhCC+8KqC0GscAYNbx6+j9tmpHXpVdC/pyC3rdUrXwTGWXzJ6yELjw6w8y5SCikEhm0/ck71O3Q4SwKXUYRiO6y7Fg7RUWdDd/kijnl81YMUeqY+Y2fM7NEOEUpRHdVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AEXQYG57; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LiABGweA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AEXQYG57"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LiABGweA" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U7fkQH350298 for ; Mon, 30 Mar 2026 09:27:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6lRyP2v+TyzHmUXjihsV/Pp6jzdERcDAdIA5S7gMZyE=; b=AEXQYG57WEYZW2wf nZgJJsWxwyt97vvvMl5Nf5OFkpgUeTOBseIXl7xXViKHkrC6LwE3ROcLOhywZnrD diiw0FMrnZO4rfgD3TChlSr+/Jt/Vz3V7jRYVRT6vfuN1BikF7tba1CkzytRg34V 5fR4LYcdbrHfSDEQFJwHtEp0z/372irX761KzTpIu1HuySihq/oIZW1+MnmknH/w Szp6T/3iyZlpxO3nHdm92AGmsRyXqsBfVxQXCzz/g3k5LVML2n9vcHKYqDXXbSK6 bIOeBGxtjriszBam6Kl7oOcQV3TqsII55Nzl5LaALQ5WC7tbL3LKbtsnQJ2odGk3 RapqZA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d6wqekb8s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 09:27:24 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b24af7ca99so18118595ad.1 for ; Mon, 30 Mar 2026 02:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774862844; x=1775467644; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6lRyP2v+TyzHmUXjihsV/Pp6jzdERcDAdIA5S7gMZyE=; b=LiABGweAOaIL9B/m4N0Se4qpk/VQTrjUTkXg+JkSq6sC680koLdsaR4/MhfpdctTIu h0xw4VDnXG5E2e7A/NEQr2NsoEWu6gaTFNPfJVxK7vDPvGvXNpSfzkSLf7iqrIWacT03 D+boWEBYxlez3ZnSY8sygkLxGuqjikoPR4s7qOr7oRRme1LlDO+xw7mlr0UeWwLBc1OB v+cuz0Wvnl9F+pVJU29eO2NnqoidwZBPOKtRzLIGMglXMehnxVaH4oBwFy8FNXIi8hYB 86g6eq2rQH9JDct7XLIvj7WfptFa17A0NbHwCrAh8J747s7XqMr69Hw581hVMgfZuTqr Uk5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774862844; x=1775467644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6lRyP2v+TyzHmUXjihsV/Pp6jzdERcDAdIA5S7gMZyE=; b=h3clY10QUlgr/3v9RAns1FAGm9sqttnSOLobzhq3HQze8fffDQGDpzPr9Mh6ULuEYJ auV5NuUWZAJG7dazNMINeKeHibWOBXa/hI/oXVe/DsGMcFKhp+pzLOAPTzN6RmW4trpn oSda++DUaoLNBe8Uf18A77+hnROVy3o34OPtD9+eliQuQ+8G74rYqwhWff0llG62CeCD pWm1k9gCXVYR0+SYOrYRkPxUU4u9Z4WclmM3dxJSw1K5/9I8CkMEfBz0Xclm7FUGN7/d 1mF8O08wo0welSJgLPJiOSW9x7OXJ+yjHs6Aopi+M6nxPqPYQnZIrzeqT9TcSOJrCAky +VVA== X-Forwarded-Encrypted: i=1; AJvYcCWoLadlzHYE3gKg2mkkOpjnEFXE4Xii5H3mLxq5VTHx6s8TXx73UVmZLmlw5kQFh+dc2oJeQ3sNU99sMsU=@vger.kernel.org X-Gm-Message-State: AOJu0YweV6rhaSn9arnittf7HPuXcl3UET4UzCM2sFrkyn3m65wPMZeA fNu4K4DsZMarjab18e5+baP/JGSwjyiZnJvyjjA/tU4sF8/zc9BcsGSmPprJxbtS2jIvhhAO0Lv iAY/eVs3a02k91LRy1c+riLHkjYsBbbR8So4U8XD+s70lB4z+QPqkz61dzzigqSq4OiM= X-Gm-Gg: ATEYQzwAuBn6iLC8YXwcGKkWlY/V7R7eGtacjoFcyrWRYRfUAtSTOAPQWw0CilevCtF nEO26SeUD0yvz7ppKoqMjBtAv/cz+8wT1A2OUm3T8sUfIrohXxAkjeJSIXxQ0+YNk+PnzhEV5Lc sD4ROjZ71JOgQOLc5FFPvvMb7lmAyIF08pQGz28zE/yGU2G761omsAklOAy0isUYCDIffufQrpa jdqlsR69OblERr1PQQHWK53cJbYhw+vRpppdCzA+BhpgYRRecTIEoQvrLyuQEIqtuNJ2NZEGhp3 tmfT49UT+HYfLrqort9tgK3Dxm+4UGjelxHtfrrLdm0hz+vr3gsYJ/n46nDfDvUeXAasUyuOqS7 rhkVDfbXqYI10Tw4qFff/hfFPzUewELLLvR9EWKLVfPIRU+w+MSApeNh3TDUvBByucA== X-Received: by 2002:a17:902:ce8c:b0:2b0:a957:304 with SMTP id d9443c01a7336-2b0cdc22fc5mr126256945ad.6.1774862843797; Mon, 30 Mar 2026 02:27:23 -0700 (PDT) X-Received: by 2002:a17:902:ce8c:b0:2b0:a957:304 with SMTP id d9443c01a7336-2b0cdc22fc5mr126256655ad.6.1774862843338; Mon, 30 Mar 2026 02:27:23 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642913sm72585395ad.10.2026.03.30.02.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 02:27:22 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 14:57:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Introduce IPQ5210 TLMM driver To: Linus Walleij , Mukesh Ojha Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260330-ipq5210_tlmm-v4-0-b7c40c5429e5@oss.qualcomm.com> <20260330-ipq5210_tlmm-v4-2-b7c40c5429e5@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Jo78bc4C c=1 sm=1 tr=0 ts=69ca41fc cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ucmReQScbumPMK653VEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: 7yc0Fxow1NYWSblEKJndDjM27nA7oncQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA3MyBTYWx0ZWRfXzgqWjOZHjbRE BWH+ceeGomhLN4TZij0wmpfXrg3qrZUGxgmvfiqllOqBIvEd7qKLKkATF7KUhFnFhu8qoWMeYNR TWZPbmyMRvcyt3MBR0Q3aFkOed2pSxou3FBNnUINq8FTgY3fnwRQ/FYdVA3nYE4CkINmMPtRukh yPiXzOFNriA1GXZOuAzjRMj/8MzLXId1aa4iqrTYut5GgzGXr4U+8vlHCmaJDb1Gw4b/ZzK2DF3 KEvF6o2Oep/QByb3gVjmr/t3ZKo42zoY1Bn6kcNFRWzzfVnPsOoN/kGPWeXPS8YJXWUUBW+wZU5 3B4mrK1HXoTqWn5lhlbEFBLwC1ZHeEit8ATg6yIn+7TYrXUwaaWgnaAgx50iCA0CSm6YbDY6M1U rtfnGNrhw2XC29NwnCgkotk+PKoHIyATU4Em7A5Adc2/xHDfRppdums5C8Fty7APcNH3WdDBCw7 T873Hvm6uFgx7vcFJjg== X-Proofpoint-ORIG-GUID: 7yc0Fxow1NYWSblEKJndDjM27nA7oncQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300073 On 3/30/2026 2:19 PM, Linus Walleij wrote: > On Mon, Mar 30, 2026 at 10:45 AM Linus Walleij wrote: >> right before merging this patch I merged: >> https://lore.kernel.org/linux-gpio/20260327171240.3222755-2-mukesh.ojha@oss.qualcomm.com/ >> >> On Mon, Mar 30, 2026 at 6:51 AM Kathiravan Thirumoorthy >> wrote: >> >>> + .intr_status_reg = 0xc + REG_SIZE * id, \ >>> + .intr_target_reg = 0x8 + REG_SIZE * id, \ >> (...) >> >> Should intr_target_reg be dropped also from this driver? >> >> If so, please send a follow-up patch. > After reading closer I can see it definitely should be dropped > so I just augmented the patch. > > No need to do anything. Hi Linus, Thanks, I noticed the Mukesh's change and I thought I can send the follow-up patch. But thanks for taking care of this. Thanks, Kathiravan T. > > Yours, > Linus Walleij