From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbdJEPn5 (ORCPT ); Thu, 5 Oct 2017 11:43:57 -0400 Received: from mail-eopbgr50078.outbound.protection.outlook.com ([40.107.5.78]:47890 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbdJEPny (ORCPT ); Thu, 5 Oct 2017 11:43:54 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ed.blake@sondrel.com; Subject: Re: [PATCH 4/4] irqchip: imgpdc: Pass on peripheral mask/unmasks to the parent To: James Hogan Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org References: <1506938159-466-1-git-send-email-ed.blake@sondrel.com> <1506938159-466-5-git-send-email-ed.blake@sondrel.com> <20171004140302.GG25320@jhogan-linux.le.imgtec.org> <20171005152647.GL25320@jhogan-linux.le.imgtec.org> From: Ed Blake Message-ID: Date: Thu, 5 Oct 2017 16:43:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005152647.GL25320@jhogan-linux.le.imgtec.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [195.88.9.101] X-ClientProxiedBy: DB6PR0801CA0060.eurprd08.prod.outlook.com (2603:10a6:4:2b::28) To DB6P191MB0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:4:8b::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d750992a-c5a0-4704-ebd9-08d50c07e05d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6P191MB0006; X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0006;3:QpbcbyjZdewr4A5b9Wg3XrY77KWp8UtRjbLX4t2NGpPa/V8kRMF5AQy+9AePG2YXLdADuvmsQ6TGlkQQN5kTTi7u93vLWrzGzDbUt2qRnDBmJHDoyUZWpmCLH6/iFFwSZ/XRmsmmxXqhfyvxE90w0aARHaYA4KDOLhjVr3zWlTHHC8dIfCOdxKLA/7TEzyO3FeFH0mCdg5B/tYDD2RvTWFKu9kC9BsL+vty9rL4bvrGIU7IbiLTnsWph3bGMN6kT;25:9lYLfjtjfPENWZmvqRXy6rhL06R6pbD1lerGu7ywTbbArCNM2JKAscCzmmzBuCD3n/ifrAPwLSbxFWFdeKilJf3+Pi/hQzLaYe87sMdBPv7AG/J8D3e25XtH9Uciu6tpdnqlbJBup1Lf2WeYx+ut48wuQoWoeWhJVBj8EXmJgGJWNOyRV+JyQdmhN3IiQ1zBf/ycUSZRGa0Z4mPOw1PAxyVTN0zEQuewXS1ThAEOyAQPSmQWJOSfBTHnKBC3UzVsnGCNa0YPg4nVVvZHMqR/HUfuJgAzASIwfq7xeBLKtUkv7nmrNVY8ar7lE/r334Ol4zEzRqhkjiLg70QH9ElaRQ==;31:h7BZqyMpbi3qfVs23ZwaJS2PoHNf+3RquaGqS8qgfadVqsUkn2fhyqAZVRt1xfe/9LgRBkLHfbydEBnxwHcpfa/UHgLRu/scO6AJJIPzYFHzN07xyCsRGCATG7m6JK9WwVlKyex2mp5XvKRTBB+f89luQRzfRAA+N0fEqm6V+NgmlgQJ17xZ2cIiU1T/eRZz9a+Ajw9Pu2iIawJXC5KAg221z1oAQfeGL/F3YWsp5PM= X-MS-TrafficTypeDiagnostic: DB6P191MB0006: X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0006;20:omLp2DAIiVFJoLwvPfZOuubrmVvX5aXCTOwZ+dwvYJI3qrLC/6Kjbnx3JWk/UyfEhkDKem6SjknrJiww1m9jylv9FpjLmDx6MV4aRkOHkYo1wjM6gW2YeIqV6BVRk84fSTtazcOi7/AaDBcDFpFH7vVM8an6qDU4raoap1BE4yKZvYNye5eKrWA+mG3oOHZjxVhtQ+Y32ukNL4+v5+Zbr3yy2eZze/l8bg1iHGVD3djWFRJ+TpJNihgFxCK+iPC9;4:epdi7ToQd8gS2UhQLT9nwHZEEoe2xgZ4dxyLEFGbGoBLltsAcNmAFA+xmAtTCwD1yaU6ulhDL0yQJK4wW6SCNHHeftdkXESpQY9k0bX5PqSVbUVZX+0GaJqN/6mOB4cSRtlvS5ArIOSTkEs4mtUGycn5KSL7FX5ZOkUB2CjTZBm7Bec5zqDKBllSD1xRjA/Lxrq7itFh0Io1+yO1V4K7a3o1lECMAvJE0lN3ZYPurL0teo8AXVJJ/rnQIq4okASx X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6P191MB0006;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6P191MB0006; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(39830400002)(189002)(199003)(24454002)(36756003)(229853002)(6916009)(2950100002)(47776003)(58126008)(65826007)(83506001)(189998001)(8676002)(97736004)(93886005)(77096006)(478600001)(6486002)(2906002)(31696002)(86362001)(65956001)(50466002)(66066001)(5660300001)(53936002)(65806001)(50986999)(2870700001)(101416001)(25786009)(33646002)(316002)(31686004)(7736002)(64126003)(105586002)(16576012)(106356001)(76176999)(23676002)(54356999)(68736007)(81166006)(4326008)(8936002)(6246003)(53546010)(305945005)(6116002)(81156014)(3846002)(16526018);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6P191MB0006;H:[10.40.8.170];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQMTkxTUIwMDA2OzIzOnJvdWpYN1JlZ284bWZON2NacGc0UmRsNnVt?= =?utf-8?B?K2hOdEFYMVRDalFteHVGWXhFVVEyOHB6b0hsZGVTV1ZwdHFiemhPa3NJUjhy?= =?utf-8?B?cEJzbTlMbzdDWWYrdTMxcjdNeHJrODZKUThxQ3l2b21kZHlTOVNycksrTlc0?= =?utf-8?B?WWdMRnE1T3ZYTVlmTGdxTTVJendkS01mMHZXMDVwakh3REpZei82eHZRMmd0?= =?utf-8?B?eVFvYUQzVmVqbnd0SHYySnByRnVrK1JtVThhbEpxaE9rK3ZWMXRIcVplMC9n?= =?utf-8?B?MFdpWktsUGxOMWJRRzFMeUp3djhQRDdWSFdMclBCNTJrNnJPd1pGWVF5UWFU?= =?utf-8?B?YjBZMTl6OUF0Y3B6S0tVamp3VVd1VGs4NHBlUDM0MW9QSkU0eVpheUZEOXpR?= =?utf-8?B?TVd5OXhyd1ZCZHhPdDI5TEVBWEFobTlmWHRmMkdIcFl4bklRV0lrRzRpbEpr?= =?utf-8?B?NThEZEZlNUZmMDljYmdhTG1zbVp0S1lpaURRMS95YnV5MzZDMDgxaCsxeERZ?= =?utf-8?B?WUk1ZWRpb0dDRmNWV0RVV2NqbVlxSWhXbEtvZmZXMWhCNG1vOFFKNm1jSnpL?= =?utf-8?B?VmcyeUExZmUvV1gzRVo1VWx0S0VLVkJXY3VBa25JMlEzbUVYWWY0bGxHVmtF?= =?utf-8?B?UUI3akFpeGFDSElNUkYzbjJ4M1hKTWxvUUh5dW1SRFdqTGsvMUNlSm9DekhZ?= =?utf-8?B?QkF0SjlkSU1rOG5LR2VXdzU5STgrUDFnaldBU0JLQXlWZitkWEQ4WDhYU0JC?= =?utf-8?B?MFlXUlBoa0ZjK0M1eEcxbG1USW9lenZNcE1XOERVRmFlU2o2MmRweFBiL2FY?= =?utf-8?B?MFl4azlEM0pwc0FocjJzMEhaVzRJL0trc2VJcGl2WTEvcHExVG5WYXhVOEFq?= =?utf-8?B?YTZsdTI5b1FjZm14dXhkdWNtUlZkUVlJR01xM1U0aklSTEJMemhNV1ZXQ2lr?= =?utf-8?B?V0E3Rk9iS1ZhSTAzd2EwNTZRTWt5eFFDbS9qeDlxaXFqeHlXYXQ4bEQ5VFpk?= =?utf-8?B?cDg2NjVZeStBN0IzN3RFRXM5NGVxQ2RSME9aOXFBMUhjMkpFRm5wdXNKN2F2?= =?utf-8?B?ckQwWHlOTHpUTjhZaWw5SW9NV3N3UGM2TGk4RXo1eFU1cDUzUU5lZ21ZNHk1?= =?utf-8?B?dnNRYUM0NUUzbnJVYjNJcG5FbDRYNURjWlNqNVZhVzZHZ3pnRERMSkZTaUx6?= =?utf-8?B?UXo4T2ZKdU9kY0dsQktac0F1VTZkOEkwUVNoMk43TG1UYllVL21OcWJvbXdH?= =?utf-8?B?T2djelFYejdDSXQ0NnFDakVIYTFieEdXQmE3UndGUTVRSnJYVTZCS2p3VFpU?= =?utf-8?B?VHhoQUxoQnp4QlF4V2FEN2ZSUlkzcWIxdUQ4SkVEM3ZTWFJ2NUs4NkM1M2FN?= =?utf-8?B?UGRMSlRENTlsRkxVYjhvaXpUWkZwQXZGQk5Bc0dOWU1tQ2pQcmlnakN0N0pL?= =?utf-8?B?ZWk2N3V6TkRON1k1VGNRTW5saWJJblNsQVFoTXZpYjh2eDV5UkRBYmo3VXRK?= =?utf-8?B?S1BwV0VjemVMSG1lMXRDc0lsZS9XNlM0dEErM2V6MWdWMjQ4YngrNTk5bUhm?= =?utf-8?B?UWsyYjd3NWY0R29XVjRkck8zSFh4clRlK3Z2WkJSdHl1Nkl1eVhiMG9JaTll?= =?utf-8?B?dGo4ZFUyM2xWVWUyMEhydUtiNFBkQUF6cjBqWjgxUEgyZVJXRkJKTjhyaWJ3?= =?utf-8?B?cUI2Tm1lMDhwTTdMRGhhUkxCa0VQZENpbmF2RHI0MWVLQythR1UzYk92UER3?= =?utf-8?B?cFE1Mm1oZ0U4MzlZbVJsb3Jua3NidjJHeHZnMGwvWVJNS1F3eGUvbWFIclJH?= =?utf-8?Q?iLBz+EBXs6whk?= X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0006;6:ljpQYeHi3qA3UEWl9kN0j+mtDAzHTuoLPV2hnMqEH3ucv+a0wij4liCU7j0weXUJXrKny/EaGxlJcee5gx9vM088sin2U7ya3bqrU1yiVodrtgN9GuNxPKnXHZzO+53LyOM6bHggAaqhdZ4aR1dYinH0eFLEy/rakYbYEGsqdfxQlJI7rT9wReKryYlUh6PFJaNumKGwui0kffDjfDVDHVxW63xEYKGBlUER49g42ky52ErRXBeQjNpbKf4evzkvHcEEUSvWHLLwpJhZHt/lm7fAiHULRbmNzHpl9CbNlD1hXkF+l7OuNo2S3h8Tx9bWA9GFWdRmrlKEZjoQh0kSWA==;5:lZvGbuR8PKW9NSDXOSIHkaCqCywU+QsFvTCRFOrIFZNbL7DVyrGdQn1YQfgloLEp+qcACwNGw3z7Fkl84sGRrxsw6edWYh3CpY6p8B5t3FdND0sDwOo58fwTf4b+h0IxKcoITXy/HeJF8zgsEXzTw/xstLSRBjrC0bk8Mnpvbts=;24:MD4ml2u4Z6TK/ZzMqraiRVQS2/QPAvmPLzoetOe3EJfmIzESMlELdZ97GR6TZW4+dZVftgK9SjIYw7foAyYkZec+OjZdeE8t5AEpEnkvgGk=;7:Mps0yHC6noaapyFaycKtnGsUWrXR2ryKj/TFatB8wX0aXY8Zb2W4KvGxt69dNWCjebZ50g0rgo9p6QXnr/UZ4QU7AsR1yg+yuqN5qEHfgl+ZWmbSvoUV60YH/4OKXm2pJrqk0AfoQ1eRg1Ce2j5SHQIC7pIRBZcql+1j0FtvcNILCrfN9IUC4k+b2N8xnqJti0a7U7HdFgd+mUeCoSMYWXjwuHxV0Wg/jo1ZPCWlNY0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sondrel.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 15:43:50.9942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4faa3872-698e-4896-80ec-148b916cb1ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P191MB0006 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/17 16:26, James Hogan wrote: > On Thu, Oct 05, 2017 at 03:48:53PM +0100, Ed Blake wrote: >> >> I'm not sure how this is supposed to work, but the issue seems to be >> that without this patch the parent irq isn't being masked.  This is >> causing the parent handler (MIPS GIC in this case) to be called >> continuously.  This leads to the PDC irq being masked each time, but not >> the parent irq.  This is the callstack: >> >>     "irq-imgpdc.c"::perip_irq_mask >>     mask_ack_irq >>     handle_level_irq >>     generic_handle_irq_desc >>     generic_handle_irq >>     generic_handle_irq_desc >>     generic_handle_irq >>     gic_handle_shared_int >>     gic_handle_local_int >>     "irq-mips-gic.c"::gic_irq_dispatch >>     generic_handle_irq_desc >>     generic_handle_irq >>     do_IRQ >>     plat_irq_dispatch() > Right, yeh it shouldn't technically be masked by the parent (contrary to > what I said above) because its a chained handler, i.e. as far as the > kernel knows there could be other IRQs coming through that GIC pin that > would also get masked. > > (though IIRC the perip IRQs can wake, but then they go straight out to > separate dedicated IRQ pins into the main IRQ chip, i.e. the GIC in this > case). That's right, each of the PDC peripherals (RTC, WD, IR) has a dedicated IRQ to the parent, and the sys wakes are muxed onto a single IRQ. > I think its worth understanding the root cause here though. Disabling > routing of an IRQ fundamentally should deassert it. Is it an actual > hardware bug that has reached silicon? So you think the PDC->parent IRQ must not be being de-asserted when IRQ_ROUTE is cleared?  I hadn't considered this and thought it was some persistence in the GIC due to not being masked / ack'd there.  Is that possible?  I'll discuss the possible IRQ_ROUTE issue with the hardware team. Ed.