mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: David Gow <david@davidgow.net>,
	mohammad.abukhader@hotmail.com, brendan.higgins@linux.dev
Cc: raemoar63@gmail.com, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kunit: tool: fix _list_tests filtering wrong variable when list has TAP prefix
Date: Mon, 3 Aug 2026 09:56:06 -0600	[thread overview]
Message-ID: <b8f72a24-c280-4a67-90c0-4194a81a724b@linuxfoundation.org> (raw)
In-Reply-To: <e1229319-0e28-4955-9adc-41a56f29c895@davidgow.net>

On 7/30/26 06:12, David Gow wrote:
> Le 30/07/2026 à 12:19 AM, mohammad.abukhader@hotmail.com a écrit :
>> From: Mohammad Abu-Khader <mohammad.abukhader@hotmail.com>
>>
>> `_list_tests()` runs the kernel to list tests, strips printk timestamp
>> lines via `extract_tap_lines()`, then drops the dummy TAP header from
>> the cleaned `lines`.  However the subsequent regex filter mistakenly
>> operates on the original `output` instead of the cleaned `lines`.  When
>> the kernel output includes timestamp prefixes (common with UML or slower
>> setups), e.g.:
>>
>>    [    0.100000] suite.test1
>>    [    0.100000] suite.test2
>>
>> the anchored regex `^[^\s.]+\.[^\s.]+$` rejects them and `--list_tests`
>> returns an empty list.
>>
>> Filter `lines` instead of `output`, matching the behavior of the
>> adjacent `_list_tests_attr()` which already returns the cleaned list.
>>
>> Add a regression test with timestamp-prefixed input to verify the fix.
>>
>> Fixes: 723c8258c8fe ("kunit: tool: Add command line interface to filter and report attributes")

Missing Signed-off-by

Unfortunately I can't apply this patch. Please fix it and resend.
I will try my best to get this into Linux 7.2

thanks,
-- Shuah

  reply	other threads:[~2026-08-03 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 16:19 mohammad.abukhader
2026-07-30 12:12 ` David Gow
2026-08-03 15:56   ` Shuah Khan [this message]
2026-08-03 19:02     ` [PATCH v2] " Mohammad abukhader
2026-08-12 14:36       ` David Gow
2026-08-22  8:05   ` [PATCH v3] " Mohammad abukhader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8f72a24-c280-4a67-90c0-4194a81a724b@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=brendan.higgins@linux.dev \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mohammad.abukhader@hotmail.com \
    --cc=raemoar63@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®