From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BBFC31326B for ; Fri, 17 Apr 2026 09:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776417762; cv=none; b=qYiQTQNYspT71HGeZrZe84l510p3xtFtx5WEAGFcyNFXFQTvgeSQkXxfRnhH5btEcvZe95fUCGA5nVglfWw7xXShG91eJ9hIC2DlCjrhvargQh0VAVBayT1tT4LGfQWtEFi3f/FNWmXHhHcdDPon6hZ4X7aYyfrJFP2XREMjils= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776417762; c=relaxed/simple; bh=O3zila/ZzXdCtVZV3F/hDT17khok2Nbf5KQ4nJluz7k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ej991totoBgsY3/v21bdcVx1FLL3i/eoW6QkxGv3VgkD8C0nBo4qDsNt0hkiIbxYuf1VdzEyKHNvxR9hSLo4dR+jTcHB57J/wXAg/NP2IKy8jR1el6lvYs/Y/MvetVN5fUdVSEbJrT07HlZaxB/KZl0QvJTBPizj9UNW4mFssYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kMwJZvYD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MXQM6pCp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kMwJZvYD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MXQM6pCp" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H44FeH1323229 for ; Fri, 17 Apr 2026 09:22:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 618EE27hGTuXzJEXrKjDPcINKm+g78qgGdhJxKekRlk=; b=kMwJZvYD4S0IeblN lVfexvLKXpNDL/UCANmOpZhhSKEjyW24uEbRb1AuNNiqfgtWcva8avaEF+r1eqsq 3mYcS6iNLduSsSHskOKYIw8PUhqSiAOm6a6UM11b4ZWHUBbD4ZiEn3fvYPzDDPmZ EZRh97CcMsVWDIpZQugeRZLGUUrv+5/AqmIaQiKl5ZdCVnZsn1oF+X+yI+4OXi7O IOZFOPn/2vcYw2yKUFtKGsxnm4G6n86DgMZAfAnvmGTjQA+OCyrkEXHftmcliRC1 QV9bK3Lkwf8e1ll7whTdosE2L76Bm0tmlmqgpv4r1QwHbRjR9UzykJvvk6s0CeA5 yHKdSw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkdgy1134-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 09:22:39 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c76bb22a8ceso685808a12.2 for ; Fri, 17 Apr 2026 02:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776417759; x=1777022559; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=618EE27hGTuXzJEXrKjDPcINKm+g78qgGdhJxKekRlk=; b=MXQM6pCpHIpYbydJ/rvqeybsWPrxeavjf2C6Zrudfln3VzA9e7KMDH9Vy71xvK8p8S 3gBtq9S4XwssNXIB8mS/uiVOOVvXDM9A5W9pug/uEYO4RKImP9MC+CUPHT/F/BxDAXXF z9cidh6IZzBma7ndPhJtr+8yL2UQIFrtPQ/8cCmAV4eMYqZptxKgXSUzHXEXFbx4d8wk iG2x2eRS/74T8WHFiXEayL2kkPtTKEuCh3DqI+jlqIsOcwYEXIsfHd7UKzI7h5Gc4Ur0 mBwO4MvLAHgr1+6od/B8UoeLK1xqju37BHX+IDZKhXsG9ovqTnd1Jdl1kHcN6iSsUh/f f9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776417759; x=1777022559; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=618EE27hGTuXzJEXrKjDPcINKm+g78qgGdhJxKekRlk=; b=KZHC7WgHPCNKK7HJGKQ7t15Oi1j0Izo2H9FJtcQ+8mrZtEKNy7+liwrSCCXwm8cANR msItDBUAf00iM3nxmQpPTMlMHzz6pfuUp9KJfp2c97vKgmCZoqlw+WpcJbXWKGFcW8Tu fXLhSb5MeaMuvMqYtsl5ReV+AyQO0PM66+5VT5D+Yn2f+YKTIAe0ArRWHQquf8x/Pnxo JDmJziHT94r+1zB85t6LaRzSLTaoExfFbUSStrGm9/HbFnahovg2veJHb4frxr+IhUEO SF2AKNINgAUw6t6uonWlNmmu1ISQgQddqi9AYOclJqgIuwZfqUxVPohtyuTvikWRBeMs xzRA== X-Forwarded-Encrypted: i=1; AFNElJ/Ewy1PNXeoeA3xVuDqjE9isUyGpbqv7zRjWW5zRbpLZTkRJLWH3xQgrjXV9KZaO0wAoq0o3/G0Sqs/pxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3MFBlZuFsI0CVAR/9+9SLnS3kKgZbHZbpESPjtrFlvLHcN3jl 2wsrGgDa90jvIY5j+vfdC7KTjGsw2kZXlMJWo2botbX4/rnC/bvwpdqHMn40m7jUr88aqVErXGV 0UlAxeT4GZn5R3/GMcm519RBzAcT4Z1NxDauXIEfHi5Zcv9y4OoMmQftwJJ+Hrzd5WzI= X-Gm-Gg: AeBDiesyDG3PQ1uyyIVDLlcu2x/uM/X5ZGCL7zSPKt2ZSrYAjj2gHvOxDy/+yHNfDBy k2IwAVTQqXgXvWkFJTay6SogU0I4ZQZUekn7S2M4XEN69Ugb0l8HvW5a++8nlQOZZmOjLrL3VNO JlB7oP5IdKA+2WV8Gda+M3+6QB9BVDLgSTnCduuDxpPDRuRNr3CHnmyiIMAgCZwki6kNO34kpYK AhBzZoBWF42SlQITggPHzMrYu8f/aoLk6jbJY3nZ1u/oUqt5TCQ2MNsXR/lzs7iY8X/XSElO8xE k3JUjU5UFbtykC291Hhy3h8z311a2Nr/BTuhotX8olp4a+FHw5qHgCv5igUYfcDuCBeTYiMUDIf yedQhphVyGIXsgn5PKPBXh65C7mnEpMnFj4Y634YwQA+Y7mhprslramoFYBpV3A== X-Received: by 2002:a05:6a20:3d12:b0:398:8870:b58f with SMTP id adf61e73a8af0-3a08d6eec7dmr2234618637.14.1776417759052; Fri, 17 Apr 2026 02:22:39 -0700 (PDT) X-Received: by 2002:a05:6a20:3d12:b0:398:8870:b58f with SMTP id adf61e73a8af0-3a08d6eec7dmr2234588637.14.1776417758576; Fri, 17 Apr 2026 02:22:38 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797703be34sm964756a12.26.2026.04.17.02.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 02:22:38 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 14:52:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: glymur: Add crypto engine To: Konrad Dybcio , Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: Neeraj Soni , Kuldeep Singh , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260416-glymur_crypto_enablement-v1-0-75e768c1417c@oss.qualcomm.com> <20260416-glymur_crypto_enablement-v1-2-75e768c1417c@oss.qualcomm.com> <653fc8bb-295f-4f1d-b9ac-a33e0d8a933b@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <653fc8bb-295f-4f1d-b9ac-a33e0d8a933b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9akX6YPKQIXpbI760NCh2AF3pHa-krkO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDA5MyBTYWx0ZWRfX9jFlPtcaEV+E 0x82IxCrMkIeA8sL17nYi/jb4rBcN+rexQOHfuBxEELERzXtlPIzfEQFNc6Au5ZWtZHsBepzrPK ozKJZ39nnKa1BqcIQMixFcMIrXd6q/4FVrXwO3REvbej8Bz06pDv0cYqbseVycZQdv1DfAotTZk OfBay5XnyrzCvA2gnTFJi4udZU1gPPKwRrsZ3uUsG++M0iqglBb+/TMg5FMXEwXe1jYj7TL+bG9 dyDgpbY3dEGqp9z0zQGV+RoD1X87MP605OBiHJYH7HeZ2cTvRFyo1QSAqbFw6x8f+g8jxMqMT+r rBJl31rLlVJJsdF/W+MdCHu4BPxDIaXYLz6N+5ihMHZ1ZeAW6o9SWHZNYL+FKz05O+bXIroBLvi y/QnGYuRUOEPem9CGghQCSqWZAHMysqkIeCJxYeXvp2ahaoOx8Vjiq4zkghd13CQCW2IZf5gedW v4WfBQ69tsKYMjNdC9g== X-Authority-Analysis: v=2.4 cv=GN041ONK c=1 sm=1 tr=0 ts=69e1fbdf cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=RzAiLgmaXtKTj2OvRzIA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: 9akX6YPKQIXpbI760NCh2AF3pHa-krkO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170093 Hi, On 4/16/2026 7:10 PM, Konrad Dybcio wrote: > On 4/16/26 3:07 PM, Harshal Dev wrote: >> On Glymur, there is a crypto engine IP block similar to the ones found on >> SM8x50 platforms. >> >> Describe the crypto engine and its BAM. >> >> Signed-off-by: Harshal Dev >> --- >> arch/arm64/boot/dts/qcom/glymur.dtsi | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >> index f23cf81ddb77..e8c796f2c572 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >> @@ -3675,6 +3675,32 @@ pcie3b_phy: phy@f10000 { >> status = "disabled"; >> }; >> >> + cryptobam: dma-controller@1dc4000 { >> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; >> + reg = <0x0 0x01dc4000 0x0 0x28000>; >> + interrupts = ; >> + #dma-cells = <1>; >> + iommus = <&apps_smmu 0x480 0x0>, >> + <&apps_smmu 0x481 0x0>; > > It seems like these aren't the right SIDs on this platform.. Have you > tested this patch on hw? Thanks a lot for catching this Konrad. The correct SID pairs are <0x80 0x0> and <0x81 0x0>. (I hope I don't need to pad them?) Unfortunately, I could only validate driver probe on my limited ramdisk environment: [ 4.583802] qcrypto 1dfa000.crypto: Crypto device found, version 5.9.1 I was waiting for Wenjia to run the full crypto user-space test suite once. I'll update the SIDs and wait for a Tested-by from him. Regards, Harshal > > Konrad