From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35A463DA7F6 for ; Mon, 6 Jul 2026 11:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783337155; cv=none; b=h6/LtvVgLwLDOrbqoVqLDT2Lf1PaCHmPWJIPlSoNiUTj38QrD6jFw/djGjxYrHwmx84gHHu33+mA0+FjrBej8TZJ2S08NGu/cXjVkoWrzPSnz1TqSoUvREnmhPLQ7Ae6NGUr91VbVUxI1OkLP4ktqS64cBSWXkeeKVnG70nz74Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783337155; c=relaxed/simple; bh=mZjpfXdg1eZgVj+gUu9XkiaycK799bI+POtKiloa1KE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A61KHM+FhGJZNlvymEtqqc1SC4Fh3x2Va1oyw7vIOqP7h4JH2JBuJYSPnLsXXgDFq5xGQibbM9CpJ5BWqCVdDDGrBp+hqERoTX8sv1B3yNOYGRCjIzDtOI6berkpbU+NG/qX1vaUKlUwaFtPPi+GVS6ULzNot1zCDp0Uhpt2k1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NdgyLIho; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MmoJsIiS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NdgyLIho"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MmoJsIiS" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxPGF369534 for ; Mon, 6 Jul 2026 11:25:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bKgKWQ+xIVE13CWGd/k7b98wHY3plb9noY75qci7lNY=; b=NdgyLIhogU2NCEYA yrKn37lesPgEkNl1ivWs5RCx64RhYy0A+MJrXtfOhHk/Ef+f+7zGpoTOjWqjMBWt 96Rx67tfjsq6Z8C9Q0VPPolG2wz7T7fZoNWP30Jv+xIMt4kGxU+YCmeAr2VcNmWi CHV6TNiw+rOXOT9RJcwHelXr4sdppnWX1QIPmSZESerqAMq8yfIfSeUmzhm+ue49 8qdUWN8GMLmijxhHtCqLZ1RcBGDLmYhtZ4bxo596x3fTpMsYrJMyxhqtUbMzwTDk aJ0UjilegkvvQFq/Wr+ABekVGsd5gekalEIXNQUGrGTeXrojpGLBH+oB+SJoRYYS k5l8bA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h98syg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 11:25:52 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c15c77619so6875081cf.1 for ; Mon, 06 Jul 2026 04:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783337152; x=1783941952; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bKgKWQ+xIVE13CWGd/k7b98wHY3plb9noY75qci7lNY=; b=MmoJsIiS6PrhxVTIryWrOfH3vadIOCwcjbIfxlRT3VRVdOoDNWomXslJ0mymNKNVtF bRmrseH8iMjRrTzK5OIaDC/SgQV/HnId2z2wGZozJyKMbxJugzmIdaLaPF32CL2+uoV5 V42O3fAjmmG4wB6Xi8kneJYNfznrTfKXsARBomzvzo0aoqLLf68jrKQfgk0dCwVODvuK dY5/A2Yww+0yvEsjfcbpXxdj4WrydkNQlug/puHBt5St4Mxn7lAvAdTw4tqvPHGzJ+xb EMKVcqyKDS50c0uVNmSJelRYeGw3+9jbO/iT1459c/+jI+XyyTWe2p2YfUhcYFWcjTeU N8qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783337152; x=1783941952; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bKgKWQ+xIVE13CWGd/k7b98wHY3plb9noY75qci7lNY=; b=sa9Ie5dP1bgrnJpnXAOw9NGv5pAkO7TBzU+M3w/QEI/MI3tiYxwxu51xojXQSECQJ8 HUpIbWGJDIA+VF0kHjsnjNpfg5HfTo0+vrJcOKR/pwj5+fYXFPhU69tTy51O0iehpAhs GuPuA7AQpgNdU5ggYZEA7R8o4QJDvb/12GSCfPRTtwEck9mIzImB9EEOt6WCpagjVA0C +6kYdo29Cz+u3XsgKO3D6Wqo8oNoeZyeUluC74ZlDsV1iv4tOlHmHqFo+NKMIPW2JTIe YzFigYmwCg0+PYWPV2ozUJtobZEzaBVNlEQcnxxrrPnakJwAjOl9dz39JNN0mY3FCYSf RPbw== X-Forwarded-Encrypted: i=1; AHgh+Rp2bJE01xRP7OHHk+LqB3mSPpJwwC50W+VQ4wgVwqsU1NdCOYGcuXbU5UZoV+1uV0O5zc4zCjie293yIIE=@vger.kernel.org X-Gm-Message-State: AOJu0YyYhSKnrjIF9RJEvNLzIokkW5MFunop+yW19EqxIM9Q+DhC9xp5 lyyXf7WFh8Ud5R1qoRfPo5qPCpUR5+BYgCsvtIJ7hVJf55UgtOUCVSCdl8dxBy8p6iIWohXeokN PAbSvlNujlVYFpwK1GKPcukh7J94Pg2NWmWCgl+9+y6JydWQKg35wX7gNbfKDSVgho64= X-Gm-Gg: AfdE7cl0eboayuq9m/dmWUmlYRKe61TIk5rIZjl/0e/ZxcyUaHnGgMofEQgJ+MiS1Qb X2p9iXqiaH9VsxqwSmOCvskTBJIJGrduq70rgpdDqw+nvfMo2D/0q4aOPjorV2OvM9fEgSsxwp2 HHtVC4932srAlc1Cohz/spozyEMXeSVUxj/Q+HBMTHL/iqkmTg8fjs+IYCwXGklLn8nAb8qR09L kxV662TxQY1cY9wW1AQLaQJuMoJcRf0/pzh/se7IL/qRBmZzx0o/Z/VBlI+EeS/VfnM9WJJvN4h Ax+eGXRZSdQ7CF7lomCfA1QIW4zXOlBBc0iSpbt22cNkTOJ2ij5DL3CROkn3MybjnbVMWGpkQ1Q 13p+1B+tyd5ddjQRfU5ufXRKGqNz8H41CJ4k= X-Received: by 2002:ac8:57c2:0:b0:51b:e991:92bd with SMTP id d75a77b69052e-51c4be98625mr93371131cf.7.1783337152283; Mon, 06 Jul 2026 04:25:52 -0700 (PDT) X-Received: by 2002:ac8:57c2:0:b0:51b:e991:92bd with SMTP id d75a77b69052e-51c4be98625mr93370951cf.7.1783337151785; Mon, 06 Jul 2026 04:25:51 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b629a1d4sm711584966b.39.2026.07.06.04.25.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 04:25:50 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 13:25:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] iio: adc: qcom-spmi-iadc: balance enable_irq_wake() on driver unbind To: Jonathan Cameron , Stepan Ionichev Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, hcazarim@yahoo.com, linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson References: <20260529095649.2452-1-sozdayvek@gmail.com> <20260704000415.2446940f@jic23-huawei> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260704000415.2446940f@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: kSh8YFRpXV1AWzvcHIKvO4239BnCt-_G X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDExNCBTYWx0ZWRfX9DLj8jgDbV9t wm1e70d6/4J9S6Hrl7bWfdy1fKIhfSj13SWZ0XiipxT/ZJV4aWyj/+Tudq7DSIckiU/H3vDnF0I 2NjiJgYZEOiPsUCGDuhNlQQ5xY3wYNU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDExNCBTYWx0ZWRfX6tfRRXH3sz6/ ikNx04fD9X91fjhuJG3UemhxDNk4BeXaWMyaGQ29S6IfmqaRXmDmOh6CbgUdSF6bFaf2PNTittQ pgatxLQYOmSmgVHF2QFAuuBfdBt29tNTPdneM5jtwt7ZMh9cR16KqR7t21KYCNsYl/xuB4Esle1 ElZ9MRexLgtuD501wgrasdsgXPyWC4m/6uGDnhNP1fuYNBYm08urz1rAG9TwA4shXHCjgeBn5XP kNZI/nyXh0+Oihm0IaoSUJLceq++GTOVVe625uPapwtIRS945e7hN6qwwh2zfUi70sCYqUkPQKa NhvNBigcBMFEuCpqk3rT5Es0KrEec38DWoYJ6jKHIViIT/wS4bJjeGjEjWg9M6kmh51hUbwlaSV ljxCbmNOi84FiwheyZBs/ddDQqyu7j7+hcLZ6ToutO3KY+cn+FmqpEHElEu0wC2swq36ayDar+p 7YX4TqiryukHVsK7Lww== X-Proofpoint-GUID: kSh8YFRpXV1AWzvcHIKvO4239BnCt-_G X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a4b90c1 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=FWEFCM-Gamp2U2xr488A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060114 On 7/4/26 1:04 AM, Jonathan Cameron wrote: > On Fri, 29 May 2026 14:56:48 +0500 > Stepan Ionichev wrote: > >> iadc_probe() calls enable_irq_wake() after a successful >> devm_request_irq(), but the driver has no remove callback or >> matching disable_irq_wake(), so the wake reference count on the >> IRQ is leaked on module unload or driver unbind. >> >> Check the IRQ request error first, then register a devm action >> that calls disable_irq_wake() so the wake reference is released >> in the same scope as the enable. While here, drop the inverted >> "if (!ret) ... else return ret" in favour of the standard >> "if (ret) return ret;" pattern. >> >> Fixes: ce0694841ea6 ("iio: iadc: Qualcomm SPMI PMIC current ADC driver") >> Signed-off-by: Stepan Ionichev > > +CC Bjorn and Konrad as we don't seem to have a more specific > maintainer for this driver. > > Seems low risk, but nice to run it past them. The robot pointed out to me that this makes probe fail if the irqchip isn't wakeup-capable, but it seems like that's never the case for the one that will be used (i.e. the QC SPMI bus arbiter) so: Reviewed-by: Konrad Dybcio Konrad