From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0ADCC004D4 for ; Thu, 19 Jan 2023 14:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbjASOb1 (ORCPT ); Thu, 19 Jan 2023 09:31:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbjASOaz (ORCPT ); Thu, 19 Jan 2023 09:30:55 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14ED587299; Thu, 19 Jan 2023 06:29:28 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 47BEB6600874; Thu, 19 Jan 2023 14:29:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674138566; bh=p/A/jWIk2sK78OlSgWI3fy+vpqk60q5IY/hSeAcs6AY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AksgbLzNeb2yo5Q6rWlWYXCGSsU4Pw/YGPRQEW1/m2X3nIhXkAmzKvRiJFLQkhCgb ukyskjoKouGS2gXuEQJINq9XuoH6OYZsUt9oO28COwpJ7T22eLdTZ7AmsIo2dphiBp TyPFWJflc5dKPM7QADxTaqIOOoG12xtf2fJnqz/M2MwZp7vt5ww2+qtDmThvAsL1+A aZ73cLGHN43OnZ3/21dRCEk1nfVUNkbY4RfPNxK56KRa3vWDqPI9MPhx4ahriTCyKH 8kVvCc1YbmOzwji4Zyr2Y1dyP3ZqS5tWPxRZnA4bjXC549UvdB/jdpvLWLEHtfYVdE j/yIeZyytE8Sg== Message-ID: Date: Thu, 19 Jan 2023 15:29:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] clk: mediatek: add MT7981 clock support Content-Language: en-US To: Daniel Golle , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Chen-Yu Tsai , Miles Chen , Edward-JW Yang , Johnson Wang , Fabien Parent , Chun-Jie Chen , Sam Shih , Jianhui Zhao References: From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 19/01/23 15:12, Daniel Golle ha scritto: > Add MT7986 clock support, include topckgen, apmixedsys, infracfg and > ethernet subsystem clocks. > > The drivers are based on clk-mt7981.c which can be found in MediaTek's > SDK sources. To be fit for upstream inclusion the driver has been split > into clock domains and the infracfg part has been significantly > de-bloated by removing all the 1:1 factors (aliases). > > Signed-off-by: Jianhui Zhao > Signed-off-by: Daniel Golle > --- > drivers/clk/mediatek/Kconfig | 17 + > drivers/clk/mediatek/Makefile | 4 + > drivers/clk/mediatek/clk-mt7981-apmixed.c | 103 +++++ > drivers/clk/mediatek/clk-mt7981-eth.c | 138 +++++++ > drivers/clk/mediatek/clk-mt7981-infracfg.c | 236 +++++++++++ > drivers/clk/mediatek/clk-mt7981-topckgen.c | 431 +++++++++++++++++++++ > include/dt-bindings/clock/mt7981-clk.h | 215 ++++++++++ dt-bindings go in a different commit; also, please follow binding rules for filenames... mt7981-clk.h -> mediatek,mt7981-clk.h > 7 files changed, 1144 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt7981-apmixed.c > create mode 100644 drivers/clk/mediatek/clk-mt7981-eth.c > create mode 100644 drivers/clk/mediatek/clk-mt7981-infracfg.c > create mode 100644 drivers/clk/mediatek/clk-mt7981-topckgen.c > create mode 100644 include/dt-bindings/clock/mt7981-clk.h > Moreover, I have pushed a pretty big cleanup series, which would reduce a bit the size of the drivers that you're trying to introduce, and which is well tested and reviewed: can you please rebase this on top of [1]? Thanks! [1]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=711734 Regards, Angelo