From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932807AbdHWTgr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Aug 2017 15:36:47 -0400
Received: from mout.gmx.net ([212.227.17.20]:50391 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932737AbdHWTgn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Aug 2017 15:36:43 -0400
Subject: Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF
To: Steven Rostedt <rostedt@goodmis.org>, Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
References: <20170810173533.GA11600@ls3530.fritz.box>
 <20170811001521.GA520@jagdpanzerIV.localdomain>
 <47718712-9eb2-8ad7-965e-d0971d07e985@gmx.de>
 <20170815113625.GA2738@pathway.suse.cz>
 <d5fda170-e95b-024e-59ad-650b4db78ba6@gmx.de>
 <20170823144824.GE27895@pathway.suse.cz>
 <20170823104947.3d84737e@gandalf.local.home>
From: Helge Deller <deller@gmx.de>
Message-ID: <b8fe55d6-9dfe-ee6e-8a78-357f1ba3b9a7@gmx.de>
Date: Wed, 23 Aug 2017 21:36:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170823104947.3d84737e@gandalf.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:7jHI3nz/aBTB0kY7V0Oze7oVfsz84MOjvRl0PilEo3+tIGCjnvX
 9wXjqfCZ6ioOkY6XWji4SXbv+2+uJjEuvFvUbDs8hqPiTIg5AhgVxGWwMR+uwM8z/OHseqQ
 E62mf+ae7rNlskGD75y0FLbl1quyripmMRgq6ZmMreZkXjtcjv+tWGrzNWqbBTNtCEu4JM6
 BFmPeCBpcZwc87OyEyJIQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pVAZxqeeWkk=:u92j3HFq2Jm7TriVZtiKs+
 L7NvPP6hkRH6kAm9e+YsHEXusGb+Lfux2MBtXsB82j+gU6z8Mux1YwwXa9gBpsEwyvfqMih8Q
 Fqk/KsP5EmYKxKxLZYn1+VSjZVt2QA10Y6JFH/R2job/X/cL3ofCFy13SPi+a6gXzhmMWR6eo
 v/2O7GOHNagd5MCb2R+qAyB9WmD478iZIj1c9aJdlhaIsePAbkYvABgs4zpxMfXQeKQq9+sEF
 pBmbFw9M69gCQPhLTRrVByvP8Z0zqbazmR5K24b7tQ9zaYKbfy9rFv9avH0sFwav9Dl4LWi9Q
 ismwG3jV7SPsMHU6oDY47NTyZA7c3+AuIWJdMZhw/7A6NPVb/p7/VQvMJ0J57TXkZ+iUgRzhL
 aqj5VCtedlLGWwCZ8gqUYdtV1TqKeGTb9V/pVQjtdoL47rMKijGVr71IYcIyGsDL+qeBvFWGG
 loJIDW6SVYw430sJT/4QUccw5Uc4XZur5PkBRtQLo97I/zmyP530LjYmEs6ylevUXYiyznJA2
 PyJFpuqCZlY/W+PbrT5fZGH/PiEZnJOCBSp+ucG74SCHIxGrV5DbApdI08F7744W7hzXVcxMk
 5xfP2UNurDiL4rseW7ghF6Cqeev7/I3txW8ByKt1XgTLdrMmcWwYXzto8c54KkD/V4mCjbM1h
 B2+I92Ukl5SkOQfgUkAkRjX7CjYhec6NrnHZ297GAOPi3SyObJRUDKt8Z48IzuBV3qaMp2cRA
 QXNzUpDb8XgQJYxGhKfSuN+WRbvgzixM8yC7bFjlzzfm2y5be15oepCufXamxL1l1p5INB4Wp
 g72OGufLOlWeTQpXxPdi+1h0DSc6aoqFHL8CixqGiB8Uu5xh3U=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23.08.2017 16:49, Steven Rostedt wrote:
> On Wed, 23 Aug 2017 16:48:24 +0200
> Petr Mladek <pmladek@suse.com> wrote:
> 
>> +
>> +	printk("Going to call: %pF\n", gettimeofday);
>> +	printk("Going to call: %pF\n", p->func);
>> +	printk("%s: called from %pS\n", __func__, _RET_IP_);
>> +	printk("%s: called from %pS\n", __func__, __builtin_return_address(0));
>> +	printk("Faulted at %pS\n", (void *)regs->ip);
>> +	printk(" %s%pB\n", reliable ? "" : "? ", (void *)*stack);
> 
> Much better!

Petr, that's really much better.

I've already pushed the part which restructured the text upstream.
I'll push this part of the patch (which adds the examples) for v4.14.

Thanks,
Helge