From: Paolo Abeni <pabeni@redhat.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 00/10] UDP/IPv6 refactoring
Date: Mon, 16 May 2022 15:48:27 +0200 [thread overview]
Message-ID: <b9025eb4d8a1efefbcd04013cbe8e55e98ef66e1.camel@redhat.com> (raw)
In-Reply-To: <cover.1652368648.git.asml.silence@gmail.com>
Hello,
On Fri, 2022-05-13 at 16:26 +0100, Pavel Begunkov wrote:
> Refactor UDP/IPv6 and especially udpv6_sendmsg() paths. The end result looks
> cleaner than it was before and the series also removes a bunch of instructions
> and other overhead from the hot path positively affecting performance.
>
> Testing over dummy netdev with 16 byte packets yields 2240481 tx/s,
> comparing to 2203417 tx/s previously, which is around +1.6%
I personally feel that some patches in this series have a relevant
chance of introducing functional regressions and e.g. syzbot will not
help to catch them. That risk is IMHO relevant considered that the
performance gain here looks quite limited.
There are a few individual changes that IMHO looks like nice cleanup
e.g. patch 5, 6, 8, 9 and possibly even patch 1.
I suggest to reduce the patchset scope to them.
Thanks!
Paolo
next prev parent reply other threads:[~2022-05-16 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 15:26 Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 01/10] ipv6: optimise ipcm6 cookie init Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 02/10] udp/ipv6: move pending section of udpv6_sendmsg Pavel Begunkov
2022-05-16 13:11 ` Paolo Abeni
2022-05-16 20:09 ` Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 03/10] udp/ipv6: prioritise the ip6 path over ip4 checks Pavel Begunkov
2022-05-16 13:14 ` Paolo Abeni
2022-05-16 20:10 ` Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 04/10] udp/ipv6: optimise udpv6_sendmsg() daddr checks Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 05/10] udp/ipv6: optimise out daddr reassignment Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 06/10] udp/ipv6: clean up udpv6_sendmsg's saddr init Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 07/10] ipv6: partially inline fl6_update_dst() Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 08/10] ipv6: refactor opts push in __ip6_make_skb() Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 09/10] ipv6: improve opt-less __ip6_make_skb() Pavel Begunkov
2022-05-13 15:26 ` [PATCH net-next v3 10/10] ipv6: clean up ip6_setup_cork Pavel Begunkov
2022-05-16 13:48 ` Paolo Abeni [this message]
2022-05-16 14:47 ` [PATCH net-next v3 00/10] UDP/IPv6 refactoring David Ahern
2022-05-16 20:48 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9025eb4d8a1efefbcd04013cbe8e55e98ef66e1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®