From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C792DBF76 for ; Mon, 15 Dec 2025 22:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765837201; cv=none; b=t8IyqlI0bmVem2rn+jda8WipLZYaIOqOvsEFA0JNBtCtkFOwecmSpUMVJ+SWenOr6RpN957pk/BmXVXnekZve+ikPWw/31ypRqJ09M89LhyRbKRRWn4o32EyrXg4yXzs/BIKeHoayoLJprNXA/CTzpVkrCAQTeHCY/c82pc5Xko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765837201; c=relaxed/simple; bh=ragwkO+8YLt4YZ5khq5BOCb0R+g526/QnG+GD6YmibA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iiSg8liPYHErfemE/4F4Q1Hb4WLVQUl/yAeeTkE2/DdCmq64xz+q7QZVkSxtHJiPy0Co2sVHZymfRhBxy1d+n5yamXgI5q7DRniPdakYg1qDzKdPup5QyIIUTiqYNsyif0vggfDQYDVoJUDQX0zL9qaKepQyda//8zh9LqqRKNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aJ6qlYrF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y1zJJDDb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aJ6qlYrF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y1zJJDDb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BFGiYgZ1268953 for ; Mon, 15 Dec 2025 22:19:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ihsSrburBQzQCLrZeOr5x5sV998XLhEapswC945EWi0=; b=aJ6qlYrF5F+kxK37 4jpZ/4sK2OqRkNLuabGgGSRqYmLMtSiSMXR+uz6eFyYAb+5UX/T7pcXjI4pBz+k8 2ihWtK2mL6CLIW+SjbIzd2Ck1JsUaJQnFtnmwYK0v5s+ksL9kflEWHlSI4o2atcV PYOqdCgO/eVyF65pcrcYNHpMb2EcEIUHR/pqL7LHLm36rI1rv5uLidB4ZpE2ZMnY 6MqwrFAed2E3b4cf/jQjh9wRwMgRHQhVtqqcHU9cLcpRb3pTpBJ3STQojVmUjAM0 eOnM5omyBFfPcSTiR2x1LtCGNEFGcJgn9HMhBKETIAial05+v/sW7HNoQB4OGu9r LwnhCg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b2p46gxmd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Dec 2025 22:19:58 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a07fa318fdso56484645ad.0 for ; Mon, 15 Dec 2025 14:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765837198; x=1766441998; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ihsSrburBQzQCLrZeOr5x5sV998XLhEapswC945EWi0=; b=Y1zJJDDbscQdctbYKLvjAw/tM2lZvMQiw6mlLXddpL8iOrKSZ68M36fd6JiLj24w9T xJqOrUVhAzuYM5th3LYRl/1qzvLeZRiQwDi54XkBcWeB6z12Utjv1Ui5d+KURrPRj158 7hitKPcV7aMVY07OZRSKurUirWAnwIRdrLk/fXTSWASOGJ+XGWVd20vOTe+BCae0tsio deF24RHfz/JmsBYWWQYy30v9iUhLN+EourvCoG5SkaPfoHFHpvnb1fRy6tfVGPHQNbHC vrr7HfUjHvoJsSot2QwfNENK+25Kc1/V/Riugwiv59GTajYjrNwnfV+TciMdKNl4sJZD iZ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765837198; x=1766441998; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ihsSrburBQzQCLrZeOr5x5sV998XLhEapswC945EWi0=; b=nKAuM13oQcQ6s9YHHbNnh+e1Ff9LgL4jq9cbu9nv7epOgad5F+IvWc1xyr4rD/t3Jh gcI2dF+qWuSKMBBWib56hzpnVRDTs4P6Mr9eZz8D2gZ+uH0LaAB/UOy08I44CY8c6Jvs lf93QG3K9jBeiLK1JEDdStpuxQewcI4wlGpzD0wdj1MddBE89ORExLT0A/aL0bFAohtA SmPiROMENNfBMrLNS9dPek1Zipe+BP4Ihpii61U4eScp0bFX9Qhn22jVnCWefdLYPDbR 2rJAvLYpn0tRU9JSP8+ojGhedGVziZrepNmNgmiUawyXgn/Wh5iUlun8BxIEDbOEgHhc NsCQ== X-Forwarded-Encrypted: i=1; AJvYcCXI8ehACWX4Vcl/XMtRyGQWdIIrYbRIT6Rk1fWnskaqsQq03cG3cr6iQYScfljGuf3p34u9eZKkPSaRoAA=@vger.kernel.org X-Gm-Message-State: AOJu0YxVtIkK0HBfwdww+gVr/b9UuWPi/6g7NhZumkBOXi3dskIaDrP8 S+DCuor+0cgfvJEG1n/HM4neweU/RPLHbowkckZ5vJkyV8vYrSZcjxirMVQ64vqtqp5zHKREuRa ZhoGvDW2zicS+lx0yYVgvRePWP0SFfxG95sWw8w9TMVIpas25ViZbK6NWbVfq2wxu2qA= X-Gm-Gg: AY/fxX4rqbeM1NwoOx/ocjio9fGBNZnV0hiJS6TmDa8anq8BSwU7EONoODQrmwTcqGN Fu4wBw3WiYjU3qCjGxEX5l/YvC/UHzsJ8Mvz2KMOIarITCZ6UY1y4zB5AqwPpHExtn754hF2eSc 5vWanLSIjzkbfDmdaMJ2my5WDbsEYZm1ViqIhIIZL2M9QRW0tk65Bip6jDUR8Knrvx4ICui0sps GKQssfpgOtnumQOKZZeKf6StcXzSPAklzGdkNrJsplvgtXxQkU7UPlEZoQjGheTuBEXaIzEA+bT hzpIjwzW8wnEpjD6HPFf4ANQ3/24deHiXgdC7xIr6cy6iRNI7hhLofxtjxD2AJR8fBbb1w3R9Xv pLYTxVbTr5kXh4dNIh85d9Xgbvn/CaUQUFpSLfW/X5sd+WbvskUXdxUylTAOVqGYJF23DSA== X-Received: by 2002:a05:7022:248f:b0:11e:70d8:5dbb with SMTP id a92af1059eb24-11f354760ebmr9481071c88.7.1765837197648; Mon, 15 Dec 2025 14:19:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNdW/Y+tjK5Z/LanDaZsTUxNDNJ9VP0kfwVTCegek0t8BJzH+p43HEhdFaZEWPXUXemJd4YQ== X-Received: by 2002:a05:7022:248f:b0:11e:70d8:5dbb with SMTP id a92af1059eb24-11f354760ebmr9481035c88.7.1765837196927; Mon, 15 Dec 2025 14:19:56 -0800 (PST) Received: from [10.46.163.175] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e2ffac2sm49034782c88.11.2025.12.15.14.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 14:19:56 -0800 (PST) Message-ID: Date: Mon, 15 Dec 2025 14:19:53 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] firmware: arm_scmi: Increase MAX_OPPS to 64 To: Alexey Klimov , Sudeep Holla Cc: cristian.marussi@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mike.tipton@oss.qualcomm.com References: <20251014073454.461999-1-vivek.aknurwar@oss.qualcomm.com> <6af5945e-7d5c-4596-ac42-c5898b4c49b7@oss.qualcomm.com> <20251211-masterful-caterpillar-of-love-bc2d4c@sudeepholla> <20251211-wandering-magnificent-yak-5fb19e@sudeepholla> Content-Language: en-US From: Vivek Aknurwar In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: CxW9k5WRG_50odV64ctCCaVJ0Z2urJ9- X-Proofpoint-GUID: CxW9k5WRG_50odV64ctCCaVJ0Z2urJ9- X-Authority-Analysis: v=2.4 cv=TcybdBQh c=1 sm=1 tr=0 ts=6940898e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=k9gND7Zxdg9d3DGUrpYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE1MDE5MiBTYWx0ZWRfX8WsWPXHIdAnj uzKrNdBw+EoX50jSCataRXe/ym1qbZKAIa908bViNeDPVIlhCICRLeDNfa1ETy53BN887u1lW2c 4+6EIoOOgvdkGbryox00Vug3PQX0Ru/2TqDdSK9tvMJZctQ7HWhWpH6I13xlefLYeBFfnt5ps5e HYEzW8a2Q4qyaJ633omvaq6zQT9ibq9/ZaUvv/1K/6fNw0zoE4S7O/gW+svNqwXaT87MKYpUhDc mH9c/sZAuxDDoV4+SbtVYKUjgLEPzsU3menMt3W9eOKX8+Nn0N4bZcnumWAuxC50+rLyrRN3iLk X3XZmq90HGwH9HNNyrvZ8gjMaeTilLIuV9nAtpoNC7UvFYFukmjVhUs5BAKmrNYfYZFqkM4M6cO wsFVj94cMb5VLbb2hvC7v6bFe2EPDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_05,2025-12-15_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512150192 On 12/11/2025 6:25 AM, Alexey Klimov wrote: > On Thu Dec 11, 2025 at 2:07 PM GMT, Sudeep Holla wrote: > > [..] > >>>> Ah good point on confusing commit message. I just assumed it is limitation >>>> of the implementation. I can update the log when applying. It is not spec >>>> or protocol limitation for sure. >>>> >>>> How about this ? >>>> >>>> | firmware: arm_scmi: Increase performance MAX_OPPS limit to 64 >>>> | >>>> | Some platforms expose more than 32 operating performance points (OPPs) >>>> | per performance domain via the SCMI performance protocol, but the >>>> | driver currently limits the number of OPPs it can handle to 32 via >>>> | MAX_OPPS. >>>> | >>>> | Bump MAX_OPPS to 64 so that these platforms can register all their >>>> | performance levels. This is an internal limit in the driver only and >>>> | does not affect the SCMI protocol ABI. >>>> | >>>> | 64 is chosen as the next power of two above the existing limit. >>> >>> Yeah, that sounds better :) >>> >> Thanks! >> >>> I also thought that this was a driver limitation, not the protocol/spec one >>> as stated in the original patch. >>> >>> I don't mind updating the commit message like this (but I am not the author >>> of the original patch). >>> >> Vivek, are you happy with the above edited commit message ? Yes, I’m good with the suggested commit message. Thanks for clarifying! Signed-off-by: Vivek Aknurwar > > FWIW, with updated commit message feel free to use: > > Reviewed-by: Alexey Klimov > > Best regards, > Alexey