From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71E53BB12D for ; Fri, 16 Oct 2026 06:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792133288; cv=none; b=dOi1IMWI68GHkRkToVxsNtLmQ6nxxBs/B714v5g4fp0i11rncOklGaVpzVY4AymEzfNfbTP6aY8QPyvZj6ymdy3rVIg//B+/26MhDjl3Wt77PSwL6RTSWDSZj0hYjGZjBtXytmyUfw34A5pBHy26tF4POz7xBrSJGNI79DACwmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792133288; c=relaxed/simple; bh=ArpyCUcdXnNRQly4XkQ4s9u69ZZAMn3+U1oycCt3GcU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hogBEGhXVSQlES00HiJveITSrzPegtvGrGG7AYRxp7y6co4TQ837K4DXfDV1YZnIAG/fRfCB/JMzObY5Y43u83mHB7+E7AGqlVQ2BdOJTQ2B1iQgqAnmomly3Dw7rE8zeGpoal8NA1+UyMR/i1NXO+Ech6XlAcPPW91aO/JmaAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aMaUenMM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W3lXHios; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aMaUenMM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W3lXHios" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69G44IYt3462832 for ; Fri, 16 Oct 2026 06:47:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Pz0Akbts6DsXYURHmG6DvfbIIYwLAa3UJO6NTzI6f+0=; b=aMaUenMM0yE9Z8GD VSilD5dwzySdYN3/WbxhBBK0m8yHCTstbeuzdIElOU7fuLHS63bM4BIXsZrnY7+3 aohuNchyVOgWW4shZu2qa6BXe6LV0kSem9A5Lc9yswyBmeJ6nOxDa9Shsne6D/JN X+iGQNoqKzSTIxGf7xVeI5GoAvSdiGnDlj01PNm3AiNa7P4ajFY2EyQ44xkUOguy 7rbOL5B1z6aYL0Vd72qrMbwJdlKAyfKxnf7EPLRhkp20fXXEG51g2mEiqQARLbyv NYBtWhWZhg6S4388hHAhUeCZlzu/YTHkf/pAI0lMJyv03Uaq4/GHZY/JNToq2zep f/lOlg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hayu6bjkk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Oct 2026 06:47:59 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3ab868fe362so8205709a91.2 for ; Thu, 15 Oct 2026 23:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792133278; x=1792738078; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pz0Akbts6DsXYURHmG6DvfbIIYwLAa3UJO6NTzI6f+0=; b=W3lXHiosbgUJh9nEiqBuCdR9tz5iX4WNdv/lQBp/zhytqZeADlTOHFqNZDbYq18Wza j+OLoVAITyRzBGUI3Udriv0C2n8SIgzRmdApCc6gC9a3tzgY84YUP7yc9ddSfWfEJRLL dnW0TH+nTsUX+HZ05e7+Ze5vRvkqRnXgvWuEuVXljjZ7388uC8I9cu1h7UUrFk438Sgo kpNRieHXycEtUclmjbYpnVTmy3aOy5pB3YBrbTyDYD03YEWDJ+fi0aZVpJs4Ov4f6Kfn uL1oeOo0kcmG/lNQJIkCuYbIUx3kPmiCu/vaXlIPwYuqCyxlvPEkPZW7RnKjRcz+aY3Y UD9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792133278; x=1792738078; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pz0Akbts6DsXYURHmG6DvfbIIYwLAa3UJO6NTzI6f+0=; b=c7fVHMBiWQrZaFVn1dm6ATpLHF8k2R2os8fjdlJ14u1b01S97YuGwApOTtiJXhMk5t IH1h9Lw4qBmyh+HvxbRa6tLvuRaH71Xl1EUtcy5ykQDOks6MxHLFF2uOzWPymwQIPeW8 Hjpcr+BJDMHKXOvsuKnzn61D877ijGDrZd31Mv8/orcS2S646gseDsSUoxQTm/wyrPAs kSeVMNcfcSCZli8THaMwfHsGoMWrBloxL1dt/JnLZ6RQNwzqx072tOXLLXB2i5lgUIln 89YvRseoRRuQ2iWeVaVbpWc8uBUG7zMC9w9/p4EOVGzmD0tK7KOIc//zGRpA577I8jFG x4TA== X-Forwarded-Encrypted: i=1; AKwUvByn1W/elioSyDZ5itavUHOfYLDUDbeT/ZQZo+31yqr3I9/18WuH7oPONMc5+d3sApaxJCeCmqIgy5tLJU4=@vger.kernel.org X-Gm-Message-State: AFq9FYJzDsaR2trh8AD5y5hVERvBifveA22OGab6Ve66aPFhBj0Xhp00 pw11WAYg9kyhmbwU8lDr0emErpCNuJs5QdMRqxIrGSDNvYTnkSAWqdiYxe9NkuCf3zoWs3LcPOU cheCvDu5kDHNX4hK4H+16pErKM3uny+0zyx1GY1oJZ895OH6nP7GVIfZF5SM/tpZRVBU= X-Gm-Gg: AYBFou2/pZS+/LOvrhh5xOunQOUB+6aaIMEMUw/rHST6pfIYy9wO+G0dj7iwWremaKM ZHXynI3Ayii95e30n9DNsmhJok1tkohkyez+qe+sGVH/XhjhVk5J4W93OguY6V1A8uWSdbCqzXq vyGyxxgiUQNWboOTdEIzc1v7/g1++SUpLz57udiiYciBDW5TFy/9hS+0ycQUl4dARBIQ35YqrVn RqfkBvWgwKY1b9O+tyCbDgV2dLfR5K6TLUeqAH8hsFbwDvHRCwggQgg3KR4Dh9RoPZpfKxK464V gq6nwQHji1zEHCKXNrAINHAzIrGP+Y2v/7EWlRUSo6yPwvTUtnLXYCWjJg3QuWWmgbREok+qS0o wkiqs7eOHne8XQwucJif/K51SLK8= X-Received: by 2002:a17:90b:4d0f:b0:3ac:97e3:73a3 with SMTP id 98e67ed59e1d1-3ac97e3ca4bmr4148852a91.6.1792133278241; Thu, 15 Oct 2026 23:47:58 -0700 (PDT) X-Received: by 2002:a17:90b:4d0f:b0:3ac:97e3:73a3 with SMTP id 98e67ed59e1d1-3ac97e3ca4bmr4148830a91.6.1792133277770; Thu, 15 Oct 2026 23:47:57 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3acc487e509sm2669257a91.9.2026.10.15.23.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 23:47:57 -0700 (PDT) Message-ID: Date: Fri, 16 Oct 2026 12:17:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] ASoC: dt-bindings: qcom,pm4125-codec: Add the MBHC jack properties To: Mohammad Rafi Shaik , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexey Klimov , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ajay.nandam@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com References: <20261015-pm4125_mbhc_support-v1-0-8bc1212db6f7@oss.qualcomm.com> <20261015-pm4125_mbhc_support-v1-1-8bc1212db6f7@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <20261015-pm4125_mbhc_support-v1-1-8bc1212db6f7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NlWeOceDK9c9wvUvVuHQkKl3X4IctT5M X-Authority-Analysis: v=2.4 cv=ff04WEQF c=1 sm=1 tr=0 ts=6ad1c89f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=xz_OTyItpRnlL1KGmssA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: NlWeOceDK9c9wvUvVuHQkKl3X4IctT5M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDAyNiBTYWx0ZWRfXwkIDyUpUBmyH bPrMuTAWgLL8QDuB0MeGXfdbk2d/EVqjQcvdj1/niN364waD0Muu4fIVcLTFmYTi4t4vhJJhjed //3OcAPw92ihWcchkBt1i26U6AlUPLZCuheG3eSzyiDBc3Ald1i/2Zyk9Bz8gLH+VaAs+05kwMS MoskFF9oU72pYS8ci6xmgguTDbJlsWYNkTIdVeHUbidhISJLVr1fhF7vrYBKGuB71wscZmN5QwR meGH0qJ+yBH4quF8C4l4s8bbF6F5v6vRcYnIEi+KIIak5IzR6kN7ZYMO9EQLy5b1hVbmabciJv9 k+svgK2tsRQ9o7PhAjy3eBg7H6qoG0ILkNqqz9cWS2GAAeAsszcI649KHFRkr+RPsemXb0ghHz8 gWpGXzVbcHdBWItPRtz549ppc2nl2I+zuVjrZ7tE/oLXspHB853lr6XxD4mYjPiCfe2NltwA7XQ SglOEBelCl/De2RUFNQ== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDAyNiBTYWx0ZWRfX47SgX4SNpufP 1iHsrkx2BdJ6McTHxPTKQklyGx5yPLViy4wudLfqpI8DVyxk3uyVnFxBXiUgAohzu6/74FOQr5A XJva9chC5//apLd5MBKQl1XAqX5GHOo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610160026 On 10/15/2026 7:43 PM, Mohammad Rafi Shaik wrote: > The binding already describes qcom,mbhc-buttons-vthreshold-microvolt, > but not the rest of the data the MBHC block needs to detect a 3.5mm > jack, even though wcd_dt_parse_mbhc_data() reads all of it from the > codec node and the schema has unevaluatedProperties set to false. A > board that describes its jack is therefore rejected by the schema. > > Document the remaining four properties, matching the descriptions used > for the same properties in qcom,wcd93xx-common.yaml: > > - qcom,hphl-jack-type-normally-closed and > qcom,ground-jack-type-normally-closed describe the board's jack > switches. The MBHC logic has to know the idle state of the HPHL and > ground switches to tell an insertion from a removal. > - qcom,mbhc-headset-vthreshold-microvolt and > qcom,mbhc-headphone-vthreshold-microvolt are the ADC thresholds that > separate a headset from a headphone and a headphone from a floating > jack. They are board specific because they depend on the jack > wiring and on the microphone bias voltage they are measured against. > > All four stay optional, as they are for the wcd93xx codecs: the driver > derives the thresholds from the microphone bias voltage when they are > absent and assumes normally open switches, so existing device trees > keep working unchanged. > > Assisted-by: Claude Opus 5 > Signed-off-by: Mohammad Rafi Shaik > --- > .../devicetree/bindings/sound/qcom,pm4125-codec.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml b/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml > index 6e2f103be..54e5b7607 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,pm4125-codec.yaml > @@ -64,6 +64,24 @@ properties: > minimum: 1800000 > maximum: 2850000 > > + qcom,hphl-jack-type-normally-closed: > + description: Indicates that HPHL jack switch type is normally closed > + type: boolean > + > + qcom,ground-jack-type-normally-closed: > + description: Indicates that Headset Ground switch type is normally closed > + type: boolean > + > + qcom,mbhc-headset-vthreshold-microvolt: > + description: Voltage threshold value for headset detection > + minimum: 0 > + maximum: 2850000 > + > + qcom,mbhc-headphone-vthreshold-microvolt: > + description: Voltage threshold value for headphone detection > + minimum: 0 > + maximum: 2850000 > + > qcom,mbhc-buttons-vthreshold-microvolt: > description: > Array of 8 Voltage threshold values corresponding to headset The binding documents 8 button thresholds, but looking at the PM4125 register definitions I only see threshold registers for BTN0 through BTN4. The following registers are MICB2_RAMP, MBHC_CTL_1 and MBHC_CTL_2. Am I missing how thresholds for buttons 5-7 are programmed here, or should PM4125 only expose 5 button thresholds? Thanks & Regards Ajay kumar Nandam >