mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <quadros.roger@gmail.com>
To: broonie@opensource.wolfsonmicro.com
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org
Subject: regulator: adding enable control to fixed regulator interface
Date: Thu, 30 Jul 2009 15:20:24 +0300	[thread overview]
Message-ID: <b90c0690907300520t1dfbd722j73417b1beb6992bc@mail.gmail.com> (raw)

hi Mark,

I have the following use-case scenario for a fixed voltage regulator.


Supply ----->| Regulator |-------> Peripheral

                  ^ EN
                  |
GPIO -------------


The regulator's enable pin is controlled by a GPIO of the CPU.

What is the best way to implement this within the regulator framework?
Writing a regulator driver is one solution but I'm sure there must be
many instances like this and writing a driver for each case is not
that nice.

I want to use the fixed regulator driver but this does not have
regulator enable/disable control.

Isn't it a good idea to have enable/disable control for the current
implementation of the fixed voltage regulator i.e. drivers/regulator/fixed.c ?

The regulator enabling/disabling functionality can be implemented by
platform code and the required function pointers could be passed through
fixed_voltage_config structure.

If this looks OK, I can send you a patch to implement this functionality.

cheers,
-roger

             reply	other threads:[~2009-07-30 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 12:20 Roger Quadros [this message]
2009-07-30 12:36 ` Mark Brown
2009-07-30 12:52   ` Roger Quadros
2009-07-30 12:55     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b90c0690907300520t1dfbd722j73417b1beb6992bc@mail.gmail.com \
    --to=quadros.roger@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®