From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbZGaOWE (ORCPT ); Fri, 31 Jul 2009 10:22:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750863AbZGaOWE (ORCPT ); Fri, 31 Jul 2009 10:22:04 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:56903 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbZGaOWC (ORCPT ); Fri, 31 Jul 2009 10:22:02 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YpiQOAq6rdC/iCF3984ZKq8aGzO8AwYsi+yClL75ptwvbNazVcfqGzV/PNuNucxXy5 Wu6pqVeHjod8e35zEM4qdK01fXQaZIy94DZznqUSkPCna6Gc2xWvqZZLnW8xP+6Hv93w ftYbyElNlamrC2HE4uYvHs3+et33A9FBIJkxA= MIME-Version: 1.0 In-Reply-To: <20090731141547.GA6505@rakim.wolfsonmicro.main> References: <1249044918-695-1-git-send-email-quadros.roger@gmail.com> <20090731131005.GE17091@sirena.org.uk> <74d0deb30907310625u128ea22cu6fecca53c4a23d40@mail.gmail.com> <20090731133437.GF17091@sirena.org.uk> <20090731135036.GA626@rakim.wolfsonmicro.main> <20090731141547.GA6505@rakim.wolfsonmicro.main> Date: Fri, 31 Jul 2009 17:22:01 +0300 Message-ID: Subject: Re: [PATCH] regulator: Add GPIO enable control to fixed voltage regulator driver From: Roger Quadros To: Mark Brown Cc: pHilipp Zabel , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2009 at 5:15 PM, Mark Brown wrote: > On Fri, Jul 31, 2009 at 05:13:23PM +0300, Roger Quadros wrote: > >> OK I got what you meant now. If we use the use_gpio_enable flag then there would >> not be any problem even if GPIO is set to 0 ignorantly. Because in >> that case use_gpio_enable will >> also be set to zero. >> So, I feel we should keep use_gpio_enable as it is in the original patch. > > There's no in-tree users to care about and the use_gpio_enable thing is > just ugly - it's not worth carrying it around for ever just for this. > OK. I will remove use_gpio_enable then.