From: Roger Quadros <quadros.roger@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: pHilipp Zabel <philipp.zabel@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage regulator driver
Date: Sat, 1 Aug 2009 08:57:43 +0300 [thread overview]
Message-ID: <b90c0690907312257u7a2677f0ne20d85ebaabc3935@mail.gmail.com> (raw)
In-Reply-To: <20090731214401.GC6335@sirena.org.uk>
On Sat, Aug 1, 2009 at 12:44 AM, Mark
Brown<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Jul 31, 2009 at 11:32:32PM +0300, Roger Quadros wrote:
>
>> Not having gpio_get_direction() in gpiolib is a limitation I think.
>> Can we just do the following for now ? (i.e. disable regulator by default)
>> Will there be any glitch? If yes, then how?
>
> If you're going to do this then like I say you should make the default
> state controllable by platform data. If we unconditionally disable the
> regulator then if, for example, the regulator is controlling the display
> backlight and it's on when Linux get controls then the user will see the
> backlight blink off then on during startup.
>
OK I will add another bit for this in fixed_voltage_config.
Do we need to check whether CONFIG_GPIOLIB is available? or do we need
to explicitly
select it in Kconfig?
next prev parent reply other threads:[~2009-08-01 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 16:19 Roger Quadros
2009-07-31 17:01 ` Felipe Balbi
2009-07-31 17:03 ` pHilipp Zabel
2009-07-31 17:20 ` Mark Brown
2009-07-31 17:38 ` pHilipp Zabel
2009-07-31 20:32 ` Roger Quadros
2009-07-31 21:44 ` Mark Brown
2009-08-01 5:57 ` Roger Quadros [this message]
2009-08-01 9:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90c0690907312257u7a2677f0ne20d85ebaabc3935@mail.gmail.com \
--to=quadros.roger@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®