From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E778F1F37B0 for ; Thu, 16 Jan 2025 13:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737034864; cv=none; b=pMvVqTzcbEu80mLzLV8vwLcwP1P/MjIyeY/r2TBAkW0HK5aYGXkPT0DWbESokSR76IVPaVxDxcSiSYQNLUB9qUyANIoMgL4NgxUX94bCnd2dCxJkV4GBTHZLNbaVx8OQUJ1oq8++/Ypk9uHJgaftv+DP52SqC2QAKdJAKKBKzYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737034864; c=relaxed/simple; bh=RHFOBtWCmvV7lPztg0dWQrc6RBt+/NMmdmKKcaVtJYQ=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=eI7n1OBfSK+VPpRHFx5EFghfCZ6BZfiQvbAdy6WHhVV4ceIakiDP5XQUj/ZFgYCrgZZTUWyopE//0uNscj2YQuPLxBaeXSBc8umjUrkBHxqXJNQClw9K53Tufo13RTcYhE6gUdFSbRAsLYzO90X0ZdVdH9w1PZxhvPdn0H82ugQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XNjTIsE+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XNjTIsE+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737034861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n3VCOL0D78vqUW2184mv6wyBzLiBmr3jrjU49FJv374=; b=XNjTIsE+ecXswIlX5U22X8gFivGv1CMPdaOg2U4BnDccJvL8zIN05jq9S3naBKuoFea6sH tIVnnQdNlc8sFJfULxY1YUH1pGECdkDGCPRvyPaDslwzv9pj66Rts2hhv2cpbeUArDqNom JQgbq58heRhchKZWPL5e7CEW5XS/D8o= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633--K2bKqDCOzWKOstYKcH8vQ-1; Thu, 16 Jan 2025 08:41:00 -0500 X-MC-Unique: -K2bKqDCOzWKOstYKcH8vQ-1 X-Mimecast-MFC-AGG-ID: -K2bKqDCOzWKOstYKcH8vQ Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2163dc0f5dbso19304185ad.2 for ; Thu, 16 Jan 2025 05:41:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737034859; x=1737639659; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n3VCOL0D78vqUW2184mv6wyBzLiBmr3jrjU49FJv374=; b=gs1qXUXORjSXMm8TCFwzgkBxnrj6zOXcHVwtsNFtDMsGPGOCAtXzfJS4VyzbLNzh5o jJypvtrgeTMw2pVmnkqjNl0yP9/h2M2+KYTz/Ga0t2qzUTqV5H0jGd4gOTapuCWOwINs 2F03aGJQC1LO/k/g+Yl3joxzKELr7I+vzj3OFnRdBgedkWVqwYQYGikre/4ZlwLRJxQ8 gUpulJR4NjDbH1vQCo5foT0sXJ2y4aSIrlsd8Wc5/Jsz/VIOsjaifJ7nqtCxunwHtyXq Kg8LcmjUXdVbZtOoAd59S/HtFKMH3EM+hunzHcIsbDDV99GBfNUSJsE1VJssjSHVC0cp MWvw== X-Forwarded-Encrypted: i=1; AJvYcCWxjv9ZIXtwLaZf8d6db5BWElxpCLeZVwvT1Xib+mScqbtphNLJpINJv3oIXP2D8Y1DpLC/8CJASnFr2j8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3rqinqq8V3OK0HDsrS3CTHCFrtvJvRmu2HDm02dmfnxPiz+w0 ItvojE4KENvwplAFEVscWbQQ07hJCtw5B6E2Nz+qNSg89tT1Jro0ODBYZT5PLv6pcDmfRC7Q8Gf w19rXsz7IVAX/tZF1yUmh+DEY62xdsukH3jYNWDJ5vqW0PNCOg4pgh5WAKfyvmJUN/s8x4g== X-Gm-Gg: ASbGncs17YDj24Qz2NTRuHkflnaN6LFzG81WKtSh90MmUlzG4/bRrVMFzT+VpGQ5iLi hStpS/Vsb/uffY+RpIRudcBwLBGasrOaQJWvW+zRug9F4zVO3B3Mipt4d2EAlyfifXYKy08Wouh u2XO0RzkEdqhKp/Rr2u4jnTu3ObvbMksMmrchSStceZCSVEij5BLKBnVllzc46vYLz/rTM+vYFT WG8yIBylMr+8/pM3sZ/A5de9KVLGMRExn1JL1GcawXMMtHsx1+J/YNgkM2AHvj7lDF4pyVwdayD vLBtlm0D5YvLWqYa6X2IWZU9FGs= X-Received: by 2002:a17:902:f551:b0:216:46f4:7e30 with SMTP id d9443c01a7336-21a83fc6d98mr536111245ad.43.1737034859242; Thu, 16 Jan 2025 05:40:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSXRMV2P6Rpc0zdlVDQcdVEqMlCGxhwufQY94QDMEqPWCar0YzrlSDhf6sPLgmUiQMoissrw== X-Received: by 2002:a17:902:f551:b0:216:46f4:7e30 with SMTP id d9443c01a7336-21a83fc6d98mr536110935ad.43.1737034858898; Thu, 16 Jan 2025 05:40:58 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:315f:57b3:b997:5fca? ([2601:188:c100:5710:315f:57b3:b997:5fca]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2cd609aesm634605ad.0.2025.01.16.05.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 05:40:58 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Thu, 16 Jan 2025 08:40:56 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Tejun Heo , Johannes Weiner , Chen Ridong References: <20250116095656.643976-1-mkoutny@suse.com> Content-Language: en-US In-Reply-To: <20250116095656.643976-1-mkoutny@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/16/25 4:56 AM, Michal Koutný wrote: > The cpuset file is a legacy attribute that is bound primarily to cpuset > v1 (and it'd be equal to effective /proc/$pid/cgroup path on the unified > hierarchy). > > Followup to commit b0ced9d378d49 ("cgroup/cpuset: move v1 interfaces to > cpuset-v1.c") and hide CONFIG_PROC_PID_CPUSET under CONFIG_CPUSETS_V1. > Drop an obsolete comment too. > > Signed-off-by: Michal Koutný I do have some reservation in taking out /proc//cpuset by default as CPUSETS_V1 is off by default. This may break some existing user scripts. Also the statement that the cpuset file is the same as the path in cgroup file in unified hierarchy is not true if that cgroup doesn't have cpuset enabled. Cheers, Longman