From: Shuah Khan <shuah@kernel.org>
To: Fathi Boudra <fathi.boudra@linaro.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests: keep consistency for uname -m usage
Date: Wed, 15 Mar 2017 09:56:16 -0600 [thread overview]
Message-ID: <b90d4cbf-bc2b-7429-9291-5223734c7f8b@kernel.org> (raw)
In-Reply-To: <20170315131535.11438-1-fathi.boudra@linaro.org>
Hi Fathi,
On 03/15/2017 07:15 AM, Fathi Boudra wrote:
> powerpc selftests allow to override ARCH for cross-compilation by making
> the first ARCH assignment weak.
> Use the same approach in breakpoints, ipc and prctl tests to:
> - keep uname usage consistent across selftests
> - make it easier to cross-compile
How does it make it easier to cross-compile? Could you please
elaborate on what this patch is fixing?
Also I would like to see 3 separate patches one for each
of the tests?
thanks,
-- Shuah
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 4 ++--
> tools/testing/selftests/ipc/Makefile | 4 ++--
> tools/testing/selftests/powerpc/Makefile | 2 +-
> tools/testing/selftests/prctl/Makefile | 4 ++--
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..9d5a1af4b5c9 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -1,6 +1,6 @@
> # Taken from perf makefile
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> +ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> ifeq ($(ARCH),x86)
> TEST_GEN_PROGS := breakpoint_test
> diff --git a/tools/testing/selftests/ipc/Makefile b/tools/testing/selftests/ipc/Makefile
> index 30ef4c7f53ea..7e5a459842bb 100644
> --- a/tools/testing/selftests/ipc/Makefile
> +++ b/tools/testing/selftests/ipc/Makefile
> @@ -1,5 +1,5 @@
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> +ARCH := $(shell echo $(ARCH) | sed -e s/i.86/i386/)
> ifeq ($(ARCH),i386)
> ARCH := x86
> CFLAGS := -DCONFIG_X86_32 -D__i386__
> diff --git a/tools/testing/selftests/powerpc/Makefile b/tools/testing/selftests/powerpc/Makefile
> index 1c5d0575802e..731e015d170d 100644
> --- a/tools/testing/selftests/powerpc/Makefile
> +++ b/tools/testing/selftests/powerpc/Makefile
> @@ -1,7 +1,7 @@
> # Makefile for powerpc selftests
>
> # ARCH can be overridden by the user for cross compiling
> -ARCH ?= $(shell uname -m)
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> ARCH := $(shell echo $(ARCH) | sed -e s/ppc.*/powerpc/)
>
> ifeq ($(ARCH),powerpc)
> diff --git a/tools/testing/selftests/prctl/Makefile b/tools/testing/selftests/prctl/Makefile
> index 35aa1c8f2df2..08aeb8721ce6 100644
> --- a/tools/testing/selftests/prctl/Makefile
> +++ b/tools/testing/selftests/prctl/Makefile
> @@ -1,6 +1,6 @@
> ifndef CROSS_COMPILE
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> +ARCH ?= $(shell uname -m 2>/dev/null || echo not)
> +ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> ifeq ($(ARCH),x86)
> TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \
>
next prev parent reply other threads:[~2017-03-15 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 13:15 Fathi Boudra
2017-03-15 13:15 ` [PATCH 2/2] selftests: lib: add config fragment for bitmap, printf and prime numbers tests Fathi Boudra
2017-03-15 15:56 ` Shuah Khan [this message]
2017-03-17 12:48 ` [PATCH 1/2] selftests: keep consistency for uname -m usage Fathi Boudra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90d4cbf-bc2b-7429-9291-5223734c7f8b@kernel.org \
--to=shuah@kernel.org \
--cc=fathi.boudra@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®