Re: [PATCH v2 1/3] arm64: dts: qcom: sc7280: Add memory region for audiopd

[Ling Xu <quic_lxu5@quicinc.com>]

在 5/17/2025 5:47 AM, Dmitry Baryshkov 写道:
> On Fri, May 16, 2025 at 04:30:27PM +0530, Ling Xu wrote:
>> Add reserved memory region and VMIDs for audio PD dynamic loading and
>> remote heap memory requirements.
> 
> Why? Was it not working without this heap?

yes, it will not working without this heap.
Memory region is required for audio PD for dynamic loading and remote heap memory
requirements. For more info, please refer below patches, it has provided a more
detailed explanation.
https://lore.kernel.org/all/bb68da04-ef52-4172-8b6e-f4027bcc2786@oss.qualcomm.com/
https://lore.kernel.org/all/effea02f-6ffb-42e9-87df-081caafab728@oss.qualcomm.com/

>>
>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 8e86d75cc6b4..d9af79ff8c4e 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -188,6 +188,14 @@ rmtfs_mem: rmtfs@9c900000 {
>>  			qcom,client-id = <1>;
>>  			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
>>  		};
>> +
>> +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
>> +			compatible = "shared-dma-pool";
>> +			size = <0x0 0x800000>;
>> +			alignment = <0x0 0x100000>;
>> +			alloc-ranges = <0x0 0x80000000 0x0 0x40000000>;
>> +			no-map;
>> +		};
>>  	};
>>  
>>  	cpus {
>> @@ -3863,6 +3871,9 @@ fastrpc {
>>  					qcom,glink-channels = "fastrpcglink-apps-dsp";
>>  					label = "adsp";
>>  					qcom,non-secure-domain;
>> +					memory-region = <&adsp_rpc_remote_heap_mem>;
>> +					qcom,vmids = <QCOM_SCM_VMID_LPASS>,
>> +							  <QCOM_SCM_VMID_ADSP_HEAP>;

Thanks. Will modify this.

> Please align '<' vertically.
> 
>>  					#address-cells = <1>;
>>  					#size-cells = <0>;
>>  
>> -- 
>> 2.34.1
>>
> 

-- 
Thx and BRs,
Ling Xu