From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E344C433B4 for ; Fri, 9 Apr 2021 09:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E848A61181 for ; Fri, 9 Apr 2021 09:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbhDIJbB (ORCPT ); Fri, 9 Apr 2021 05:31:01 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16116 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232435AbhDIJbB (ORCPT ); Fri, 9 Apr 2021 05:31:01 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGt9G3zxyz19L8g; Fri, 9 Apr 2021 17:28:34 +0800 (CST) Received: from [10.67.101.248] (10.67.101.248) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:30:40 +0800 Subject: Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log To: Herbert Xu References: <1617362669-40372-1-git-send-email-tanghui20@huawei.com> <20210409073334.GC23134@gondor.apana.org.au> CC: , , , , From: Hui Tang Message-ID: Date: Fri, 9 Apr 2021 17:30:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210409073334.GC23134@gondor.apana.org.au> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.101.248] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/9 15:33, Herbert Xu wrote: > On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote: >> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not >> necessary to do it here, so remove it. >> >> Signed-off-by: Hui Tang >> >> v1 -> v2: >> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero. >> --- >> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Your patch description is misleading as the patch does moe than > just remove the redundant printk. Please rephrase so that it is > clear that the patch is in fact changing behaviour. Okay, I will fix it in next version. >