From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CB4C1F6686 for ; Fri, 17 Jan 2025 07:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737097885; cv=none; b=cHnGsWoMPMCQPCdB6B6NyWtwOwwXiOt9eBh9wQtRjGu4xSkyN9CpfW71u7g5bHzaansWWW712EEwxc/JJN+6D8IjQ3XzS+tiXv0WeiV5Ua0i5aqKk1U98rWD1/OYFJz62M4EFkFf1orV+2DO//ZmPGenlLliFdHVZvMvGqrVY9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737097885; c=relaxed/simple; bh=hzte2wTrkSE34apta9YAEosoTN+5mJXqXtRH8BFM+Uo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XiHeF591UEoif2cTcnrQDd6BETo2IUV/nM+ozwg3kxyjUWhHd1RF03Mk7KsB03FQNOE33FKD4J+YB70mVpChzTGrwa/rwcLsGEQevupFjWQsu02Lco0b1fjg6cAoNwdSUUDUEHUWULIT2Smc/bY5OZnOhB9nbf9gteCrACkl8Ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=Xwx8Ito7; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Xwx8Ito7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hx7gcyBRkr02GwpB84Wrp3BEHIxKM75q1Yh2wv9Tlzg=; b=Xwx8Ito7r6oUw+qGXO3MaHpg0Z fgERcqWyNo93kvBmr5u149lBL9GVYdMgOWQJdTPVhx9tLR4o+xej+bWeqLyTSuUxdqVEQBPjslbvn vNOBIIUsrdRVlliYgAdOsg4ILgKRc69TGVg5e4jML/2qCRxHYb83TbijNE0mXehctdEptYu+qI1yi egdjeCQZF9urfJRFkj4d/qjFuXXWt4DhPejY+9Rzk0Fr583KC2WS7sDDu6JjmXgAlKORdsoSDOr/4 Gn8YZiq/ifKyjAAJqrNTRpvL9ZFVEWMdr5OPOYWsBApcZoUvetr1wyWteXtgSh1wx4PnXk2YuShWy xAh9HojA==; Received: from [58.29.143.236] (helo=[192.168.1.6]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tYgVh-00H6d0-54; Fri, 17 Jan 2025 08:11:17 +0100 Message-ID: Date: Fri, 17 Jan 2025 16:11:10 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] sched_ext: Add an event, SCX_EVENT_OFFLINE_LOCAL_DSQ To: Tejun Heo Cc: void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org References: <20250116151543.80163-1-changwoo@igalia.com> <20250116151543.80163-3-changwoo@igalia.com> From: Changwoo Min Content-Language: en-US, ko-KR, en-US-large, ko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 25. 1. 17. 10:37, Tejun Heo wrote: > On Fri, Jan 17, 2025 at 12:15:38AM +0900, Changwoo Min wrote: > ... >> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c >> index 7e12d5b8322e..8054e4e5ed0c 100644 >> --- a/kernel/sched/ext.c >> +++ b/kernel/sched/ext.c >> @@ -1467,6 +1467,12 @@ struct scx_event_stat { >> * the core scheduler code silently picks a fallback CPU. >> */ >> u64 INVAL_SELECT_CPU; >> + >> + /* >> + * When dispatching to a local DSQ, the CPU may have gone offline in >> + * the meantime. In this case, the task is bounced to the global DSQ. >> + */ >> + u64 OFFLINE_LOCAL_DSQ; > > Let's do components in descending order + event: > > - SELECT_CPU_INVAL (or SELECT_CPU_FALLBACK) > - DISPATCH_LOCAL_DSQ_OFFLINE Sure. Will change it in the next version. Regards, Changwoo Min