mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Cc: clang-built-linux@googlegroups.com
Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;
Date: Sun, 08 Mar 2020 12:44:44 -0700	[thread overview]
Message-ID: <b934b12940ab50218be3b7c5d1b98f5d4f24a1fd.camel@perches.com> (raw)
In-Reply-To: <7a0a3e7b-9c76-22f8-8dbf-acd9960d7950@embeddedor.com>

On Sun, 2020-03-08 at 14:14 -0500, Gustavo A. R. Silva wrote:
> 
> On 3/8/20 03:58, Joe Perches wrote:
> > On Sun, 2020-03-08 at 01:11 -0600, Gustavo A. R. Silva wrote:
> > > On 3/8/20 01:02, Joe Perches wrote:
> > > > > or if you are suggesting that
> > > > > the maintainers will have the predisposition of applying
> > > > > patches that will modify their coding style and then go and
> > > > > willingly fix that. I doubt the latter, though.
> > > > 
> > > > If any do actually use the script, I guess we'll see.
> > > > 
> > > Yep. In the meantime is a NACK from me for this version
> > > of your patch.
> > 
> > Generic code reformatters of comments to code are not
> > particularly common.
> > 
> 
> It's no a matter of
> reformatting something. It's the opposite, it's a matter of
> not messing (removing existing blank lines) with the current
> format and merely focusing on replacing comments.

You are not correct in your assumption.

This is precisely reformatting of comments to code.

Nor are you correct in what appears to be your
general point.  It's quite fine to reformat comments
for consistency.



  reply	other threads:[~2020-03-08 19:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 20:30 Joe Perches
2020-02-21  0:21 ` Andrew Morton
2020-02-21  2:24   ` Joe Perches
2020-03-09 19:36   ` Nick Desaulniers
2020-03-09 19:55     ` Joe Perches
2020-03-07 21:30 ` Gustavo A. R. Silva
2020-03-08  3:01   ` Joe Perches
2020-03-08  6:46     ` Gustavo A. R. Silva
2020-03-08  7:02       ` Joe Perches
2020-03-08  7:11         ` Gustavo A. R. Silva
2020-03-08  8:58           ` Joe Perches
2020-03-08 19:14             ` Gustavo A. R. Silva
2020-03-08 19:44               ` Joe Perches [this message]
2020-03-08 22:04                 ` Gustavo A. R. Silva
2020-03-08 22:05                   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b934b12940ab50218be3b7c5d1b98f5d4f24a1fd.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®