From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012055.outbound.protection.outlook.com [52.101.53.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9034B04B9 for ; Mon, 17 Aug 2026 07:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952166; cv=fail; b=HiXnowXZ6cLjf0CkirhZ2DplDb4o2kD8V9/YxGADINsNKjytV+mNfQxm9IDZ357I0KXJRuv435GeHNQhYvd3GuptjGoPnXUka8VcSeHhOYe/EWoPLlfhiswfsA/od9LFaon+ufbFKhbTw4CIiV94Rqdoa0YEh430Y8FSNJ5o3Tw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786952166; c=relaxed/simple; bh=lEk0SclJKmCeOONonlumw1vxssS2338/E7j6W5x6AqQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=o2yhNCwfyMF1COQwcLyJUIKgltBttG6x03HmigkhCjbViJMKzUFQeeR/TP4Hr34oEs74iBeU69qFyX4sX4gvl/RZiUWH/7iFuKoPtKG/O9+9slQZvLQqfGjs7Pzxi1fe5PKKSizXXmVb+x/5Scz/dRhvEBh+awaXacEpT8ryUCs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=thXoL/VV; arc=fail smtp.client-ip=52.101.53.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="thXoL/VV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y8l3j895EJmqwGRyR78+3pSrUg77w9QyDE6OQ3G1ZuhKopkcYRlu16+4iXK6EotnqjvnPKgacedGT2TpyREuijAPzlWwMgN6tK2YJtcmr8IxbklNNdf6jwcREzSE/kwQWK5/QaOtgpxINOY0wb2eQ3KMA1BYCCsjUGu3tDpZ8anYKZw2ira4rVfPirIxGBiw5n6AmRXN3WIB250ylNk1S7TMl3P7GtlJGrmMGamLXMN6cK2Ik6mSJDcsEpydHxeb53ln1v4bP6I9yxkQIamirVNm821vZTsclnKFN8NWlzoIpCsOBBUR3eJsUYdK/WyijCMf7LpwyP5p+Wuz3zKSWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QBSTZu0tzcZCs4JdaxABFX/E7P8cf7Z9Tg0XpgIhTCM=; b=ZUG3jo/ilD8D2LtWIuJdnjU969s7zRYTFjRE1jkfQ30Enfa6vIpDfwFOwavtdWAJ0uksSJgVbyuakfGnmnqWw85hmUR0kgjvZWKBoroFF2flY4EkhawNUgcS64LR5/SFV1y8KrpaHJZfy3SPvSZig+8DY5IOHRW5ynurJll3a/JjnQ22eiQYiqwCg4NtZRmH+5+hiMfbEf2MoDwEeeznG5p66mj5q7zYbDuIgIirQWGSh2mGGC+foBAMQk1XFWk8LafGz9mj34whHJJb/5y3nkYNJ5KE2ztIi8OxlLinIUWkxJ4R564SiLifR1qUze0J391Er7Gn0HiqMZZ4fdIyrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QBSTZu0tzcZCs4JdaxABFX/E7P8cf7Z9Tg0XpgIhTCM=; b=thXoL/VVXwe1Zf+0+ZJlsZ854EaIyH/O8u52h1EBHThMfSW8L0yzNHs4+ax4qbEz9oFKl4Z22utpV7mVmi3YVYGXpM3lsLszImBgTm2JikM96ofN7bC/1zYFFOu3pmEjPcv/lV+jtqMk6nxcz1vsBLMH6dS9jJNN0npcL8QiJSAb2znZ5K2T62Y0Pj3JM1jM+B20I3r6z9sRvgkzVBvSgYOTbwyscTHSsireKmelDVJ49d1BotKYDNhYBuIb0P6nkYwNxHGTjhbBsyj2zSEDaNdPOgQo29fGF44lot6/kGkGRDVz+l69OgaO9XQQC9E8Ljs5VZxibNbKWXi4Go9tMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH1PR12MB9670.namprd12.prod.outlook.com (2603:10b6:610:2af::6) by CH1PPF5EBD457EF.namprd12.prod.outlook.com (2603:10b6:61f:fc00::610) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Mon, 17 Aug 2026 07:36:00 +0000 Received: from CH1PR12MB9670.namprd12.prod.outlook.com ([fe80::416:ea1f:d17b:2811]) by CH1PR12MB9670.namprd12.prod.outlook.com ([fe80::416:ea1f:d17b:2811%6]) with mapi id 15.21.0315.016; Mon, 17 Aug 2026 07:36:00 +0000 Message-ID: Date: Mon, 17 Aug 2026 17:35:53 +1000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/migrate_device: fix cache flush when replacing huge zero PMD To: Hui Su , Andrew Morton , David Hildenbrand Cc: Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260817060845.377800-2-sh_def@163.com> Content-Language: en-US From: Balbir Singh In-Reply-To: <20260817060845.377800-2-sh_def@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ME0P282CA0018.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:20d::16) To CH1PR12MB9670.namprd12.prod.outlook.com (2603:10b6:610:2af::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PR12MB9670:EE_|CH1PPF5EBD457EF:EE_ X-MS-Office365-Filtering-Correlation-Id: 242400bf-e09a-4915-fbbc-08defc322f51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|23010399003|22082099003|18002099003|56012099006|10067099003|11063799006; X-Microsoft-Antispam-Message-Info: 0kTqL7LNJ+/3KXwOlp9pl0qfVP5b/T+IyciOYmyMYFgV3emFxQ0ASbSOzg9XxMvTnDHf1vFewG/rezKpatPcYRFsxHwftIqh9yYTdDw0inaw2w7d/6PQx6wlMKRALYtnUKUVyPTAuJP9AaUsKP8nql1r7cW2T4wF5+1ufqgewMYM1pkOdDwa7HUNnMkz8vJLn+luh5FtgF5XjetvwtWeBhlkSWDCBPNWIXV/N9LOnwq5zwBVhxRgUh3f7RJq13w7gVtBMo9iMpVHdOFAcujUYDfON3OVi7LjD/J1XLy4vKbIhaIZ5f7SOwz/iyYmV7OOO0uL/iOX5iFDSJa2KbiiJZyGeQpRQEN7eo5EpVD7ek2I9L3c9pW58yDFuYjuC0zjPhwhL0LuQSiawj2YRhsHMNyS43GzHDjhKmjeTBIjWGQ5ibwKkX0/7haaSox+88zKVTXoBJ8+8KKsUIty9kjn4OPd0UexkB/I5vkV35Y5LDwqtFpb7QHG4VOynaPr4cTQTnDqLreT4UnZUoXLcQk7FpDvwzp5kcTR7C4Clx8QFenDe2hswHxYq5YdrmlvnvuP13KRyYNW7MLKy8geh+ep6KCWNcAVZPESlX3BBFCdNthm4sbDFG9pyBnIaK6aTTcNe371ijXeHIbXJT9Cj5pNsEoAOxpnTSCOJ5dFcv9shQg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH1PR12MB9670.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(23010399003)(22082099003)(18002099003)(56012099006)(10067099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wjc4K1NqdmNiQkg5aU9Qb1hCcGVZMHJ6V2ZTc0FBRit3LzZOVFZZVGt2bkRV?= =?utf-8?B?L2pGZnBTL3ZzbE5aUDUzMzFvTHZUd0c3ZlNPSzY2YVZWa1NURnpoYlVsZmNm?= =?utf-8?B?KzNaQjU1c0tYL2JTUjM2dWRNQlZQbTlhZUgvVlFCbUlMTGlrMGZ0NzY5S0Jz?= =?utf-8?B?bWszSUhoalA3WUo4TElxMWdwcFlDNFJzdUhiWFUvTW5WNGpvVmJjdUZlazhB?= =?utf-8?B?U1FYUkNSQllFQ3dqeDRGTzZZalNTZlA4bDJWTXZlVmltUzgwd3dDRXpudzRV?= =?utf-8?B?Qko5aE56NHd5MDFEMFFTRFRDdm5rcG9ZdmxUYkFDWDhQN0tZSnRzVHBBQWZF?= =?utf-8?B?TjRRcHF3c1BXSTAweXlla0wyd0lEMFJxNUJQRmtsZ2JBNVVkdzRuQjVQUE1m?= =?utf-8?B?UmtoUDZ0WXgyUTIxa3VId0J2bWxoZGtQRU5NbWJUTnMwdndMeVBSRzgwK3FB?= =?utf-8?B?L2ZLN1dFenJ2TUJaeHdLK1dIZGttZWE5RkhSd0pnSDNWZVNzc1dBUldLbE5l?= =?utf-8?B?cEEvSUhSVDV0TDVvaklBNWVEWENVTWViRDNFK1V0NlNEZFB5ZFVFcVJOc20x?= =?utf-8?B?ZjhnT3VSdkwrNmFTN2FDaDk5ZUIyUDZNOWI0Znp2bXM5N0ZFbUxPbU5CVWxn?= =?utf-8?B?LzhXZHBPOUJrbEVna0NmRzlYWks3V2d0c0I5UFhIbERveVZlaEFUWS9wTnpG?= =?utf-8?B?ckZpcVpKaElGb2I3clhIN2ZnZjVkaW0zYTNSM1o1U3ArVFFLN2tyRXh3dlll?= =?utf-8?B?dlVjQ2lRV25Wc2tBeW1lYVFTazBJRHg2RGhoNlhGZm04NHZFN1lBbzRpOWVE?= =?utf-8?B?UDZhb0NlV1hRdFc1WXhFb3ZpZlRHN05FUkc3K2pHbmNPbXJBOFFQY2FBMkMx?= =?utf-8?B?NWg4aW1iak9oVHRqaTNoWXhXVjQ2RWt5bGppVE9qRjR1RzNSTktlRkljMG8v?= =?utf-8?B?amxIdnByaEhKWEkyWXh3TE1oZENoOTRlRTZWaWpqMlBka1JlUUZ6Q0d1eDNz?= =?utf-8?B?UE9VOHNQdllQT3M5eHpublRIcjBHVjdVYys3WEx5T0hVdGFSQVdpdjRMRDk3?= =?utf-8?B?MDI0bTNrOEhuTTRwU0lsNjkrYTZUc3VDNVdWSHA0NHFqWXFPa0JqcUJLY3Vu?= =?utf-8?B?NzRPVk9xMjdydS9zZzNkNUhuQis2ZXBhSDE3TG5qRVpTam1yeTVCVm94Ui9k?= =?utf-8?B?eUpocjN3SHlJOEhtMld0MlRGWnRZYVJFMG55WWtEb3ZHVE83WGxpMTVGVWtC?= =?utf-8?B?R01JNVZYUStMa2l2UUIxZytXTWdzYk5yckxHWS8vbFgwZXFnMHBtNVpDMnVu?= =?utf-8?B?YmJGdUdqQ2Z1emJlUm92dUxzcTF0b2hESHA0UVdPbU5kVXhsbTRUZTBrdnRW?= =?utf-8?B?SFIraW9yOUk3YmRIZDUrbSs4QW5rV1kzSjNyMU1tTE1oUFpOSm9Sa1hkd0E4?= =?utf-8?B?cUFwYWNZTEpNdXVHZnF2VGlhUWptNU5uNUYvVmlBRHhnS0NrNE1xcGErWFBa?= =?utf-8?B?MkhyK0d4V1NYbW5leE9ZR0ZDSXo1T2VTRWVvaHZDZUVJdTh1c09RVk80REZ3?= =?utf-8?B?aHVYMjJQcE1IUkJMVk16bE5uUmI5VFIwTXRzZ3FPVitSNnVWZ0JFd0VOWk82?= =?utf-8?B?cFRramw3RHZVa2dQZUZMQ3l2KzNMOGw3SExBUDhaeXVDYkNIc09oaXUzSjlE?= =?utf-8?B?T3BSdEk5SGlUUG5QbHhoaStDdFNPSVhxdlVQME1Ea0ozSDJTeFNRNjFESU5h?= =?utf-8?B?TnQxRCtPdHN6ZXB1akFrTGhLZ1FmZE9xMVVMd0owKzcraFNCcnl3eU1hNC9W?= =?utf-8?B?V0hjaXVSUXFEeXhDZnBndUNVd2E0NHp1Q3VaTFdwTUsxQ3dWelJIN1N2amdz?= =?utf-8?B?Yk9ONVJYYzBQRjMyQVJicVZOWi9sWk5rbzkrWXNXZDlGUStOb0p2Z00xYkls?= =?utf-8?B?N25wOUhyT2lDRnIyMmNEWXYzWHpzTzZ5M01xS2F2eE9MeTJhTUZzUDBPYnQ0?= =?utf-8?B?dUtqcUNydjRLc0krU1BoZzlQaHVnQURJUm9HUnpUVVg5eUEyMCtQOFpBWVIr?= =?utf-8?B?TnV6Uk90dUV1UWw0aEFBNk5VQnVFa3VUOHBhM2ZqZUhwYklWWks4V3RxM2Iw?= =?utf-8?B?RGZCcFR0OHVpTGNYMTJBdlRnbkxDMmN0RjJuVnRsVTROVWd0VmFMajRlMHNC?= =?utf-8?B?VllYUm5FS1FvZXlvYnlQamU4Y2JDRjkwT05uUWJxcGNJbWlpRHMvazNDREJl?= =?utf-8?B?bXNleTN2SDlvK2ltUjRINmFLNFBWWHNHdjdHck1IMCswYWxnWVYzamppaFpF?= =?utf-8?B?WFJlaVlHdHVLYXNTVmZxM0lnU2ttQ0M5ajhYK3d3Zk1XWXkzVHMwQT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 242400bf-e09a-4915-fbbc-08defc322f51 X-MS-Exchange-CrossTenant-AuthSource: CH1PR12MB9670.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2026 07:36:00.7245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 73FK07OOh312MvQbUbx+0Yk30coRIK8urUu/XBCmR/Q2f26tUixhxgw2Hsx6YhBhC4pxGbny8xeXeKhzwoCJow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPF5EBD457EF On 8/17/26 4:08 PM, Hui Su wrote: > migrate_vma_insert_huge_pmd_page() calls flush_cache_page() before > replacing an existing huge zero PMD. However, the third argument to > flush_cache_page() is a PFN, while addr + HPAGE_PMD_SIZE is an end > virtual address. > > More importantly, the mapping being invalidated is PMD-sized rather > than PAGE_SIZE-sized. Flush the whole PMD range with > flush_cache_range(), matching other huge PMD invalidation paths. > > Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device pages") > Signed-off-by: Hui Su > --- > mm/migrate_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 908d2d4ec43a..098c04c1b124 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -872,7 +872,7 @@ static int migrate_vma_insert_huge_pmd_page(struct migrate_vma *migrate, > > if (flush) { > pte_free(vma->vm_mm, pgtable); > - flush_cache_page(vma, addr, addr + HPAGE_PMD_SIZE); > + flush_cache_range(vma, addr, addr + HPAGE_PMD_SIZE); > pmdp_invalidate(vma, addr, pmdp); > } else { > pgtable_trans_huge_deposit(vma->vm_mm, pmdp, pgtable); Reviewed-by: Balbir Singh