From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FEBC433EF for ; Thu, 26 May 2022 15:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346462AbiEZPgU (ORCPT ); Thu, 26 May 2022 11:36:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237111AbiEZPgT (ORCPT ); Thu, 26 May 2022 11:36:19 -0400 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61FC5BCEA6 for ; Thu, 26 May 2022 08:36:17 -0700 (PDT) Received: from omf20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D598596; Thu, 26 May 2022 15:36:16 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA id 2E10E2002A; Thu, 26 May 2022 15:36:15 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 01/28] lib/printbuf: New data structure for printing strings From: Joe Perches To: Kent Overstreet , Petr Mladek Cc: linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org, rostedt@goodmis.org, senozhatsky@chromium.org, andriy.shevchenko@linux.intel.com, willy@infradead.org Date: Thu, 26 May 2022 08:36:14 -0700 In-Reply-To: <20220526152127.gw7gb4jnoikop4hl@moria.home.lan> References: <20220519172421.162394-1-kent.overstreet@gmail.com> <20220519172421.162394-2-kent.overstreet@gmail.com> <20220526152127.gw7gb4jnoikop4hl@moria.home.lan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 2E10E2002A X-Stat-Signature: re8mr6iqgaqckdmzyoqapfn7d6u8ehdi X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/jTM04rXRmp+mKrB2FBSeZQSp0hn9TN9o= X-HE-Tag: 1653579375-14664 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-05-26 at 11:21 -0400, Kent Overstreet wrote: > On Thu, May 26, 2022 at 05:06:15PM +0200, Petr Mladek wrote: > > The "pr_" prefix is a nightmare for me because the same prefix > > is used also for printk() API ;-) > > > > Could we please use "pb_" instead? > > I'm not entirely against that, but I see printbufs as already in this patchset > tightly coupled to vsprintf.c and thus quite related to printk, as well - and > there aren't that many different pr_ things. So I think the shared prefix makes > some sense, I'd like to hear what others think before making that change. I think the reused prefix is not good. bufs are not printks.