From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5CA21F16B for ; Mon, 2 Mar 2026 00:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772409692; cv=none; b=dThVceref+pdgKd9VzCu5lEDz4lCB1uX+D6qYztMplJEV/Hke4ADE2TdIqRtvCZYmWEd7wRbsWFiw6rG61i0JX8j597AjPhV7kRt5/VMS0UG9KCbMkIw9ehlptsYYwkh+PKoh87mdMnKKhW/dpPdX9FPHHWP50VtM9b/hhQ4i3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772409692; c=relaxed/simple; bh=eFZMfr+s0Q1UNOMfLG3ds5RmyUtjt747TkosvoFWIWI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XEBYsp8k+qbj+rn5P+EtCprkf1UFzMymWgWgSYhWhRGdP03C8Ik8fCDQpqUgFVrDhvKvnuzej7aYJL1AvF1BUn2EjwDHSFf8MmDBJSXPr7OmPq5sx/bqAt/QuHUkikd7r36fd8btosKWa4l8BoqG9T0mcXyxf6dIyd4DC4M7O+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IIJUHd55; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IIJUHd55" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12732e6a123so3951100c88.1 for ; Sun, 01 Mar 2026 16:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772409690; x=1773014490; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=OfArcU3dsTEXyfI4YzrqdiJ40D8RtnJz+9pcEe41QRs=; b=IIJUHd55Sb3qO1XdCzysM72J+evfQl5CkODxAisZ3I5WOUarunsVF0+FNZ9qjNDbRA Yr0eF6UaR47713K+6OxejLdPtj6xlLVcIp9sMym88yHWKPJHLgPoXYuotBvleRMljAqL /b9r5jojct+82qhcw33gbJ33hYGfyrEiLpir6qrRdcvb67NJRQgpHlSn3fX6CrAUTllH HKSviWCgNhpA1Y8TjldwMpMKvAWARRhYaLnA2U2htvHMYeBAIXxNlbZT+rAyxGC+HllR INXY6GJfvRLOkCAw2nBgJgwRHOmNqfZXTJAvRgt0mPtfGE2yss8nvmKTQn8eMWAtmw/y sTMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772409690; x=1773014490; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OfArcU3dsTEXyfI4YzrqdiJ40D8RtnJz+9pcEe41QRs=; b=FvnC9YOuPH5smQx0+4cpYJpU4TBFp+zZNBX4w3Gi87rJ1FMuTVw1QzQNi79Y5X6UDa /Kr7zddFmr+DMsW/DoGmPNltKvksQE1x4SIwgzRfw2P8pKkRMjVHERkVHjOXaqRhU1+T g6oSniJ3me3moOr0d8i7nTh1lLaKoq3g4Dzbkq3cbEgZRgBEK/XirDFYsp/yj0BfowAa JjMUkFmxnVYJbKjcoqQVzqW7bSJeM+M7Ul6etdtgv7ajhVx8LEy/V1aCKUd/Nmj5aZ6E lihQCn7UuLq7A0BUbxATxZS9P7HPskanEzqT36B7VYgsh8TrSE+THYJcD84hcRwRVph6 zgHw== X-Forwarded-Encrypted: i=1; AJvYcCXuBtnMdLGsEdp17PWAt64w6EFiMYjO8gWdAxpU/B4aI/DTA7HqMBx5f9GT4lrCPd28d/ypY3tUEZ3kja8=@vger.kernel.org X-Gm-Message-State: AOJu0YwuAWALgwURjgOrlwYbF2Dw5BK/oSF/zvOksVggva0lXdxfVR/L Uh3vjSCPt01nfIji6QKHFgo97eXmss/lv4phOfGEUj8jhtJ+JjbwLGu/ X-Gm-Gg: ATEYQzzhxk6vj+uYo1dvuz/hkuJOjyLjBkah59Llwh/ywsbPdof5SaVTA19Q0NZD597 r+O7Ri0+veCoVpZopGEy+4AJZk6a1/4kg0CYhvQw/H+4V3cx+yZ6yb+OpEvxm/T2oUyMdVKJsOl Gi6EpndGxX5HOvQmfnoj9VhVff7AF1BvYTj9H9vQLbbe9kSCnZ+3YdzxacFtEWycugVD+K56wED wLdNR19DGLGhDdS8DfZhO0kps5CKQxGAybBWshb4PrX5P61Aqgz4xQvq7yPEw5+rm52Gma16pz1 POsnds4dI3nFXeA2gvHm5r5KtGwiAiGxEwJL4oDn2AhK8zqU9Q7UxWDhvFvJxghpLOliyELUaBA QepKarNn6JnKcPI0gBSZxR+9j9FLfvRsb6e5wbmg01xcj3dfGMbLCOpUCFpSbgUO66CIn21805m MawBkvpkLR3IcC77w3mYLPVyZWcYaLR3yyeJFX X-Received: by 2002:a05:7301:1e96:b0:2ae:5ffa:8da4 with SMTP id 5a478bee46e88-2bde1bbf780mr4542339eec.1.1772409689898; Sun, 01 Mar 2026 16:01:29 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be1731b6b6sm94244eec.5.2026.03.01.16.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 16:01:29 -0800 (PST) Sender: Guenter Roeck Date: Sun, 1 Mar 2026 16:01:28 -0800 From: Guenter Roeck To: "Rafael J. Wysocki" Cc: Jaroslav Pulchart , LKML , Linux ACPI , linux-hwmon@vger.kernel.org Subject: Re: [PATCH v1 3/3] hwmon: (acpi_power_meter) Convert ACPI driver to a platform one Message-ID: References: <5974797.DvuYhMxLoT@rafael.j.wysocki> <1952740.tdWV9SEqCh@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1952740.tdWV9SEqCh@rafael.j.wysocki> On Sun, Mar 01, 2026 at 02:18:49PM +0100, Rafael J. Wysocki wrote: > From: "Rafael J. Wysocki" > > In all cases in which a struct acpi_driver is used for binding a driver > to an ACPI device object, a corresponding platform device is created by > the ACPI core and that device is regarded as a proper representation of > underlying hardware. Accordingly, a struct platform_driver should be > used by driver code to bind to that device. There are multiple reasons > why drivers should not bind directly to ACPI device objects [1]. > > Overall, it is better to bind drivers to platform devices than to their > ACPI companions, so convert the hwmon ACPI power meter driver to a > platform one. > > After this change, the subordinate hwmon device will be registered > under the platform device representing the ACPI power meter, sysfs > notifications will trigger on that device, and diagnostic messages > will be printed relative to it instead of its ACPI companion. > > Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1] > Signed-off-by: Rafael J. Wysocki Thanks a lot for this cleanup work. I decided to apply the entire series right away to hopefully get some test feedback before the next commit window. Thanks, Guenter