From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
harry.wentland@amd.com
Cc: sunpeng.li@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Jun.Lei@amd.com, Alvin.Lee2@amd.com,
meenakshikumar.somasundaram@amd.com, martin.leung@amd.com,
Dillon.Varone@amd.com, wenjing.liu@amd.com, alex.hung@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, yusongping@huawei.com,
hukeping@huawei.com, artem.kuzin@huawei.com
Subject: Re: [PATCH] drm: amd: display: Fix memory leakage
Date: Thu, 12 Jan 2023 11:00:50 -0500 [thread overview]
Message-ID: <b93c319e-b1c9-7488-7f0e-d96a6f98ad79@amd.com> (raw)
In-Reply-To: <20221130025046.2667372-1-konstantin.meskhidze@huawei.com>
On 11/29/22 21:50, Konstantin Meskhidze wrote:
> This commit fixes memory leakage in dc_construct_ctx() function.
>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 997ab031f816..359e28d3567e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -878,6 +878,7 @@ static bool dc_construct_ctx(struct dc *dc,
>
> dc_ctx->perf_trace = dc_perf_trace_create();
> if (!dc_ctx->perf_trace) {
> + kfree(dc_ctx);
> ASSERT_CRITICAL(false);
> return false;
> }
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
And applied to amd-staging-drm-next.
Thanks
Siqueira
prev parent reply other threads:[~2023-01-12 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 2:50 Konstantin Meskhidze
2023-01-12 16:00 ` Rodrigo Siqueira Jordao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93c319e-b1c9-7488-7f0e-d96a6f98ad79@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=Alvin.Lee2@amd.com \
--cc=Dillon.Varone@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=artem.kuzin@huawei.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hukeping@huawei.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.leung@amd.com \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®